[U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

This function causes a 5-second delay and stops the display working on minnie. This code should be in a driver and should only be enabled by a device-tree property, so that it does not affect devices which do not have this feature. Signed-off-by: Simon Glass --- arch/arm/mach-rockchip/boot_mode

Re: [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

> On 29.12.2018, at 14:16, Simon Glass wrote: > > This function causes a 5-second delay and stops the display working on > minnie. This code should be in a driver and should only be enabled by > a device-tree property, so that it does not affect devices which do not > have this feature. > > Si

Re: [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

Simon, As an alternative, you can turn this off by setting CONFIG_BOOT_MODE_REG=0 in your defconfig. We’ve done the same for our RK3399-Q7 module: configs/puma-rk3399_defconfig:CONFIG_ROCKCHIP_BOOT_MODE_REG=0x0 If this works for you, we can avoid removing this feature this late in the cy

Re: [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

Hi Philipp, On Sat, 29 Dec 2018 at 11:01, Philipp Tomsich wrote: > > Simon, > > As an alternative, you can turn this off by setting CONFIG_BOOT_MODE_REG=0 in > your defconfig. > We’ve done the same for our RK3399-Q7 module: > configs/puma-rk3399_defconfig:CONFIG_ROCKCHIP_BOOT_MODE_REG=0x0

Re: [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now[Please note, mail behalf by 3vnmnxammciszqnjoyvtpbt.vynrlcly.fhunyvjr-jopwz....@chromium-sendgmr.bounces.google.com]

Hi Simon, On 12/29/2018 09:16 PM, Simon Glass wrote: > This function causes a 5-second delay and stops the display working on > minnie. I don't understand why need 5-second, the logic is to check the adc key press to decide the mode, maybe because the different usage of the adc in minnie? Most

Re: [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now[Please note, mail behalf by 3vnmnxammciszqnjoyvtpbt.vynrlcly.fhunyvjr-jopwz....@chromium-sendgmr.bounces.google.com]

Hi, On Thu, 3 Jan 2019 at 00:32, Kever Yang wrote: > > Hi Simon, > > > On 12/29/2018 09:16 PM, Simon Glass wrote: > > This function causes a 5-second delay and stops the display working on > > minnie. > > I don't understand why need 5-second, the logic is to check the adc key > press to decide th

Re: [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now[Please note, mail behalf by 3vnmnxammciszqnjoyvtpbt.vynrlcly.fhunyvjr-jopwz....@chromium-sendgmr.bounces.google.com]

> On 03.01.2019, at 22:29, Simon Glass wrote: > > Hi, > > On Thu, 3 Jan 2019 at 00:32, Kever Yang > wrote: >> >> Hi Simon, >> >> >> On 12/29/2018 09:16 PM, Simon Glass wrote: >>> This function causes a 5-second delay and stops the display working on >>> mi