On 18/01/2012 21:05, Eric Nelson wrote:
>>
>> Yes, you're right - of course, I am open also to other solutions if they
>> are proofed to be better ;-).
>>
>
> I think this is about as good as things get with the current code base.
> I would argue that the driver would be better if it explicitly s
On 01/18/2012 01:39 AM, Stefano Babic wrote:
On 18/01/2012 02:44, Eric Nelson wrote:
I'll defer to Stefano on this one, since I did this in response
to his request:
Yes, I admit I am guilty about this !
The layout of the CSPI registers is not exactly the same for all SOCs.
For example, the MX
On 18/01/2012 17:08, Marek Vasut wrote:
> Ok guys, I see ... Stefano, you're ok with putting the reg structures into
> these
> header files?
The reg structures are already into these header files - the patch moves
only the bit meaning inside the imx-regs.h files. We can discuss if we
should mov
> On 18/01/2012 02:44, Eric Nelson wrote:
> > On 01/17/2012 06:27 PM, Marek Vasut wrote:
> >>> On 01/17/2012 04:19 PM, Marek Vasut wrote:
> > Signed-off-by: Eric Nelson
> > +/* ECSPI registers */
> > +struct cspi_regs {
> > +u32 rxdata;
> > +u32 txdata;
> > +u32
On 18/01/2012 02:44, Eric Nelson wrote:
> On 01/17/2012 06:27 PM, Marek Vasut wrote:
>>> On 01/17/2012 04:19 PM, Marek Vasut wrote:
> Signed-off-by: Eric Nelson
> +/* ECSPI registers */
> +struct cspi_regs {
> +u32 rxdata;
> +u32 txdata;
> +u32 ctrl;
> +u
On 01/17/2012 06:47 PM, Marek Vasut wrote:
On 01/17/2012 06:27 PM, Marek Vasut wrote:
I'll defer to Stefano on this one, since I did this in response
to his request:
>>
Right - and we already discussed in the past how to avoid to put
specific SOC code inside the driver. In fact, the cspi_regs
> On 01/17/2012 06:27 PM, Marek Vasut wrote:
> >> On 01/17/2012 04:19 PM, Marek Vasut wrote:
> Signed-off-by: Eric Nelson
> +/* ECSPI registers */
> +struct cspi_regs {
> +u32 rxdata;
> +u32 txdata;
> +u32 ctrl;
> +u32 cfg;
> +
On 01/17/2012 06:27 PM, Marek Vasut wrote:
On 01/17/2012 04:19 PM, Marek Vasut wrote:
Signed-off-by: Eric Nelson
+/* ECSPI registers */
+struct cspi_regs {
+ u32 rxdata;
+ u32 txdata;
+ u32 ctrl;
+ u32 cfg;
+ u32 intr;
+ u32 dma;
+ u32 stat;
+ u32
> On 01/17/2012 04:19 PM, Marek Vasut wrote:
> >> Signed-off-by: Eric Nelson
> >> ---
> >>
> >> arch/arm/include/asm/arch-mx6/imx-regs.h | 44
> >>
> >> ++ 1 files changed, 44 insertions(+), 0
> >> deletions(-)
> >>
> >> diff --git a/arch/arm/include/asm/arch-mx6/i
On 01/17/2012 04:19 PM, Marek Vasut wrote:
Signed-off-by: Eric Nelson
---
arch/arm/include/asm/arch-mx6/imx-regs.h | 44
++ 1 files changed, 44 insertions(+), 0
deletions(-)
diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h
b/arch/arm/include/asm/arch-mx6/imx-r
> Signed-off-by: Eric Nelson
> ---
> arch/arm/include/asm/arch-mx6/imx-regs.h | 44
> ++ 1 files changed, 44 insertions(+), 0
> deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h
> b/arch/arm/include/asm/arch-mx6/imx-regs.h index 7650cb9..00040c4
Signed-off-by: Eric Nelson
---
arch/arm/include/asm/arch-mx6/imx-regs.h | 44 ++
1 files changed, 44 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h
b/arch/arm/include/asm/arch-mx6/imx-regs.h
index 7650cb9..00040c4 100644
--- a/a
12 matches
Mail list logo
