Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-06 Thread Amit Virdi
Dear Marek, On 3/5/2012 11:51 PM, Marek Vasut wrote: Dear Amit Virdi, From: Shiraz Hashimshiraz.has...@st.com While receiving packets from FIFO sometimes the buffer provided was nonaligned. Fix this by taking a temporary aligned buffer and then copying the content to nonaligned buffer.

Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-06 Thread Marek Vasut
Dear Amit Virdi, Dear Marek, On 3/5/2012 11:51 PM, Marek Vasut wrote: Dear Amit Virdi, From: Shiraz Hashimshiraz.has...@st.com While receiving packets from FIFO sometimes the buffer provided was nonaligned. Fix this by taking a temporary aligned buffer and then copying the

Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 04:51:57 Marek Vasut wrote: On 3/5/2012 11:51 PM, Marek Vasut wrote: Amit Virdi wrote: While receiving packets from FIFO sometimes the buffer provided was nonaligned. Fix this by taking a temporary aligned buffer and then copying the content to nonaligned

Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-06 Thread Mike Frysinger
On Thursday 16 February 2012 07:03:38 Amit Virdi wrote: --- a/drivers/usb/gadget/designware_udc.c +++ b/drivers/usb/gadget/designware_udc.c + /* copy back tmp buffer to bufp if bufp is not word aligned */ + if ((int)bufp 0x3) { + bytp = (u8 *)tmp[0]; + for

Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-06 Thread Amit Virdi
Hey Mike, On 3/6/2012 9:39 PM, Mike Frysinger wrote: On Thursday 16 February 2012 07:03:38 Amit Virdi wrote: --- a/drivers/usb/gadget/designware_udc.c +++ b/drivers/usb/gadget/designware_udc.c + /* copy back tmp buffer to bufp if bufp is not word aligned */ + if ((int)bufp 0x3) {

Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-06 Thread Amit Virdi
Dear Marek, } This addresses EHCI cache problem, that's why you need bounce buffer, right? No. The problem was we were copying data word-by-word to a non-word aligned memory in the USB gadget. So, this is different from the USB host controller issue. I see ... why isn't buffer aligned

Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-05 Thread Marek Vasut
Dear Amit Virdi, From: Shiraz Hashim shiraz.has...@st.com While receiving packets from FIFO sometimes the buffer provided was nonaligned. Fix this by taking a temporary aligned buffer and then copying the content to nonaligned buffer. Signed-off-by: Shiraz Hashim shiraz.has...@st.com

[U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-02-16 Thread Amit Virdi
From: Shiraz Hashim shiraz.has...@st.com While receiving packets from FIFO sometimes the buffer provided was nonaligned. Fix this by taking a temporary aligned buffer and then copying the content to nonaligned buffer. Signed-off-by: Shiraz Hashim shiraz.has...@st.com Signed-off-by: Amit Virdi