Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-17 Thread Marek Vasut
On Monday, June 16, 2014 at 01:48:11 PM, Otavio Salvador wrote: On Mon, Jun 16, 2014 at 4:03 AM, Igor Grinberg grinb...@compulab.co.il wrote: Hi Otavio, On 06/16/14 05:24, Otavio Salvador wrote: On Sun, Jun 15, 2014 at 11:03 PM, Marek Vasut ma...@denx.de wrote: On Monday, June 16,

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-17 Thread Michael Trimarchi
Hi Marek Il 17/giu/2014 08:03 Marek Vasut ma...@denx.de ha scritto: On Monday, June 16, 2014 at 01:48:11 PM, Otavio Salvador wrote: On Mon, Jun 16, 2014 at 4:03 AM, Igor Grinberg grinb...@compulab.co.il wrote: Hi Otavio, On 06/16/14 05:24, Otavio Salvador wrote: On Sun, Jun 15,

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-17 Thread Igor Grinberg
Hi Otavio, On 06/16/14 14:48, Otavio Salvador wrote: On Mon, Jun 16, 2014 at 4:03 AM, Igor Grinberg grinb...@compulab.co.il wrote: Hi Otavio, On 06/16/14 05:24, Otavio Salvador wrote: On Sun, Jun 15, 2014 at 11:03 PM, Marek Vasut ma...@denx.de wrote: On Monday, June 16, 2014 at 03:39:08

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-17 Thread Stefano Babic
Hi Otavio, On 16/06/2014 02:46, Otavio Salvador wrote: There are board were we cannot do voltage negotiation but want to set the VSELECT bit forcely to ensure it to work at 1.8V. This commit adds CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT flag for this use. Signed-off-by: Otavio Salvador

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-17 Thread Stefano Babic
Hi Michael, On 17/06/2014 17:14, Michael Trimarchi wrote: Instead of adding a new compiler switch that should be documented (I have already read Marek's comments), what do you think to extend struct fsl_esdhc_cfg, putting for exmaple an options field with this kind of specialization ? I

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-17 Thread Michael Trimarchi
Hi Stefano On Tue, Jun 17, 2014 at 5:12 PM, Otavio Salvador ota...@ossystems.com.br wrote: On Tue, Jun 17, 2014 at 12:11 PM, Stefano Babic sba...@denx.de wrote: On 16/06/2014 02:46, Otavio Salvador wrote: There are board were we cannot do voltage negotiation but want to set the VSELECT bit

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-17 Thread Otavio Salvador
On Tue, Jun 17, 2014 at 12:11 PM, Stefano Babic sba...@denx.de wrote: On 16/06/2014 02:46, Otavio Salvador wrote: There are board were we cannot do voltage negotiation but want to set the VSELECT bit forcely to ensure it to work at 1.8V. This commit adds CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-17 Thread Marek Vasut
On Tuesday, June 17, 2014 at 08:06:38 AM, Michael Trimarchi wrote: Hi Marek Il 17/giu/2014 08:03 Marek Vasut ma...@denx.de ha scritto: On Monday, June 16, 2014 at 01:48:11 PM, Otavio Salvador wrote: On Mon, Jun 16, 2014 at 4:03 AM, Igor Grinberg grinb...@compulab.co.il wrote:

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-17 Thread Michael Trimarchi
Hi On Tue, Jun 17, 2014 at 5:49 PM, Marek Vasut ma...@denx.de wrote: On Tuesday, June 17, 2014 at 08:06:38 AM, Michael Trimarchi wrote: Hi Marek Il 17/giu/2014 08:03 Marek Vasut ma...@denx.de ha scritto: On Monday, June 16, 2014 at 01:48:11 PM, Otavio Salvador wrote: On Mon, Jun 16, 2014

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-16 Thread Igor Grinberg
Hi Otavio, On 06/16/14 05:24, Otavio Salvador wrote: On Sun, Jun 15, 2014 at 11:03 PM, Marek Vasut ma...@denx.de wrote: On Monday, June 16, 2014 at 03:39:08 AM, Otavio Salvador wrote: On Sun, Jun 15, 2014 at 10:27 PM, Marek Vasut ma...@denx.de wrote: On Monday, June 16, 2014 at 03:22:22 AM,

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-16 Thread Otavio Salvador
On Mon, Jun 16, 2014 at 4:03 AM, Igor Grinberg grinb...@compulab.co.il wrote: Hi Otavio, On 06/16/14 05:24, Otavio Salvador wrote: On Sun, Jun 15, 2014 at 11:03 PM, Marek Vasut ma...@denx.de wrote: On Monday, June 16, 2014 at 03:39:08 AM, Otavio Salvador wrote: On Sun, Jun 15, 2014 at 10:27

[U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-15 Thread Otavio Salvador
There are board were we cannot do voltage negotiation but want to set the VSELECT bit forcely to ensure it to work at 1.8V. This commit adds CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT flag for this use. Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- drivers/mmc/fsl_esdhc.c | 4 1 file

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-15 Thread Marek Vasut
On Monday, June 16, 2014 at 02:46:51 AM, Otavio Salvador wrote: There are board were Please fix your English and send a patch, thanks :) we cannot do voltage negotiation but want to set the VSELECT bit forcely to ensure it to work at 1.8V. This commit adds

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-15 Thread Otavio Salvador
On Sun, Jun 15, 2014 at 9:51 PM, Marek Vasut ma...@denx.de wrote: On Monday, June 16, 2014 at 02:46:51 AM, Otavio Salvador wrote: There are board were Please fix your English and send a patch, thanks :) I fixed the commit log, thanks. ... +#ifdef CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT +

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-15 Thread Marek Vasut
On Monday, June 16, 2014 at 03:22:22 AM, Otavio Salvador wrote: [...] +#ifdef CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT + esdhc_setbits32(regs-vendorspec, ESDHC_VENDORSPEC_VSELECT); +#endif Documentation is missing. There is no FSL ESDHC README file so that's why I didn't include it

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-15 Thread Otavio Salvador
On Sun, Jun 15, 2014 at 10:27 PM, Marek Vasut ma...@denx.de wrote: On Monday, June 16, 2014 at 03:22:22 AM, Otavio Salvador wrote: [...] +#ifdef CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT + esdhc_setbits32(regs-vendorspec, ESDHC_VENDORSPEC_VSELECT); +#endif Documentation is missing.

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-15 Thread Marek Vasut
On Monday, June 16, 2014 at 03:39:08 AM, Otavio Salvador wrote: On Sun, Jun 15, 2014 at 10:27 PM, Marek Vasut ma...@denx.de wrote: On Monday, June 16, 2014 at 03:22:22 AM, Otavio Salvador wrote: [...] +#ifdef CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT +

Re: [U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

2014-06-15 Thread Otavio Salvador
On Sun, Jun 15, 2014 at 11:03 PM, Marek Vasut ma...@denx.de wrote: On Monday, June 16, 2014 at 03:39:08 AM, Otavio Salvador wrote: On Sun, Jun 15, 2014 at 10:27 PM, Marek Vasut ma...@denx.de wrote: On Monday, June 16, 2014 at 03:22:22 AM, Otavio Salvador wrote: [...] +#ifdef