Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-10-24 Thread sjg
On Tue, Oct 23, 2018 at 11:01 AM Marek Vasut wrote: > > On 10/19/2018 05:25 AM, Simon Glass wrote: > > On 9 August 2018 at 13:04, Simon Goldschmidt > > wrote: > >> If _debug_uart_putc() is called before _debug_uart_init(), the > >> ns16550 debug uart driver hangs in a tight loop waiting for the >

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-10-23 Thread Simon Goldschmidt
On Tue, Oct 23, 2018 at 11:01 AM Marek Vasut wrote: > > On 10/19/2018 05:25 AM, Simon Glass wrote: > > On 9 August 2018 at 13:04, Simon Goldschmidt > > wrote: > >> If _debug_uart_putc() is called before _debug_uart_init(), the > >> ns16550 debug uart driver hangs in a tight loop waiting for the >

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-10-23 Thread Marek Vasut
On 10/19/2018 05:25 AM, Simon Glass wrote: > On 9 August 2018 at 13:04, Simon Goldschmidt > wrote: >> If _debug_uart_putc() is called before _debug_uart_init(), the >> ns16550 debug uart driver hangs in a tight loop waiting for the >> tx FIFO to get empty. >> >> As this can happen via a printf sne

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-10-18 Thread Simon Glass
On 9 August 2018 at 13:04, Simon Goldschmidt wrote: > If _debug_uart_putc() is called before _debug_uart_init(), the > ns16550 debug uart driver hangs in a tight loop waiting for the > tx FIFO to get empty. > > As this can happen via a printf sneaking in before the port calls > debug_uart_init(),

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-08-10 Thread Marek Vasut
On 08/10/2018 01:37 PM, Simon Goldschmidt wrote: > On 10.08.2018 11:51, Marek Vasut wrote: >> On 08/10/2018 07:22 AM, Simon Goldschmidt wrote: >>> On 10.08.2018 00:41, Marek Vasut wrote: On 08/10/2018 12:35 AM, Andy Shevchenko wrote: > On Fri, Aug 10, 2018 at 12:45 AM, Marek Vasut wrote:

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-08-10 Thread Simon Goldschmidt
On 10.08.2018 11:51, Marek Vasut wrote: On 08/10/2018 07:22 AM, Simon Goldschmidt wrote: On 10.08.2018 00:41, Marek Vasut wrote: On 08/10/2018 12:35 AM, Andy Shevchenko wrote: On Fri, Aug 10, 2018 at 12:45 AM, Marek Vasut wrote: On 08/09/2018 11:13 PM, Adam Ford wrote: On Thu, Aug 9, 2018 a

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-08-10 Thread Marek Vasut
On 08/10/2018 07:22 AM, Simon Goldschmidt wrote: > On 10.08.2018 00:41, Marek Vasut wrote: >> On 08/10/2018 12:35 AM, Andy Shevchenko wrote: >>> On Fri, Aug 10, 2018 at 12:45 AM, Marek Vasut wrote: On 08/09/2018 11:13 PM, Adam Ford wrote: > On Thu, Aug 9, 2018 at 2:08 PM Simon Goldschmidt

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-08-09 Thread Simon Goldschmidt
On 10.08.2018 00:41, Marek Vasut wrote: On 08/10/2018 12:35 AM, Andy Shevchenko wrote: On Fri, Aug 10, 2018 at 12:45 AM, Marek Vasut wrote: On 08/09/2018 11:13 PM, Adam Ford wrote: On Thu, Aug 9, 2018 at 2:08 PM Simon Goldschmidt wrote: If _debug_uart_putc() is called before _debug_uart_ini

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-08-09 Thread Marek Vasut
On 08/10/2018 12:35 AM, Andy Shevchenko wrote: > On Fri, Aug 10, 2018 at 12:45 AM, Marek Vasut wrote: >> On 08/09/2018 11:13 PM, Adam Ford wrote: >>> On Thu, Aug 9, 2018 at 2:08 PM Simon Goldschmidt >>> wrote: If _debug_uart_putc() is called before _debug_uart_init(), the ns16550 d

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-08-09 Thread Andy Shevchenko
On Fri, Aug 10, 2018 at 12:45 AM, Marek Vasut wrote: > On 08/09/2018 11:13 PM, Adam Ford wrote: >> On Thu, Aug 9, 2018 at 2:08 PM Simon Goldschmidt >> wrote: >>> >>> If _debug_uart_putc() is called before _debug_uart_init(), the >>> ns16550 debug uart driver hangs in a tight loop waiting for the

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-08-09 Thread Marek Vasut
On 08/09/2018 11:13 PM, Adam Ford wrote: > On Thu, Aug 9, 2018 at 2:08 PM Simon Goldschmidt > wrote: >> >> If _debug_uart_putc() is called before _debug_uart_init(), the >> ns16550 debug uart driver hangs in a tight loop waiting for the >> tx FIFO to get empty. >> >> As this can happen via a print

Re: [U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-08-09 Thread Adam Ford
On Thu, Aug 9, 2018 at 2:08 PM Simon Goldschmidt wrote: > > If _debug_uart_putc() is called before _debug_uart_init(), the > ns16550 debug uart driver hangs in a tight loop waiting for the > tx FIFO to get empty. > > As this can happen via a printf sneaking in before the port calls > debug_uart_in

[U-Boot] [PATCH 5/6] serial: ns16550: fix debug uart putc called before init

2018-08-09 Thread Simon Goldschmidt
If _debug_uart_putc() is called before _debug_uart_init(), the ns16550 debug uart driver hangs in a tight loop waiting for the tx FIFO to get empty. As this can happen via a printf sneaking in before the port calls debug_uart_init(), let's rather ignore characters before the debug uart is initiali