Commit 6fbbcfd introduced device-tree support for MMC devices on
the mx7sabresd boards and didn't include BLK, which requires BLK.
Commit 8ae5bb3 did the same for secure boot.
Fix both by allowing blk-uclass (BLK) support.
Tested-by: Fabio Estevam
Signed-off-by: Eric Nelson
---
V2 includes the
On Wed, Oct 11, 2017 at 02:45:25PM -0700, Eric Nelson wrote:
> Commit 6fbbcfd introduced device-tree support for MMC devices on
> the mx7sabresd boards and didn't include BLK, which requires BLK.
>
> Commit 8ae5bb3 did the same for secure boot.
>
> Fix both by allowing blk-uclass (BLK) support.
On Wed, Oct 11, 2017 at 6:49 PM, Tom Rini wrote:
> It sounds like BLK shouldn't be default y if DM_MMC but rather selected
> by DM_MMC. Yes?
What about this?
--- a/drivers/mmc/Kconfig
+++ b/drivers/mmc/Kconfig
@@ -13,6 +13,7 @@ config MMC
config DM_MMC
bool "Enable MMC controllers usi
On Wed, Oct 11, 2017 at 06:53:13PM -0300, Fabio Estevam wrote:
> On Wed, Oct 11, 2017 at 6:49 PM, Tom Rini wrote:
>
> > It sounds like BLK shouldn't be default y if DM_MMC but rather selected
> > by DM_MMC. Yes?
>
> What about this?
>
> --- a/drivers/mmc/Kconfig
> +++ b/drivers/mmc/Kconfig
> @
On Wed, Oct 11, 2017 at 6:55 PM, Tom Rini wrote:
> Yes, I think that's it, along with removing the default y if DM_MMC from
> the BLK entry. Thanks!
Ok, if I do as suggested:
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -1,7 +1,6 @@
config BLK
bool "Support block devices
On Wed, Oct 11, 2017 at 07:07:04PM -0300, Fabio Estevam wrote:
> On Wed, Oct 11, 2017 at 6:55 PM, Tom Rini wrote:
>
> > Yes, I think that's it, along with removing the default y if DM_MMC from
> > the BLK entry. Thanks!
>
> Ok, if I do as suggested:
>
> --- a/drivers/block/Kconfig
> +++ b/driv
On Wed, Oct 11, 2017 at 7:17 PM, Tom Rini wrote:
> Hmmm. So, if you have DM and DM_MMC, you need BLK. If you have DM and
> BLK and USB, you also need DM_USB (and vice-versa, if you have DM and DM_USB
> and
> not DM_MMC, things will break too, on another platform I bet). So,
> DM_USB should al
On Wed, Oct 11, 2017 at 06:17:12PM -0400, Tom Rini wrote:
> On Wed, Oct 11, 2017 at 07:07:04PM -0300, Fabio Estevam wrote:
> > On Wed, Oct 11, 2017 at 6:55 PM, Tom Rini wrote:
> >
> > > Yes, I think that's it, along with removing the default y if DM_MMC from
> > > the BLK entry. Thanks!
> >
> >
Tom,
On Thu, Oct 12, 2017 at 1:33 PM, Tom Rini wrote:
> OK, disregard what I had been saying. At this point, it's a matter of
> correcting and testing boards to have either DM_MMC (and DM_USB and BLK)
> on, or having DM_MMC off (because they want USB gadget support).
Here is what I tried:
http
On Thu, Oct 12, 2017 at 03:35:38PM -0300, Fabio Estevam wrote:
> Tom,
>
> On Thu, Oct 12, 2017 at 1:33 PM, Tom Rini wrote:
>
> > OK, disregard what I had been saying. At this point, it's a matter of
> > correcting and testing boards to have either DM_MMC (and DM_USB and BLK)
> > on, or having D
On Thu, Oct 12, 2017 at 3:38 PM, Tom Rini wrote:
> Yes, just work on the imx* targets. For am33xx/am43xx/am57xx we don't
> want to swap things around as we then get rid of USB gadget support.
> It's a bit tricky atm to get all cases covered as, iirc, there's
> something outstanding for the USB g
On Thu, Oct 12, 2017 at 03:39:56PM -0300, Fabio Estevam wrote:
> On Thu, Oct 12, 2017 at 3:38 PM, Tom Rini wrote:
>
> > Yes, just work on the imx* targets. For am33xx/am43xx/am57xx we don't
> > want to swap things around as we then get rid of USB gadget support.
> > It's a bit tricky atm to get
12 matches
Mail list logo
