Re: [U-Boot] [PATCH V2 2/4] mtd/NAND: Add FSMC driver support

2012-05-17 Thread Amit Virdi
+while (num_err--) { +change_bit(0,err_idx[i]); +change_bit(1,err_idx[i]); + +if (err_idx[i] 512 * 8) { +change_bit(err_idx[i], dat); +i++; +} +} Is it normal to not count bit flips in the ECC itself? Correcting bit flip in

Re: [U-Boot] [PATCH V2 2/4] mtd/NAND: Add FSMC driver support

2012-05-16 Thread Amit Virdi
Hi Scott, On 5/16/2012 2:44 AM, Scott Wood wrote: On 05/07/2012 02:26 AM, Amit Virdi wrote: + while (num_err--) { + change_bit(0,err_idx[i]); + change_bit(1,err_idx[i]); + + if (err_idx[i] 512 * 8) { +

Re: [U-Boot] [PATCH V2 2/4] mtd/NAND: Add FSMC driver support

2012-05-16 Thread Amit Virdi
On 5/16/2012 2:44 AM, Scott Wood wrote: +case FSMC_VER8: +/* Busy waiting for ecc computation to finish for 512 bytes */ +while (!(readl(fsmc_regs_p-sts) FSMC_CODE_RDY)) +; Timeout? +uint16_t ecc_oob[7]; +uint8_t *oob = (uint8_t *)ecc_oob[0];

Re: [U-Boot] [PATCH V2 2/4] mtd/NAND: Add FSMC driver support

2012-05-16 Thread Amit Virdi
Three fixups. Signed-off-by: Amit Virdiamit.vi...@st.com Please discard this. I'll send changes in the V3 patchset. Thanks Amit Virdi ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH V2 2/4] mtd/NAND: Add FSMC driver support

2012-05-16 Thread Scott Wood
On 05/16/2012 05:41 AM, Amit Virdi wrote: Hi Scott, On 5/16/2012 2:44 AM, Scott Wood wrote: On 05/07/2012 02:26 AM, Amit Virdi wrote: +while (num_err--) { +change_bit(0,err_idx[i]); +change_bit(1,err_idx[i]); + +if (err_idx[i] 512 * 8) { +

Re: [U-Boot] [PATCH V2 2/4] mtd/NAND: Add FSMC driver support

2012-05-15 Thread Scott Wood
On 05/07/2012 02:26 AM, Amit Virdi wrote: + while (num_err--) { + change_bit(0, err_idx[i]); + change_bit(1, err_idx[i]); + + if (err_idx[i] 512 * 8) { + change_bit(err_idx[i], dat); + i++; + } +

[U-Boot] [PATCH V2 2/4] mtd/NAND: Add FSMC driver support

2012-05-07 Thread Amit Virdi
From: Vipin KUMAR vipin.ku...@st.com Flexible static memory controller is a peripheral provided by ST, which controls the access to NAND chips along with many other memory device chips eg NOR, SRAM. This patch adds the driver support for FSMC controller interfacing with NAND memory.