subject:"\[U\-Boot\] \[PATCH V2 2\/6\] ARM\: keystone2\: psc\-defs\: use adequate \(\) for macros"

Re: [U-Boot] [PATCH V2 2/6] ARM: keystone2: psc-defs: use adequate () for macros

2016-02-26 Thread Nishanth Menon

On Fri, Feb 26, 2016 at 12:17 PM, Tom Rini wrote: > On Thu, Feb 25, 2016 at 12:53:43PM -0600, Nishanth Menon wrote: > >> '#define X a | b' is better defined as '#define X (a | b)' for obvious >> reasons. >> >> Signed-off-by: Nishanth Menon > > Reviewed-by: Tom

Re: [U-Boot] [PATCH V2 2/6] ARM: keystone2: psc-defs: use adequate () for macros

2016-02-26 Thread Tom Rini

On Thu, Feb 25, 2016 at 12:53:43PM -0600, Nishanth Menon wrote: > '#define X a | b' is better defined as '#define X (a | b)' for obvious > reasons. > > Signed-off-by: Nishanth Menon Reviewed-by: Tom Rini But this makes my head hurt. Can we somehow do any of

[U-Boot] [PATCH V2 2/6] ARM: keystone2: psc-defs: use adequate () for macros

2016-02-25 Thread Nishanth Menon

'#define X a | b' is better defined as '#define X (a | b)' for obvious reasons. Signed-off-by: Nishanth Menon --- V2: No change V1: https://patchwork.ozlabs.org/patch/510211/ arch/arm/mach-keystone/include/mach/psc_defs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)