On Wednesday 22 July 2009 13:08:30 Wolfgang Denk wrote:
> Please do me (and yourself, and us all) a favour and just read the
> rules, and then follow them, instead of wasting our all time.
I'm pretty sure that I'm doing at least some developers a favour, in
discussing this issue. It's annoying no
Dear Stefan Roese,
In message <200907221312.17644...@denx.de> you wrote:
>
> Your version is 10 lines long, ours is 5. That twice as long. I still prefer
> our version and think this kind of personal freedom should be allowed.
Nobody attempts to restrict yoru thoughts or preferences.
But you wa
On Wednesday 22 July 2009 13:05:56 Wolfgang Denk wrote:
> I don't understand what's so difficult about it; just indent by TABs:
>
> struct ppc4xx_config ppc4xx_config_val[] = {
> {
> "133",
> "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> {
>
Dear Stefan Roese,
In message <200907221257.30824...@denx.de> you wrote:
>
> Fuck Ack. But: This has nothing to do with the problem we are discussing
> here.
> I was talking about alignment and not indentation. Do you want to forbid
> people use alignment at all?
Please do me (and yourself, an
Dear Matthias Fuchs,
In message <200907221214.25935.matthias.fu...@esd.eu> you wrote:
>
> > The braces should be indented by TABs.
> Can you please post a suggestion you you would like to this these
> lines indented. When I try to replace the spaces by TABs, the code
> looks very ugly and unreada
On Wednesday 22 July 2009 12:34:44 Wolfgang Denk wrote:
> > > Indentation is not done by TABs, but by TABs + spaces, and this is
> > > wrong.
> >
> > Why should this be wrong? This alignment looks better IMHO. Please allow
> > the developers a little bit of freedom.
>
> "Documentation/CodingStyle":
Dear Stefan Roese,
In message <200907221147.25539...@denx.de> you wrote:
>
> > Indentation is not done by TABs, but by TABs + spaces, and this is
> > wrong.
>
> Why should this be wrong? This alignment looks better IMHO. Please allow the
> developers a little bit of freedom.
"Documentation/Codi
Dear Wolfgang,
On Wednesday 22 July 2009 11:41, Wolfgang Denk wrote:
> Dear Stefan Roese,
>
> In message <200907220936.55822...@denx.de> you wrote:
> > Hi Wolfgang,
> >
> > On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
> > > > +struct ppc4xx_config ppc4xx_config_val[] = {
> > > > +
> >
Dear Matthias Fuchs,
In message <200907221024.33607.matthias.fu...@esd.eu> you wrote:
> On Wednesday 22 July 2009 09:26, Wolfgang Denk wrote:
> > Dear Matthias Fuchs,
> >
> > In message <12481717431327-git-send-email-matthias.fu...@esd.eu> you wrote:
> > > patch v2:
> > > - coding style cleanup
On Wednesday 22 July 2009 11:41:45 Wolfgang Denk wrote:
> > > Indentation by TAB , please.
> >
> > I don't see a problem here. The code is aligned to the lines above via
> > spaces (< 8 spaces). Example:
>
> The braces should be indented by TABs.
>
> > { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x
Dear Stefan Roese,
In message <200907220936.55822...@denx.de> you wrote:
> Hi Wolfgang,
>
> On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
> > > +struct ppc4xx_config ppc4xx_config_val[] = {
> > > +
> > > + { "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > > + { 0x19, 0x00,
On Wednesday 22 July 2009 10:24:33 Matthias Fuchs wrote:
> On Wednesday 22 July 2009 09:26, Wolfgang Denk wrote:
> > Dear Matthias Fuchs,
> >
> > In message <12481717431327-git-send-email-matthias.fu...@esd.eu> you
wrote:
> > > patch v2:
> > > - coding style cleanup
> > > - added CONFIG_PHY1_A
On Wednesday 22 July 2009 09:26, Wolfgang Denk wrote:
> Dear Matthias Fuchs,
>
> In message <12481717431327-git-send-email-matthias.fu...@esd.eu> you wrote:
> > patch v2:
> > - coding style cleanup
> > - added CONFIG_PHY1_ADDR
> > patch v3:
> > - refactor PLL reconfiguration code
> >
On Wednesday 22 July 2009 10:23:11 Matthias Fuchs wrote:
> > > Indentation by TAB , please.
> >
> > I don't see a problem here. The code is aligned to the lines above via
> > spaces (< 8 spaces). Example:
> >
> > { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > 0x00, 0x00, 0x00,
On Wednesday 22 July 2009 09:36, Stefan Roese wrote:
> Hi Wolfgang,
>
> On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
> > > +struct ppc4xx_config ppc4xx_config_val[] = {
> > > +
> > > + { "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > > + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x0
Hi Wolfgang,
On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
> > +struct ppc4xx_config ppc4xx_config_val[] = {
> > +
> > + { "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
Dear Matthias Fuchs,
In message <12481717431327-git-send-email-matthias.fu...@esd.eu> you wrote:
> patch v2:
> - coding style cleanup
> - added CONFIG_PHY1_ADDR
> patch v3:
> - refactor PLL reconfiguration code
> - beautify some one-line-functions
> patch v4:
> - remo
patch v2:
- coding style cleanup
- added CONFIG_PHY1_ADDR
patch v3:
- refactor PLL reconfiguration code
- beautify some one-line-functions
patch v4:
- remove 'sbe' command
- add CONFIG_CMD_CHIP_CONFIG support
- use ppc4xx_gpio struct for GPIO
18 matches
Mail list logo
