Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-12 Thread Stefano Babic
Hi Andy, On 12/02/2014 13:57, Andy Ng wrote: > From 45da8256deadb5c5cf38311ed5470e4ba5b20570 Mon Sep 17 00:00:00 2001 > From: Andy Ng > Date: Wed, 12 Feb 2014 12:40:47 + > Subject: [PATCH] SION bit has to be on for the pins that are used as > ENET_REF_CLK > > Signed-off-by: Andy Ng > --- Y

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-12 Thread Andy Ng
Shall I apply SION bit on imx6Q files too and bring all the changes under a single patch? Or there is problem with the existing one? Best regards A On Wed, Feb 12, 2014 at 12:57 PM, Andy Ng wrote: > From 45da8256deadb5c5cf38311ed5470e4ba5b20570 Mon Sep 17 00:00:00 2001 > From: Andy Ng > Date:

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-12 Thread Otavio Salvador
Hello Andy, On Wed, Feb 12, 2014 at 10:57 AM, Andy Ng wrote: > From 45da8256deadb5c5cf38311ed5470e4ba5b20570 Mon Sep 17 00:00:00 2001 > From: Andy Ng > Date: Wed, 12 Feb 2014 12:40:47 + > Subject: [PATCH] SION bit has to be on for the pins that are used as > ENET_REF_CLK > > Signed-off-by: A

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-12 Thread Andy Ng
>From 45da8256deadb5c5cf38311ed5470e4ba5b20570 Mon Sep 17 00:00:00 2001 From: Andy Ng Date: Wed, 12 Feb 2014 12:40:47 + Subject: [PATCH] SION bit has to be on for the pins that are used as ENET_REF_CLK Signed-off-by: Andy Ng --- arch/arm/include/asm/arch-mx6/mx6dl_pins.h |6 +++--- 1 fi

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-12 Thread Otavio Salvador
On Wed, Feb 12, 2014 at 9:58 AM, Stefano Babic wrote: > Hi Andy, > > On 12/02/2014 12:53, Andy Ng wrote: >> HI >> >> I was away the last few days. >> >> Shall I produce a patch for the u-boot git main line code with that fix? > > > Yes, please add your signed-off-by and rebase it on top of u-boot-

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-12 Thread Stefano Babic
Hi Andy, On 12/02/2014 12:53, Andy Ng wrote: > HI > > I was away the last few days. > > Shall I produce a patch for the u-boot git main line code with that fix? Yes, please add your signed-off-by and rebase it on top of u-boot-imx. Thanks, Stefano Babic -- =

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-11 Thread Stefano Babic
Hi Otavio, On 11/02/2014 14:03, Otavio Salvador wrote: > Hello, > > On Tue, Feb 11, 2014 at 9:11 AM, Stefano Babic wrote: >> Hi Otavio, >> >> On 11/02/2014 11:55, Otavio Salvador wrote: >>> Hello, >>> >>> On Tue, Feb 11, 2014 at 8:13 AM, Stefano Babic wrote: On 19/01/2014 15:34, Andy Ng wr

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-11 Thread Otavio Salvador
Hello, On Tue, Feb 11, 2014 at 9:11 AM, Stefano Babic wrote: > Hi Otavio, > > On 11/02/2014 11:55, Otavio Salvador wrote: >> Hello, >> >> On Tue, Feb 11, 2014 at 8:13 AM, Stefano Babic wrote: >>> On 19/01/2014 15:34, Andy Ng wrote: The ENET_REF_CLK has to loopback: the patch was produced fr

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-11 Thread Stefano Babic
Hi Otavio, On 11/02/2014 11:55, Otavio Salvador wrote: > Hello, > > On Tue, Feb 11, 2014 at 8:13 AM, Stefano Babic wrote: >> On 19/01/2014 15:34, Andy Ng wrote: >>> The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 >> >> We agree about your patch, but can you please fi

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-11 Thread Otavio Salvador
Hello, On Tue, Feb 11, 2014 at 8:13 AM, Stefano Babic wrote: > On 19/01/2014 15:34, Andy Ng wrote: >> The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 > > We agree about your patch, but can you please fix the issues reported by > Otavio (add your signed-off-by and reba

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-02-11 Thread Stefano Babic
Hi Andy, On 19/01/2014 15:34, Andy Ng wrote: > The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 > > We agree about your patch, but can you please fix the issues reported by Otavio (add your signed-off-by and rebase) and resubmit, please ? Thanks, Stefano Babic -

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-01-22 Thread Fabio Estevam
On Wed, Jan 22, 2014 at 5:19 AM, Markus Niebel wrote: > > IOMUX_CONFIG_SION is used everywhere for I2C dedicated pins - partly hard > coded for > mx6q - so yes, should be used fro enet_clk, too Yes, looks good. Regards, Fabio Estevam ___ U-Boot mail

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-01-21 Thread Markus Niebel
Am 19.01.2014 19:47, wrote Otavio Salvador: > On Sun, Jan 19, 2014 at 4:03 PM, Fabio Estevam wrote: >> On Sun, Jan 19, 2014 at 3:55 PM, Otavio Salvador >> wrote: >> >>> Personally I think when using the ALT 2 people are expecting it works >>> out of box so I think this should be in the PAD declar

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-01-19 Thread Otavio Salvador
On Sun, Jan 19, 2014 at 4:03 PM, Fabio Estevam wrote: > On Sun, Jan 19, 2014 at 3:55 PM, Otavio Salvador > wrote: > >> Personally I think when using the ALT 2 people are expecting it works >> out of box so I think this should be in the PAD declaration. > > This pin works out of the box in humming

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-01-19 Thread Fabio Estevam
On Sun, Jan 19, 2014 at 3:55 PM, Otavio Salvador wrote: > Personally I think when using the ALT 2 people are expecting it works > out of box so I think this should be in the PAD declaration. This pin works out of the box in hummingboard, for example. IOMUX_CONFIG_SION is not used anywhere in th

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-01-19 Thread Otavio Salvador
On Sun, Jan 19, 2014 at 3:48 PM, Fabio Estevam wrote: > Hi Otavio/Andy, > > On Sun, Jan 19, 2014 at 3:07 PM, Otavio Salvador > wrote: > >> --- a/arch/arm/include/asm/arch-mx6/mx6dl_pins.h >> +++ b/arch/arm/include/asm/arch-mx6/mx6dl_pins.h >> @@ -695,7 +695,7 @@ MX6_PAD_DECL(GPIO_1__GPIO1_IO01,

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-01-19 Thread Fabio Estevam
Hi Otavio/Andy, On Sun, Jan 19, 2014 at 3:07 PM, Otavio Salvador wrote: > --- a/arch/arm/include/asm/arch-mx6/mx6dl_pins.h > +++ b/arch/arm/include/asm/arch-mx6/mx6dl_pins.h > @@ -695,7 +695,7 @@ MX6_PAD_DECL(GPIO_1__GPIO1_IO01,0x05E0, > 0x0210, 5, 0x, 0, 0) > MX6_PAD_DECL(GPIO_1__SD1_C

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-01-19 Thread Otavio Salvador
Andy, On Sun, Jan 19, 2014 at 2:58 PM, Otavio Salvador wrote: > On Sun, Jan 19, 2014 at 12:34 PM, Andy Ng wrote: >> The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 > > Please: > > - Add Signed-off-by > - Rebase it to imx/master as this does not apply in current sou

Re: [U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-01-19 Thread Otavio Salvador
On Sun, Jan 19, 2014 at 12:34 PM, Andy Ng wrote: > The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 Please: - Add Signed-off-by - Rebase it to imx/master as this does not apply in current source code. -- Otavio Salvador O.S. Systems htt

[U-Boot] [PATCH imx6dl] Enable SION Bit for GPIO16 when ALT2 mode is selected

2014-01-19 Thread Andy Ng
The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 diff --git a/arch/arm/include/asm/arch-mx6/mx6dl_pins.h b/arch/arm/include/asm/arch-mx6/mx6dl_pins.h index 7851eb1..9c18847 100644 --- a/arch/arm/include/asm/arch-mx6/mx6dl_pins.h +++ b/arch/arm/include/asm/arch-mx6/mx6d