Dear Lukasz,
In message <20120727153345.008fde41@amdc308.digital.local> you wrote:
>
> So I suppose, that you are proposing something like this (pseudo code):
Yes, very close.
> int mmc_block_write() {
> sprintf(cmd_buf, "mmc write 0x%x %x %x")
> run_command(cmd_buf, 0);
> }
>
> in
Dear Marek Vasut,
In message <201207271515.36085.ma...@denx.de> you wrote:
>
> > sprintf(cmd_buf, "%s %s %d:%d 0x%x %s %lx",
> > command, device, ...
> >
> > and set command as needed to "fatread" or "ext2load" or whatever, and
> > device can be set to "mmc" or "usb" or ...
>
>
Dear Wolfgang Denk,
> Dear Lukasz Majewski,
>
> In message <1341416922-13792-5-git-send-email-l.majew...@samsung.com>
> you wrote:
> > Support for MMC storage devices to work with DFU framework.
>
> Sorry for jumping in late.
>
>
> > + switch (dfu->layout) {
> > + case RAW_ADDR:
> > +
Dear Wolfgang Denk,
> Dear Marek Vasut,
>
> In message <201207271443.45189.ma...@denx.de> you wrote:
> > > For this shim layer I would actually prefer the original approach
> > > (shown above) to use sprintf() to build commands based on the existing
> > > command interface
> >
> > We discussed i
Dear Marek Vasut,
In message <201207271443.45189.ma...@denx.de> you wrote:
>
> > For this shim layer I would actually prefer the original approach
> > (shown above) to use sprintf() to build commands based on the existing
> > command interface
>
> We discussed it for a while ... figure out the mi
Dear Wolfgang Denk,
> Dear Lukasz Majewski,
>
> In message <1341416922-13792-5-git-send-email-l.majew...@samsung.com> you
wrote:
> > Support for MMC storage devices to work with DFU framework.
>
> Sorry for jumping in late.
>
> > + switch (dfu->layout) {
> > + case RAW_ADDR:
> > +
Dear Lukasz Majewski,
In message <1341416922-13792-5-git-send-email-l.majew...@samsung.com> you wrote:
> Support for MMC storage devices to work with DFU framework.
Sorry for jumping in late.
> + switch (dfu->layout) {
> + case RAW_ADDR:
> + sprintf(cmd_buf, "mmc write 0x%x
>> > Generally it is in my opinion a good way to go.
>> >
>> > However, why we aren't first writing sanity checks for passed arguments?
>>
>> Simply because I didn't want to ask you to do a lot more unrelated work
>>
>> :) If you want to split and check the mmc (and fatwrite) argueuments
>>
>> and
Dear Tom Rini,
> On Thu, Jul 12, 2012 at 02:39:27PM +0200, Lukasz Majewski wrote:
> > On Wed, 11 Jul 2012 04:54:31 -0700
> >
> > Tom Rini wrote:
> > > On Tue, Jul 10, 2012 at 12:38:54PM +0200, Lukasz Majewski wrote:
> > > > Hi Tom,
> > > >
> > > > > On Wed, Jul 04, 2012 at 05:48:39PM +0200, Luk
On Thu, Jul 12, 2012 at 02:39:27PM +0200, Lukasz Majewski wrote:
> On Wed, 11 Jul 2012 04:54:31 -0700
> Tom Rini wrote:
>
> > On Tue, Jul 10, 2012 at 12:38:54PM +0200, Lukasz Majewski wrote:
> > > Hi Tom,
> > >
> > > > On Wed, Jul 04, 2012 at 05:48:39PM +0200, Lukasz Majewski wrote:
> > > > > Su
On Wed, 11 Jul 2012 04:54:31 -0700
Tom Rini wrote:
> On Tue, Jul 10, 2012 at 12:38:54PM +0200, Lukasz Majewski wrote:
> > Hi Tom,
> >
> > > On Wed, Jul 04, 2012 at 05:48:39PM +0200, Lukasz Majewski wrote:
> > > > Support for MMC storage devices to work with DFU framework.
> > > >
> > > > Signed
On Tue, Jul 10, 2012 at 12:38:54PM +0200, Lukasz Majewski wrote:
> Hi Tom,
>
> > On Wed, Jul 04, 2012 at 05:48:39PM +0200, Lukasz Majewski wrote:
> > > Support for MMC storage devices to work with DFU framework.
> > >
> > > Signed-off-by: Lukasz Majewski
> > > Signed-off-by: Kyungmin Park
> > >
Hi Tom,
> On Wed, Jul 04, 2012 at 05:48:39PM +0200, Lukasz Majewski wrote:
> > Support for MMC storage devices to work with DFU framework.
> >
> > Signed-off-by: Lukasz Majewski
> > Signed-off-by: Kyungmin Park
> > Cc: Marek Vasut
> [snip]
> > + case RAW_ADDR:
> > + sprintf(cmd_buf
On Wed, Jul 04, 2012 at 05:48:39PM +0200, Lukasz Majewski wrote:
> Support for MMC storage devices to work with DFU framework.
>
> Signed-off-by: Lukasz Majewski
> Signed-off-by: Kyungmin Park
> Cc: Marek Vasut
[snip]
> + case RAW_ADDR:
> + sprintf(cmd_buf, "mmc write 0x%x %x %x
Dear Lukasz Majewski,
> Support for MMC storage devices to work with DFU framework.
>
> Signed-off-by: Lukasz Majewski
> Signed-off-by: Kyungmin Park
> Cc: Marek Vasut
>
This one opens some questions.
[...]
> +int dfu_fill_entity_mmc(struct dfu_entity *dfu, char* s)
> +{
> + char *st =
Support for MMC storage devices to work with DFU framework.
Signed-off-by: Lukasz Majewski
Signed-off-by: Kyungmin Park
Cc: Marek Vasut
---
Changes for v2:
- None
---
drivers/dfu/Makefile |1 +
drivers/dfu/dfu_mmc.c | 126 +
2 files change
16 matches
Mail list logo
