Re: [U-Boot] [PATCH v2 6/8] omap_gpmc: BCH8 support (ELM based)

2012-11-21 Thread Andreas Bießmann
On 21.11.12 18:04, Tom Rini wrote: > On Thu, Nov 15, 2012 at 02:25:23PM +0100, Andreas Bießmann wrote: >> Dear Ilya Yanok, >> >> On 07.11.2012 00:06, Ilya Yanok wrote: >>> From: Mansoor Ahamed >>> >>> This patch adds support for BCH8 error correction code to omap_gpmc >>> driver. We use GPMC to ge

Re: [U-Boot] [PATCH v2 6/8] omap_gpmc: BCH8 support (ELM based)

2012-11-21 Thread Tom Rini
On Thu, Nov 15, 2012 at 02:25:23PM +0100, Andreas Bießmann wrote: > Dear Ilya Yanok, > > On 07.11.2012 00:06, Ilya Yanok wrote: > > From: Mansoor Ahamed > > > > This patch adds support for BCH8 error correction code to omap_gpmc > > driver. We use GPMC to generate codes/syndromes but we need ELM

Re: [U-Boot] [PATCH v2 6/8] omap_gpmc: BCH8 support (ELM based)

2012-11-17 Thread Peter Korsgaard
> "Andreas" == Andreas Bießmann writes: Hi, >> No, please not. Having more than 1 OOB layout on the same NAND device >> leads to all kind of complications. There has also been kernel patches >> posted for the ELM, so IMHO the only sane option for am33xx is BCH8 >> everywhere (with the RO

Re: [U-Boot] [PATCH v2 6/8] omap_gpmc: BCH8 support (ELM based)

2012-11-17 Thread Andreas Bießmann
Dear Peter Korsgaard, On 16.11.12 16:59, Peter Korsgaard wrote: >> "Andreas" == Andreas Bießmann writes: > > Hi, > > >> Please note that these patches are AM33XX-specific (as we are using > >> ELM that, I think, just isn't available on OMAP3) so we use OOB > >> layout that is compatible

Re: [U-Boot] [PATCH v2 6/8] omap_gpmc: BCH8 support (ELM based)

2012-11-16 Thread Peter Korsgaard
> "Andreas" == Andreas Bießmann writes: Hi, >> Please note that these patches are AM33XX-specific (as we are using >> ELM that, I think, just isn't available on OMAP3) so we use OOB >> layout that is compatible with AM33xx ROM boot code. Andreas> You are right, ELM is not available in O

Re: [U-Boot] [PATCH v2 6/8] omap_gpmc: BCH8 support (ELM based)

2012-11-16 Thread Andreas Bießmann
Dear Ilya Yanok, On 15.11.2012 21:08, Ilya Yanok wrote: > Dear Andreas, > > On Thu, Nov 15, 2012 at 2:25 PM, Andreas Bießmann > mailto:andreas.de...@googlemail.com>> wrote: > > Dear Ilya Yanok, > > On 07.11.2012 00:06, Ilya Yanok wrote: > > From: Mansoor Ahamed

Re: [U-Boot] [PATCH v2 6/8] omap_gpmc: BCH8 support (ELM based)

2012-11-15 Thread Andreas Bießmann
Dear Ilya Yanok, On 07.11.2012 00:06, Ilya Yanok wrote: > From: Mansoor Ahamed > > This patch adds support for BCH8 error correction code to omap_gpmc > driver. We use GPMC to generate codes/syndromes but we need ELM to find > error locations from given syndrome. > first of all, I wonder why t

[U-Boot] [PATCH v2 6/8] omap_gpmc: BCH8 support (ELM based)

2012-11-06 Thread Ilya Yanok
From: Mansoor Ahamed This patch adds support for BCH8 error correction code to omap_gpmc driver. We use GPMC to generate codes/syndromes but we need ELM to find error locations from given syndrome. Signed-off-by: Mansoor Ahamed [ilya: merge it with omap_gpmc driver, some fixes and cleanup] Sign