[U-Boot] [PATCH v3 07/10] usb: mxs: Adapt code for i.MX23 support

2013-02-17 Thread Otavio Salvador
The i.MX23 just one USB port so we shouldn't mess up with PLL1CTRL and USB1 port when building for i.MX23. Signed-off-by: Otavio Salvador --- Changes in v3: - Improve commit log - Move code to enable/disable clock to soc_ehci_hcd_{enable,disable}_clock - Proper use mx23 clock registers Changes i

Re: [U-Boot] [PATCH v3 07/10] usb: mxs: Adapt code for i.MX23 support

2013-02-17 Thread Fabio Estevam
On Sun, Feb 17, 2013 at 4:45 PM, Otavio Salvador wrote: > The i.MX23 just one USB port so we shouldn't mess up with PLL1CTRL and I think "MX23 has just one USB port" would be better. > -int ehci_hcd_init(int index, struct ehci_hccr **hccr, struct ehci_hcor > **hcor) > +static void soc_ehci_hcd_

Re: [U-Boot] [PATCH v3 07/10] usb: mxs: Adapt code for i.MX23 support

2013-02-17 Thread Otavio Salvador
On Sun, Feb 17, 2013 at 5:03 PM, Fabio Estevam wrote: > On Sun, Feb 17, 2013 at 4:45 PM, Otavio Salvador > wrote: >> The i.MX23 just one USB port so we shouldn't mess up with PLL1CTRL and > > I think "MX23 has just one USB port" would be better. > >> -int ehci_hcd_init(int index, struct ehci_hccr

Re: [U-Boot] [PATCH v3 07/10] usb: mxs: Adapt code for i.MX23 support

2013-02-17 Thread Fabio Estevam
On Sun, Feb 17, 2013 at 5:07 PM, Otavio Salvador wrote: > I did it but mxs gives the impression it does mostly the same in both > socs; as the code is mostly different between both I choose soc so it > is clear it is for the soc it is being build. > > That was my thought... what do you think? Wh

Re: [U-Boot] [PATCH v3 07/10] usb: mxs: Adapt code for i.MX23 support

2013-02-17 Thread Otavio Salvador
On Sun, Feb 17, 2013 at 5:11 PM, Fabio Estevam wrote: > On Sun, Feb 17, 2013 at 5:07 PM, Otavio Salvador > wrote: > >> I did it but mxs gives the impression it does mostly the same in both >> socs; as the code is mostly different between both I choose soc so it >> is clear it is for the soc it is

Re: [U-Boot] [PATCH v3 07/10] usb: mxs: Adapt code for i.MX23 support

2013-02-17 Thread Marek Vasut
Dear Otavio Salvador, > The i.MX23 just one USB port so we shouldn't mess up with PLL1CTRL and > USB1 port when building for i.MX23. > > Signed-off-by: Otavio Salvador > --- > Changes in v3: > - Improve commit log > - Move code to enable/disable clock to soc_ehci_hcd_{enable,disable}_clock > - P