Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB PHY is active

2017-09-20 Thread Stefano Babic
On 13/09/2017 23:29, Stefan Agner wrote: > From: Stefan Agner > > This macro allows to detect whether the USB PHY is active. This > is helpful to detect if the boot ROM has previously started the > USB serial downloader. > > The idea is taken from the mfgtool support

Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB PHY is active

2017-09-14 Thread Stefan Agner
On 2017-09-13 22:23, Eric Nelson wrote: > On 09/13/2017 02:29 PM, Stefan Agner wrote: >> From: Stefan Agner >> >> This macro allows to detect whether the USB PHY is active. This >> is helpful to detect if the boot ROM has previously started the >> USB serial downloader.

Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB PHY is active

2017-09-13 Thread Eric Nelson
On 09/13/2017 02:29 PM, Stefan Agner wrote: From: Stefan Agner This macro allows to detect whether the USB PHY is active. This is helpful to detect if the boot ROM has previously started the USB serial downloader. The idea is taken from the mfgtool support in the NXP

Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB PHY is active

2017-09-13 Thread Stefan Agner
Sorry, the subject should have been v4. -- Stefan On 2017-09-13 14:29, Stefan Agner wrote: > From: Stefan Agner > > This macro allows to detect whether the USB PHY is active. This > is helpful to detect if the boot ROM has previously started the > USB serial

[U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB PHY is active

2017-09-13 Thread Stefan Agner
From: Stefan Agner This macro allows to detect whether the USB PHY is active. This is helpful to detect if the boot ROM has previously started the USB serial downloader. The idea is taken from the mfgtool support in the NXP U-Boot:

Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB PHY is active

2017-09-13 Thread Eric Nelson
Hi Stefan, On 09/13/2017 12:47 PM, Stefan Agner wrote: On 2017-09-13 02:19, Stefano Babic wrote: Hi Eric, Stefan, On 13/09/2017 02:30, Eric Nelson wrote: Hi Stefan, I hate to be fussy about this, but I don't think I saw a reply to my earlier comment about the term "USB PHY".

Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB PHY is active

2017-09-13 Thread Fabio Estevam
On Wed, Sep 13, 2017 at 4:47 PM, Stefan Agner wrote: > The USB serial downloader only works with the OTG USB PHY anyway, so I > will rename it. I like to have USB still in there, how about: > > is_usbotg_phy_active() Looks fine. Please send a v4 with it and we should be good

Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB PHY is active

2017-09-13 Thread Stefano Babic
Hi Eric, Stefan, On 13/09/2017 02:30, Eric Nelson wrote: > Hi Stefan, > > I hate to be fussy about this, but I don't think I saw a reply > to my earlier comment about the term "USB PHY". > > https://lists.denx.de/pipermail/u-boot/2017-September/305123.html > > Since i.MX6 SoCs have USB

Re: [U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB PHY is active

2017-09-12 Thread Eric Nelson
Hi Stefan, I hate to be fussy about this, but I don't think I saw a reply to my earlier comment about the term "USB PHY". https://lists.denx.de/pipermail/u-boot/2017-September/305123.html Since i.MX6 SoCs have USB **Host** Phy's as well as the USB OTG Phy, this patch is a bit misleading.

[U-Boot] [PATCH v3 1/2] imx: add macro to detect whether USB PHY is active

2017-09-12 Thread Stefan Agner
From: Stefan Agner This macro allows to detect whether the USB PHY is active. This is helpful to detect if the boot ROM has previously started the USB serial downloader. The idea is taken from the mfgtool support in the NXP U-Boot: