Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-02-02 Thread Jagan Teki
On Fri, Feb 1, 2019 at 10:38 PM Vignesh R wrote: > > [...] > >>> Yes, zynq qspi ia unable to handle larger than 16MiB flashes so we used > >>> BAR to access those. > >>> > >> > >> I wonder how those boards work in kernel that does not support BAR. > >> Anyways, if you provide a list of SPI control

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-02-01 Thread Vignesh R
[...] >>> Yes, zynq qspi ia unable to handle larger than 16MiB flashes so we used >>> BAR to access those. >>> >> >> I wonder how those boards work in kernel that does not support BAR. >> Anyways, if you provide a list of SPI controllers on zynq SoCs, I will >> add an imply SPI_FLASH_BAR for such

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-02-01 Thread Jagan Teki
On Thu, Jan 31, 2019 at 11:04 PM Vignesh R wrote: > > > > On 31/01/19 7:20 PM, Jagan Teki wrote: > > On Thu, 31 Jan, 2019, 7:16 PM Vignesh R > wrote: > > > > On 31/01/19 7:06 PM, Jagan Teki wrote: > > [...] > > > >> configs/xilinx_zynqmp_mini_qspi_defconf

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-31 Thread Vignesh R
On 31/01/19 7:20 PM, Jagan Teki wrote: > On Thu, 31 Jan, 2019, 7:16 PM Vignesh R wrote: > > On 31/01/19 7:06 PM, Jagan Teki wrote: > [...] > >     >>  configs/xilinx_zynqmp_mini_qspi_defconfig        | 1 - > >     >>  configs/xilinx_zynqmp_zc1232_revA_de

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-31 Thread Jagan Teki
On Thu, 31 Jan, 2019, 7:16 PM Vignesh R On 31/01/19 7:06 PM, Jagan Teki wrote: > [...] > > >> configs/xilinx_zynqmp_mini_qspi_defconfig| 1 - > > >> configs/xilinx_zynqmp_zc1232_revA_defconfig | 1 - > > >> configs/xilinx_zynqmp_zc1254_revA_defconfig | 1 - > > >>

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-31 Thread Vignesh R
On 31/01/19 7:06 PM, Jagan Teki wrote: [...] > >>  configs/xilinx_zynqmp_mini_qspi_defconfig        | 1 - > >>  configs/xilinx_zynqmp_zc1232_revA_defconfig      | 1 - > >>  configs/xilinx_zynqmp_zc1254_revA_defconfig      | 1 - > >>  configs/xilinx_zynqmp_zc1275_revA_defconfig     

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-31 Thread Jagan Teki
On Thu, 31 Jan, 2019, 7:02 PM Vignesh R > > On 31/01/19 6:48 PM, Jagan Teki wrote: > > On Tue, Jan 29, 2019 at 11:28 AM Vignesh R wrote: > >> > >> Now that new SPI NOR layer uses stateless 4 byte opcodes by default, > >> don't enable SPI_FLASH_BAR. For SPI controllers that cannot support > >> 4-b

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-31 Thread Vignesh R
On 31/01/19 6:48 PM, Jagan Teki wrote: > On Tue, Jan 29, 2019 at 11:28 AM Vignesh R wrote: >> >> Now that new SPI NOR layer uses stateless 4 byte opcodes by default, >> don't enable SPI_FLASH_BAR. For SPI controllers that cannot support >> 4-byte addressing, (stm32_qspi.c, fsl_qspi.c, mtk_qspi.c

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-31 Thread Jagan Teki
On Tue, Jan 29, 2019 at 11:28 AM Vignesh R wrote: > > Now that new SPI NOR layer uses stateless 4 byte opcodes by default, > don't enable SPI_FLASH_BAR. For SPI controllers that cannot support > 4-byte addressing, (stm32_qspi.c, fsl_qspi.c, mtk_qspi.c, ich.c, > renesas_rpc_spi.c) add an imply clau

[U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-28 Thread Vignesh R
Now that new SPI NOR layer uses stateless 4 byte opcodes by default, don't enable SPI_FLASH_BAR. For SPI controllers that cannot support 4-byte addressing, (stm32_qspi.c, fsl_qspi.c, mtk_qspi.c, ich.c, renesas_rpc_spi.c) add an imply clause to enable SPI_FLASH_BAR so as to not break functionality.