Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-09-09 Thread Sherry Sun
Hi Jean, > > Hi Sherry, > > On 03/09/2019 14:44, Sherry Sun wrote: > > Hi Jean, > > > >> > >> On 02/09/2019 13:29, Sherry Sun wrote: > >>> Hi Vignesh, > >>> > Hi Sherry, > > [...] > >> AFAIK, U-Boot does not support runtime switching of USB port to > >> host from device

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-09-09 Thread Jean-Jacques Hiblot
Hi Sherry, On 03/09/2019 14:44, Sherry Sun wrote: Hi Jean, On 02/09/2019 13:29, Sherry Sun wrote: Hi Vignesh, Hi Sherry, [...] AFAIK, U-Boot does not support runtime switching of USB port to host from device and vice versa. This is the case for existing driver like DWC3/MUSB etc.

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-09-03 Thread Sherry Sun
Hi Jean, > > > On 02/09/2019 13:29, Sherry Sun wrote: > > Hi Vignesh, > > > >> Hi Sherry, > >> > >> [...] > AFAIK, U-Boot does not support runtime switching of USB port to > host from device and vice versa. This is the case for existing > driver like > >> DWC3/MUSB etc. >

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-09-03 Thread Jean-Jacques Hiblot
On 02/09/2019 13:29, Sherry Sun wrote: Hi Vignesh, Hi Sherry, [...] AFAIK, U-Boot does not support runtime switching of USB port to host from device and vice versa. This is the case for existing driver like DWC3/MUSB etc. Ideally we would need a role switch driver that unbinds and rebinds

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-09-02 Thread Sherry Sun
Hi Vignesh, > > Hi Sherry, > > [...] > >> AFAIK, U-Boot does not support runtime switching of USB port to host > >> from device and vice versa. This is the case for existing driver like > DWC3/MUSB etc. > >> > >> Ideally we would need a role switch driver that unbinds and rebinds > >> host vs

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-09-02 Thread Vignesh Raghavendra
Hi Sherry, [...] >> AFAIK, U-Boot does not support runtime switching of USB port to host from >> device and vice versa. This is the case for existing driver like DWC3/MUSB >> etc. >> >> Ideally we would need a role switch driver that unbinds and rebinds host vs >> device driver as when required

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-30 Thread Sherry Sun
Hi Vignesh, > > > > On 30/08/19 3:36 PM, Sherry Sun wrote: > > Hi Jean, > > > >> > >> > >> On 28/08/2019 13:50, Sherry Sun wrote: > >>> Hi Jean, > >>> > Hi Jean, > > > Hi Marek, Sherry, > > > > > > we keep the cdns3 node for usb gadget driver, then add a usb >

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-30 Thread Vignesh Raghavendra
On 30/08/19 3:36 PM, Sherry Sun wrote: > Hi Jean, > >> >> >> On 28/08/2019 13:50, Sherry Sun wrote: >>> Hi Jean, >>> Hi Jean, > Hi Marek, Sherry, > > > we keep the cdns3 node for usb gadget driver, then add a usb > host node for > xhci-imx8 driver

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-30 Thread Sherry Sun
Hi Jean, > > > On 28/08/2019 13:50, Sherry Sun wrote: > > Hi Jean, > > > >> Hi Jean, > >> > >>> Hi Marek, Sherry, > >>> > >>> > >>> we keep the cdns3 node for usb gadget driver, then add a usb > >>> host node for > >>> xhci-imx8 driver in *-uboot.dtsi. so here is no need to change >

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-30 Thread Jean-Jacques Hiblot
On 28/08/2019 13:50, Sherry Sun wrote: Hi Jean, Hi Jean, Hi Marek, Sherry, we keep the cdns3 node for usb gadget driver, then add a usb host node for xhci-imx8 driver in *-uboot.dtsi. so here is no need to change the host driver compatible. But the compatible in gadget driver should be

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-28 Thread Sherry Sun
Hi Jean, > > Hi Jean, > > > > > Hi Marek, Sherry, > > > > > > we keep the cdns3 node for usb gadget driver, then add a usb host > > node for > > xhci-imx8 driver in *-uboot.dtsi. so here is no need to change > > the host driver > > >>> compatible. > > But the compatible

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-28 Thread Sherry Sun
Hi Jean, > > Hi Marek, Sherry, > > > we keep the cdns3 node for usb gadget driver, then add a usb host > node for > xhci-imx8 driver in *-uboot.dtsi. so here is no need to change the > host driver > >>> compatible. > But the compatible in gadget driver should be changed

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-27 Thread Jean-Jacques Hiblot
Hi Marek, Sherry, we keep the cdns3 node for usb gadget driver, then add a usb host node for xhci-imx8 driver in *-uboot.dtsi. so here is no need to change the host driver compatible. But the compatible in gadget driver should be changed later. We should try avoiding ABI breaks in DT. But

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Sherry Sun
Hi Marek, > > On 8/20/19 5:42 PM, Sherry Sun wrote: > [...] > > >>> +U_BOOT_DRIVER(xhci_imx8) = { > >>> + .name = "xhci_imx8", > >>> + .id = UCLASS_USB, > >>> + .of_match = xhci_usb_ids, > >>> + .probe = xhci_imx8_probe, > >>> + .remove =

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Marek Vasut
On 8/20/19 5:42 PM, Sherry Sun wrote: [...] >>> +U_BOOT_DRIVER(xhci_imx8) = { >>> + .name = "xhci_imx8", >>> + .id = UCLASS_USB, >>> + .of_match = xhci_usb_ids, >>> + .probe = xhci_imx8_probe, >>> + .remove = xhci_imx8_remove, >>> +

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Sherry Sun
Hi Marek, > > On 8/20/19 5:24 PM, Sherry Sun wrote: > > Hi Marek, > > Hi, > > >> On 8/20/19 10:31 AM, Sherry Sun wrote: > >>> Hi Marek, > >>> > > On 8/19/19 8:10 AM, Sherry Sun wrote: > > Add the USB3 host driver for NXP imx8 platform, and the cadence IP > > is in it. The

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Marek Vasut
On 8/20/19 5:24 PM, Sherry Sun wrote: > Hi Marek, Hi, >> On 8/20/19 10:31 AM, Sherry Sun wrote: >>> Hi Marek, >>> On 8/19/19 8:10 AM, Sherry Sun wrote: > Add the USB3 host driver for NXP imx8 platform, and the cadence IP > is in it. The USB3 host driver support DM mode, it will

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Sherry Sun
Hi Marek, > > On 8/20/19 10:31 AM, Sherry Sun wrote: > > Hi Marek, > > > >> > >> On 8/19/19 8:10 AM, Sherry Sun wrote: > >>> Add the USB3 host driver for NXP imx8 platform, and the cadence IP > >>> is in it. The USB3 host driver support DM mode, it will probe USB3 > >>> host node in dts. > >>> >

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Marek Vasut
On 8/20/19 10:31 AM, Sherry Sun wrote: > Hi Marek, > >> >> On 8/19/19 8:10 AM, Sherry Sun wrote: >>> Add the USB3 host driver for NXP imx8 platform, and the cadence IP is >>> in it. The USB3 host driver support DM mode, it will probe USB3 host >>> node in dts. >>> >>> Signed-off-by: Sherry Sun

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Sherry Sun
Hi Marek, > > On 8/19/19 8:10 AM, Sherry Sun wrote: > > Add the USB3 host driver for NXP imx8 platform, and the cadence IP is > > in it. The USB3 host driver support DM mode, it will probe USB3 host > > node in dts. > > > > Signed-off-by: Sherry Sun > > [...] > > > +static void

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-19 Thread Marek Vasut
On 8/19/19 8:10 AM, Sherry Sun wrote: > Add the USB3 host driver for NXP imx8 platform, and the > cadence IP is in it. The USB3 host driver support DM > mode, it will probe USB3 host node in dts. > > Signed-off-by: Sherry Sun [...] > +static void xhci_imx8_get_reg_addr(struct udevice *dev) >

[U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-19 Thread Sherry Sun
Add the USB3 host driver for NXP imx8 platform, and the cadence IP is in it. The USB3 host driver support DM mode, it will probe USB3 host node in dts. Signed-off-by: Sherry Sun --- drivers/usb/host/Kconfig | 9 ++ drivers/usb/host/Makefile| 1 + drivers/usb/host/xhci-imx8.c | 209