Re: [U-Boot] [PATCH v5 1/3] common: Move bootm_decomp_image() to image.c (as image_decomp())

> OK, this now causes 'make tests' to fail on the FIT image tests, please > look. Thanks! Whoops, sorry, should have run that again. This was just a printf() without a newline at the end, apparently pytest really doesn't like that. (I took out the "OK" at the end of the "Loading kernel..."

Re: [U-Boot] [PATCH v5 1/3] common: Move bootm_decomp_image() to image.c (as image_decomp())

On Thu, Jul 11, 2019 at 01:53:18PM -0700, Julius Werner wrote: > Upcoming patches want to add decompression to use cases that are no > longer directly related to booting. It makes sense to retain a single > decompression routine, but it should no longer be in bootm.c (which is > not compiled for

Re: [U-Boot] [PATCH v5 1/3] common: Move bootm_decomp_image() to image.c (as image_decomp())

> I'd like to review this, but maybe you can help me speed up the process and > tell > us if the move has been a 1:1 code move or if you had to adapt things to the > new > location (other than the function being renamed)? print_decomp_msg() is a 1:1 move. bootm_decomp_image() is mostly 1:1

Re: [U-Boot] [PATCH v5 1/3] common: Move bootm_decomp_image() to image.c (as image_decomp())

On Thu, Jul 11, 2019 at 10:53 PM Julius Werner wrote: > > Upcoming patches want to add decompression to use cases that are no > longer directly related to booting. It makes sense to retain a single > decompression routine, but it should no longer be in bootm.c (which is > not compiled for all

[U-Boot] [PATCH v5 1/3] common: Move bootm_decomp_image() to image.c (as image_decomp())

Upcoming patches want to add decompression to use cases that are no longer directly related to booting. It makes sense to retain a single decompression routine, but it should no longer be in bootm.c (which is not compiled for all configurations). This patch moves bootm_decomp_image() to image.c