Re: [U-Boot] [RFC PATCH] rockchip: tinker: Add automatic board discovery

2019-11-18 Thread Michael Nazzareno Trimarchi
Hi Kever On Tue, Nov 19, 2019 at 1:40 AM Kever Yang wrote: > > > On 2019/11/17 下午6:17, Michael Trimarchi wrote: > > Add a way to detect board id and pcb id. > > > Is there a document for this from vendor? Are they also use these two ids? > > If we can detect tinker vs tinker-s, then we don't need

Re: [U-Boot] [RFC PATCH] rockchip: tinker: Add automatic board discovery

2019-11-18 Thread Kever Yang
On 2019/11/17 下午6:17, Michael Trimarchi wrote: Add a way to detect board id and pcb id. Is there a document for this from vendor? Are they also use these two ids? If we can detect tinker vs tinker-s, then we don't need two board config/dts, right? Signed-off-by: Michael Trimarchi ---

Re: [U-Boot] [RFC PATCH] rockchip: tinker: Add automatic board discovery

2019-11-18 Thread Michael Trimarchi
Hi On Mon, Nov 18, 2019 at 04:55:02PM +0530, Jagan Teki wrote: > On Sun, Nov 17, 2019 at 3:47 PM Michael Trimarchi > wrote: > > > > Add a way to detect board id and pcb id. > > > > Signed-off-by: Michael Trimarchi > > --- > > arch/arm/dts/rk3288-tinker.dtsi | 33 > > board

Re: [U-Boot] [RFC PATCH] rockchip: tinker: Add automatic board discovery

2019-11-18 Thread Michael Nazzareno Trimarchi
Hi On Mon, Nov 18, 2019 at 12:25 PM Jagan Teki wrote: > > On Sun, Nov 17, 2019 at 3:47 PM Michael Trimarchi > wrote: > > > > Add a way to detect board id and pcb id. > > > > Signed-off-by: Michael Trimarchi > > --- > > arch/arm/dts/rk3288-tinker.dtsi | 33 > > board/rockc

Re: [U-Boot] [RFC PATCH] rockchip: tinker: Add automatic board discovery

2019-11-18 Thread Jagan Teki
On Sun, Nov 17, 2019 at 3:47 PM Michael Trimarchi wrote: > > Add a way to detect board id and pcb id. > > Signed-off-by: Michael Trimarchi > --- > arch/arm/dts/rk3288-tinker.dtsi | 33 > board/rockchip/tinker_rk3288/tinker-rk3288.c | 83 > 2 files chang

[U-Boot] [RFC PATCH] rockchip: tinker: Add automatic board discovery

2019-11-17 Thread Michael Trimarchi
Add a way to detect board id and pcb id. Signed-off-by: Michael Trimarchi --- arch/arm/dts/rk3288-tinker.dtsi | 33 board/rockchip/tinker_rk3288/tinker-rk3288.c | 83 2 files changed, 116 insertions(+) diff --git a/arch/arm/dts/rk3288-tinker.dtsi b/arc