Re: [U-Boot] ls1021atwr reset issue (was [ANN] U-Boot v2015.10-rc4 released)

2015-10-01 Thread Sinan Akman
On 01/10/15 03:38 PM, Fabio Estevam wrote: On Thu, Oct 1, 2015 at 4:33 PM, Sinan Akman wrote: Otavio, please note that the watchdog changes that are committed that we are referring to broke ls102x. So if you revert those as you suggest here you would have ls102x working again but it would

Re: [U-Boot] ls1021atwr reset issue (was [ANN] U-Boot v2015.10-rc4 released)

2015-10-01 Thread Fabio Estevam
On Thu, Oct 1, 2015 at 4:33 PM, Sinan Akman wrote: > Otavio, please note that the watchdog changes that are committed that we > are referring > to broke ls102x. So if you revert those as you suggest here you would have > ls102x working > again but it would break imx6 which the commit was for.

Re: [U-Boot] ls1021atwr reset issue (was [ANN] U-Boot v2015.10-rc4 released)

2015-10-01 Thread Fabio Estevam
On Thu, Oct 1, 2015 at 4:28 PM, Sinan Akman wrote: > I agree, this is something needs to be done in steps and not in rush. > For coming out of rc4 and making sure ls1021atwr reset works, all > we need is to make sure that SRS bit is set and that this bit is written > properly with big endian.

Re: [U-Boot] ls1021atwr reset issue (was [ANN] U-Boot v2015.10-rc4 released)

2015-10-01 Thread Sinan Akman
On 01/10/15 03:17 PM, Otavio Salvador wrote: On Thu, Oct 1, 2015 at 4:14 PM, Tom Rini wrote: On Thu, Oct 01, 2015 at 04:09:46PM -0300, Fabio Estevam wrote: On Thu, Oct 1, 2015 at 12:19 PM, Sinan Akman wrote: I took a further look at this. I believe this won't work as readw will now retu

Re: [U-Boot] ls1021atwr reset issue (was [ANN] U-Boot v2015.10-rc4 released)

2015-10-01 Thread Sinan Akman
On 01/10/15 03:14 PM, Tom Rini wrote: On Thu, Oct 01, 2015 at 04:09:46PM -0300, Fabio Estevam wrote: On Thu, Oct 1, 2015 at 12:19 PM, Sinan Akman wrote: I took a further look at this. I believe this won't work as readw will now return the data in the wrong endianness. I think Wolfgang als

Re: [U-Boot] ls1021atwr reset issue (was [ANN] U-Boot v2015.10-rc4 released)

2015-10-01 Thread Otavio Salvador
On Thu, Oct 1, 2015 at 4:14 PM, Tom Rini wrote: > On Thu, Oct 01, 2015 at 04:09:46PM -0300, Fabio Estevam wrote: >> On Thu, Oct 1, 2015 at 12:19 PM, Sinan Akman wrote: >> > I took a further look at this. I believe this won't work as readw >> > will now return the data in the wrong endianness. I

Re: [U-Boot] ls1021atwr reset issue (was [ANN] U-Boot v2015.10-rc4 released)

2015-10-01 Thread Tom Rini
On Thu, Oct 01, 2015 at 04:09:46PM -0300, Fabio Estevam wrote: > On Thu, Oct 1, 2015 at 12:19 PM, Sinan Akman wrote: > > I took a further look at this. I believe this won't work as readw > > will now return the data in the wrong endianness. I think Wolfgang > > also already pointed out at this.

Re: [U-Boot] ls1021atwr reset issue (was [ANN] U-Boot v2015.10-rc4 released)

2015-10-01 Thread Fabio Estevam
On Thu, Oct 1, 2015 at 12:19 PM, Sinan Akman wrote: > I took a further look at this. I believe this won't work as readw > will now return the data in the wrong endianness. I think Wolfgang > also already pointed out at this. We would need to use the macro with > correct endianness for different

Re: [U-Boot] ls1021atwr reset issue (was [ANN] U-Boot v2015.10-rc4 released)

2015-10-01 Thread Sinan Akman
Hi Fabio On 30/09/15 03:03 PM, Fabio Estevam wrote: [...] Ok, the issue is due to endianness: on LS1021 the watchdog is big-endian, so that's why we can't use clrsetbits_le16(). Please check: http://git.freescale.com/git/cgit.cgi/layerscape/ls1021a/linux.git/commit/?id=b53a344d20f6ffdc383d99