Re: [PATCH V3] ARM: dts: stm32: Add KS8851-16MLL ethernet on FMC2

2020-04-14 Thread Marek Vasut
On 4/14/20 2:16 PM, Christophe Kerello wrote: > > > On 4/14/20 1:56 PM, Marek Vasut wrote: >> On 4/14/20 9:23 AM, Christophe Kerello wrote: >>> >>> >>> On 4/10/20 8:11 PM, Marek Vasut wrote: On 4/9/20 7:38 PM, Patrick DELAUNAY wrote: Hi, [...] >> That looks like a

Re: [PATCH V3] ARM: dts: stm32: Add KS8851-16MLL ethernet on FMC2

2020-04-14 Thread Christophe Kerello
On 4/14/20 1:56 PM, Marek Vasut wrote: On 4/14/20 9:23 AM, Christophe Kerello wrote: On 4/10/20 8:11 PM, Marek Vasut wrote: On 4/9/20 7:38 PM, Patrick DELAUNAY wrote: Hi, [...] That looks like a hack, it would collide with the actual FMC2 driver and it seems the FMC2 DT compatible

Re: [PATCH V3] ARM: dts: stm32: Add KS8851-16MLL ethernet on FMC2

2020-04-14 Thread Marek Vasut
On 4/14/20 9:23 AM, Christophe Kerello wrote: > > > On 4/10/20 8:11 PM, Marek Vasut wrote: >> On 4/9/20 7:38 PM, Patrick DELAUNAY wrote: >> Hi, >> >> [...] >> That looks like a hack, it would collide with the actual FMC2 driver and it seems the FMC2 DT compatible string is not

Re: [PATCH V3] ARM: dts: stm32: Add KS8851-16MLL ethernet on FMC2

2020-04-14 Thread Christophe Kerello
On 4/10/20 8:11 PM, Marek Vasut wrote: On 4/9/20 7:38 PM, Patrick DELAUNAY wrote: Hi, [...] That looks like a hack, it would collide with the actual FMC2 driver and it seems the FMC2 DT compatible string is not even stable yet (cfr the Linux patches). So I am reluctant to do anything

Re: [PATCH V3] ARM: dts: stm32: Add KS8851-16MLL ethernet on FMC2

2020-04-10 Thread Marek Vasut
On 4/9/20 7:38 PM, Patrick DELAUNAY wrote: Hi, [...] >> That looks like a hack, it would collide with the actual FMC2 driver and it >> seems >> the FMC2 DT compatible string is not even stable yet (cfr the Linux >> patches). So I >> am reluctant to do anything like depending on the FMC DT

RE: [PATCH V3] ARM: dts: stm32: Add KS8851-16MLL ethernet on FMC2

2020-04-09 Thread Patrick DELAUNAY
Dear Marek, > From: Marek Vasut > Sent: jeudi 9 avril 2020 13:27 > > On 4/1/20 3:30 PM, Patrick DELAUNAY wrote: > > Hi Marek, > > Hi, > > [...] > > >> + { > >> + /* These should bound to FMC2 bus driver, but we do not have one */ > > > > As temporarily solution (waiting final solution and

Re: [PATCH V3] ARM: dts: stm32: Add KS8851-16MLL ethernet on FMC2

2020-04-09 Thread Marek Vasut
On 4/1/20 3:30 PM, Patrick DELAUNAY wrote: > Hi Marek, Hi, [...] >> + { >> +/* These should bound to FMC2 bus driver, but we do not have one */ > > As temporarily solution (waiting final solution and real FMC2 bus driver) > can you define a NO_OP in board device associated to existing

RE: [PATCH V3] ARM: dts: stm32: Add KS8851-16MLL ethernet on FMC2

2020-04-01 Thread Patrick DELAUNAY
Hi Marek, > From: Marek Vasut > Sent: jeudi 26 mars 2020 16:58 > > Add DT entries, Kconfig entries and board-specific entries to configure > FMC2 bus and make KS8851-16MLL on that bus accessible to U-Boot. > > Signed-off-by: Marek Vasut > Cc: Patrick Delaunay > Cc: Patrice Chotard > --- >

Re: [PATCH V3] ARM: dts: stm32: Add KS8851-16MLL ethernet on FMC2

2020-03-27 Thread Marek Vasut
On 3/27/20 9:55 AM, Patrice CHOTARD wrote: > Hi Marek Hi, [...] >> diff --git a/board/dhelectronics/dh_stm32mp1/board.c >> b/board/dhelectronics/dh_stm32mp1/board.c >> index b663696983..be55242799 100644 >> --- a/board/dhelectronics/dh_stm32mp1/board.c >> +++

Re: [PATCH V3] ARM: dts: stm32: Add KS8851-16MLL ethernet on FMC2

2020-03-27 Thread Patrice CHOTARD
Hi Marek You have forgotten to take into account some of my previous remarks on V2 On 3/26/20 4:58 PM, Marek Vasut wrote: > Add DT entries, Kconfig entries and board-specific entries to configure > FMC2 bus and make KS8851-16MLL on that bus accessible to U-Boot. > > Signed-off-by: Marek Vasut >