Re: atmel_sdhci: SDMMC_CD pin still needed for card detection despite EMMC set to non-removable

2023-05-15 Thread Eugen Hristev
Hi Zixun, I cannot apply your patch, there is some error. can you use git send-email yourfile.patch --to u-boot@lists.denx.de --to eugen.hris...@collabora.com such that I can grab it from patchwork ? Thanks, Eugen On 5/4/23 17:59, Zixun Li wrote: Can't we do this in a different place? W

RE: atmel_sdhci: SDMMC_CD pin still needed for card detection despite EMMC set to non-removable

2023-05-04 Thread Zixun Li
> Can't we do this in a different place? > When we parse the DT for example. If the card is non-removable, this is > described as a property in the DT. > In this way you don't have to recreate all the below code from the common > sdhci_get_cd, and you avoid rewriting the MC1R every time the get_

Re: atmel_sdhci: SDMMC_CD pin still needed for card detection despite EMMC set to non-removable

2023-05-04 Thread Eugen Hristev
On 5/1/23 15:21, Zixun Li wrote: Hi, Can you find some place to set this bit in the atmel sdhci driver, and not in the core? The MC1R register is specific to at91 device. I've overridden get_cd of the driver, below is the patch: From e186af71297e9ae6ce241a85bff64683949f0e1b Mon Sep 17 00:0

RE: atmel_sdhci: SDMMC_CD pin still needed for card detection despite EMMC set to non-removable

2023-05-01 Thread Zixun Li
Hi, > Can you find some place to set this bit in the atmel sdhci driver, and not in > the core? > The MC1R register is specific to at91 device. I've overridden get_cd of the driver, below is the patch: From e186af71297e9ae6ce241a85bff64683949f0e1b Mon Sep 17 00:00:00 2001 From: Zixun LI Date:

Re: atmel_sdhci: SDMMC_CD pin still needed for card detection despite EMMC set to non-removable

2023-04-28 Thread Eugen Hristev
Hi Zixun Li, On 4/27/23 22:51, Zixun Li wrote: Hardware: SAMA5D27 customized board, EMMC connected to SDMMC0. SDMMC0_CD pin pulled-down for BootROM card detection, once booted it used as LED output. Software: u-boot-at91 76f7f55 Issue: U-Boot can't detect EMMC despite it set to non-removable