[U-Boot] [PATCH] rockchip: rk3288: Add support for drive-strength in PINCTRL

. This commit adds support for handling drive-strength of 12ma, when it's defined in the DT. Signed-off-by: Romain Perier <romain.per...@collabora.com> --- drivers/pinctrl/rockchip/pinctrl_rk3288.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/ro

[U-Boot] [PATCH 2/2] rockchip: rk3288: Revert MAC_TXCLK in pinctrl for GMAC

L). Fixes: 2454b719fb87 ("rockchip: rk3288: Add pinctrl support for the...") Signed-off-by: Romain Perier <romain.per...@collabora.com> --- drivers/pinctrl/rockchip/pinctrl_rk3288.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3288.c

[U-Boot] [PATCH 1/2] rockchip: rk3288: Remove phy reset GPIO pull up

We should not handle this pin explicitly from pinctrl. GMAC driver takes care of it by using a "reset-gpio" in the DT. This commit removes pull up for GPIO4B0. Fixes: 2454b719fb87 ("rockchip: rk3288: Add pinctrl support for the...") Signed-off-by: Romain Perier <roma

[U-Boot] [PATCH 0/2] rockchip: rk3288: Fixes for GMAC

X_TCLK pin that was accidentaly removed while re-working commit 2454b719fb87 ("rockchip: rk3288: Add pinctrl support for the..."). Romain Perier (2): rockchip: rk3288: Remove phy reset GPIO pull up rockchip: rk3288: Revert MAC_TXCLK in pinctrl for GMAC drivers/pinctrl/rockchip/pinctrl_rk3288.c

Re: [U-Boot] [PATCH] net: gmac_rockchip: Add support for pinctrl

Hello, Le 11/07/2017 à 15:43, Dr. Philipp Tomsich a écrit : >> On 10 Jul 2017, at 08:43, Romain Perier <romain.per...@collabora.com> wrote: >> >> Le 07/07/2017 à 05:58, Simon Glass a écrit : >>> +Philipp >>> >>> Hi Romain, >>

Re: [U-Boot] [PATCH] net: gmac_rockchip: Add support for pinctrl

Le 07/07/2017 à 05:58, Simon Glass a écrit : > +Philipp > > Hi Romain, > > On 3 July 2017 at 01:13, Romain Perier <romain.per...@collabora.com> wrote: >> Currently, selecting state simple is done by the device driver model, >> prior probing the driver. The pro

[U-Boot] [PATCH] net: gmac_rockchip: Add support for pinctrl

and then gmac_config is never called. This commits toggles the pinctrl on the right node from the probe function of the driver. Signed-off-by: Romain Perier <romain.per...@collabora.com> --- drivers/net/gmac_rockchip.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/gma

[U-Boot] [PATCH v2] rockchip: rk3288: Add pinctrl support for the gmac ethernet interface

Simons <sjoerd.sim...@collabora.co.uk> Signed-off-by: Romain Perier <romain.per...@collabora.com> --- Note: The patch has not been merged during the integration of the GMAC driver. It fixes the ethernet 1gbs issue (caused by a drive length issue) Changes in v2: - Added Signed-off-by wit

[U-Boot] [PATCH] rockchip: rk3288: grf: Fix shift for RK3288_TXCLK_DLY_ENA_GMAC_ENABLE

-by: Romain Perier <romain.per...@collabora.com> --- arch/arm/include/asm/arch-rockchip/grf_rk3288.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/include/asm/arch-rockchip/grf_rk3288.h b/arch/arm/include/asm/arch-rockchip/grf_rk3288.h index 7d56b8ced0..fbc4a0d80f

Re: [U-Boot] rockchip: rk3288: Possible regression in sdram setup

Hi, That's what I already tried, but I can re-try differently (the delays were added at specific points, as suggested by Kever, if I remember correctly. I could try different approach) Thanks, Romain Le 26/01/2017 à 15:24, Simon Glass a écrit : > Hi, > > On 19 January 2017 at 02:5

Re: [U-Boot] [PATCH 1/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board

Hi, Le 21/01/2017 à 04:51, Simon Glass a écrit : > On 17 January 2017 at 02:32, Romain Perier <romain.per...@collabora.com> > wrote: >> Like the rock2, this board has been tested with back to brom feature. >> This commits adjusts environment offset regarding if ba

Re: [U-Boot] rockchip: rk3288: Possible regression in sdram setup

Hi, no ideas ? I can try another solution if you want. Regards, Romain Le 09/01/2017 à 09:23, Romain Perier a écrit : Hi, Le 09/01/2017 à 08:20, Kever Yang a écrit : On 01/06/2017 06:52 PM, Romain Perier wrote: Add Rockchip Engineers to Cc: Le 06/01/2017 à 11:28, Romain Perier

[U-Boot] [PATCH 2/2] rockchip: Enable ETH address randomization for the firefly-rk3288

This commit enables ethernet MAC address randomization on the firefly-rk3288. It removes the error at startup 'ethernet@ff29 address not set'. Signed-off-by: Romain Perier <romain.per...@collabora.com> --- configs/firefly-rk3288_defconfig | 1 + 1 file changed, 1 insertion(+) diff

[U-Boot] [PATCH 0/2] Update configs for the firefly-rk3288

This set of patches enables SPL_BACK_TO_BROM feature that has been tested on this board. That is preferable if all rk3288-based boards use the same configuration and boot in the same way. Then, it enables ethernet address randomization. Romain Perier (2): Enable ROCKCHIP_SPL_BACK_TO_BROM

[U-Boot] [PATCH 1/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board

Like the rock2, this board has been tested with back to brom feature. This commits adjusts environment offset regarding if back_to_brom is enabled or not and uses this feature by default. Signed-off-by: Romain Perier <romain.per...@collabora.com> --- configs/firefly-rk3288_defconf

[U-Boot] [PATCH v7 11/11] rockchip: Drop Ethernet from the TODO

From: Sjoerd Simons Now that ethernet support works, it can be dropped from the rockchip TODO Signed-off-by: Sjoerd Simons Acked-by: Simon Glass Acked-by: Joe Hershberger Signed-off-by:

[U-Boot] [PATCH v7 04/11] net: designware: Export the operation functions

From: Simon Glass <s...@chromium.org> Export all functions so that drivers can use them, or not, as the need arises. Signed-off-by: Simon Glass <s...@chromium.org> Signed-off-by: Romain Perier <romain.per...@collabora.com> Acked-by: Joe Hershberger <joe.hershber...@ni.co

[U-Boot] [PATCH v7 00/11] rockchip: Add gmac Ethernet support

d hook' patch - Sort includes - Use debug() instead of printf() for error - Use function calls instead of fix_mac_speed() hook - Use new clk interface Changes in v2: - Adjust to new hook name - Fix various coding style nits Romain Perier (2): Enable DISTRO_DEFAULTS for Rockchip platforms ro

[U-Boot] [PATCH v7 03/11] net: designware: Split the link init into a separate function

From: Simon Glass <s...@chromium.org> With rockchip we need to make adjustments after the link speed is set but before enabling received/transmit. In preparation for this, split these two pieces into separate functions. Signed-off-by: Simon Glass <s...@chromium.org> Signed-off-by: R

[U-Boot] [PATCH v7 07/11] rockchip: evb-rk3339: Enable DHCP

From: Simon Glass This is the only RK3399 device without DHCP. Enable it so that we can use a common BOOT_TARGET_DEVICES setting. It is likely useful to be able to use USB networking, at least. Full networking can be enabled when a suitable platform needs it. Signed-off-by:

[U-Boot] [PATCH v7 10/11] rockchip: Enable ETH address randomization for the rock2

This commit enables ethernet MAC address randomization on the rock2. It removes the error at startup 'ethernet@ff29 address not set'. Signed-off-by: Romain Perier <romain.per...@collabora.com> --- Changes in v7: - Added this commit to the series configs/rock2_defconfig | 1 +

[U-Boot] [PATCH v7 06/11] rockchip: Enable networking support on rock2 and firefly

From: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> Enable the various configuration option required to get the ethernet interface up and running on Radxa Rock2 and Firefly. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> Signed-off-by: Romain Perier <romain.per..

[U-Boot] [PATCH v7 08/11] Enable DISTRO_DEFAULTS for Rockchip platforms

This enables suitable commands needed for booting general purpose Linux distribution. This is required for example if we want to use PXE or DHCP as default boot targets, symbols no longer enabled by config_distro_defaults.h . Signed-off-by: Romain Perier <romain.per...@collabora.com> --- C

[U-Boot] [PATCH v7 02/11] net: designware: Adjust dw_adjust_link() to return an error

From: Simon Glass <s...@chromium.org> This function can fail, so return the error if there is one. Signed-off-by: Simon Glass <s...@chromium.org> Signed-off-by: Romain Perier <romain.per...@collabora.com> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes i

[U-Boot] [PATCH v7 09/11] rockchip: Add PXE and DHCP to the default boot targets

From: Sjoerd Simons Now that at least on the firefly board we have network support, enable PXE and DHCP boot targets by default. Signed-off-by: Sjoerd Simons Acked-by: Simon Glass Acked-by: Joe Hershberger

[U-Boot] [PATCH v7 05/11] net: gmac_rockchip: Add Rockchip GMAC driver

joerd.sim...@collabora.co.uk> Signed-off-by: Simon Glass <s...@chromium.org> Signed-off-by: Romain Perier <romain.per...@collabora.com> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v7: None Changes in v6: - Changed Acked-by to Signed-off-by for Romain Changes in v5: - Rena

[U-Boot] [PATCH v7 01/11] net: designware: Export various functions/struct to allow subclassing

From: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> To allow other DM drivers to subclass the designware driver various functions and structures need to be exported. Export these. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> Signed-off-by: Romain Perier

Re: [U-Boot] rockchip: rk3288: Possible regression in sdram setup

Hi, Le 09/01/2017 à 08:20, Kever Yang a écrit : On 01/06/2017 06:52 PM, Romain Perier wrote: Add Rockchip Engineers to Cc: Le 06/01/2017 à 11:28, Romain Perier a écrit : Hello, I have a strange behaviour with the SPL on rk3288. When I build u-boot-rockchip master for the rock2

Re: [U-Boot] rockchip: rk3288: Possible regression in sdram setup

Add Rockchip Engineers to Cc: Le 06/01/2017 à 11:28, Romain Perier a écrit : Hello, I have a strange behaviour with the SPL on rk3288. When I build u-boot-rockchip master for the rock2 (rock2_defconfig), I can easily start u-boot SPL and u-boot from an sdcard (the emmc boot partition

[U-Boot] rockchip: rk3288: Possible regression in sdram setup

Hello, I have a strange behaviour with the SPL on rk3288. When I build u-boot-rockchip master for the rock2 (rock2_defconfig), I can easily start u-boot SPL and u-boot from an sdcard (the emmc boot partition is erased so my board starts in maskrom mode by default) without any issues. Now,

[U-Boot] [PATCH v6 6/9] rockchip: Enable networking support on rock2 and firefly

From: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> Enable the various configuration option required to get the ethernet interface up and running on Radxa Rock2 and Firefly. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> Signed-off-by: Romain Perier <romain.per..

[U-Boot] [PATCH v6 8/9] rockchip: Add PXE and DHCP to the default boot targets

From: Sjoerd Simons Now that at least on the firefly board we have network support, enable PXE and DHCP boot targets by default. Signed-off-by: Sjoerd Simons Acked-by: Simon Glass Acked-by: Joe Hershberger

[U-Boot] [PATCH v6 9/9] rockchip: Drop Ethernet from the TODO

From: Sjoerd Simons Now that ethernet support works, it can be dropped from the rockchip TODO Signed-off-by: Sjoerd Simons Acked-by: Simon Glass Acked-by: Joe Hershberger Signed-off-by:

[U-Boot] [PATCH v6 4/9] net: designware: Export the operation functions

From: Simon Glass <s...@chromium.org> Export all functions so that drivers can use them, or not, as the need arises. Signed-off-by: Simon Glass <s...@chromium.org> Signed-off-by: Romain Perier <romain.per...@collabora.com> Acked-by: Joe Hershberger <joe.hershber...@ni.co

[U-Boot] [PATCH v6 5/9] net: gmac_rockchip: Add Rockchip GMAC driver

joerd.sim...@collabora.co.uk> Signed-off-by: Simon Glass <s...@chromium.org> Signed-off-by: Romain Perier <romain.per...@collabora.com> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Changes in v6: - Changed Acked-by to Signed-off-by for Romain Changes in v5: - Rename the driver to gmac_

[U-Boot] [PATCH v6 3/9] net: designware: Split the link init into a separate function

From: Simon Glass <s...@chromium.org> With rockchip we need to make adjustments after the link speed is set but before enabling received/transmit. In preparation for this, split these two pieces into separate functions. Signed-off-by: Simon Glass <s...@chromium.org> Signed-off-by: R

[U-Boot] [PATCH v6 2/9] net: designware: Adjust dw_adjust_link() to return an error

From: Simon Glass <s...@chromium.org> This function can fail, so return the error if there is one. Signed-off-by: Simon Glass <s...@chromium.org> Signed-off-by: Romain Perier <romain.per...@collabora.com> Acked-by: Joe Hershberger <joe.hershber...@ni.com> --- Change

[U-Boot] [PATCH v6 0/9] rockchip: Add gmac Ethernet support

>From Romain: This is a resent of Simon's v4 series. I have changed what was suggested by David Wu about the driver name (rename gmac_rk3288 to gmac_rockchip). I have also tested the whole series on a rock2 square board, updated the configuration files for rock2 and firefly boards and added some

[U-Boot] [PATCH v5 7/9] rockchip: evb-rk3339: Enable DHCP

From: Simon Glass This is the only RK3399 device without DHCP. Enable it so that we can use a common BOOT_TARGET_DEVICES setting. It is likely useful to be able to use USB networking, at least. Full networking can be enabled when a suitable platform needs it. Signed-off-by:

[U-Boot] [PATCH v5 0/9] rockchip: Add gmac Ethernet support

>From Simon: This v3 patch is an update on Sjoerd's original v2 series from Feburary. I have dealt with the changes requested at the time, and adjusted the way that the speed change is handled. Tested on firefly-rk3288, rock2. Original cover letter: To add support I've taken a slightly different

[U-Boot] [PATCH v6 1/9] net: designware: Export various functions/struct to allow subclassing

From: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> To allow other DM drivers to subclass the designware driver various functions and structures need to be exported. Export these. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> Signed-off-by: Romain Perier

[U-Boot] [PATCH v5 6/9] rockchip: Enable networking support on rock2 and firefly

> Acked-by: Joe Hershberger <joe.hershber...@ni.com> Acked-by: Romain Perier <romain.per...@collabora.com> --- Changes in v5: - Added Acked-by for Romain Changes in v4: None Changes in v3: None Changes in v2: None configs/firefly-rk3288_defconfig | 4 configs/rock2_defconfig

[U-Boot] [PATCH v5 4/9] net: designware: Export the operation functions

From: Simon Glass <s...@chromium.org> Export all functions so that drivers can use them, or not, as the need arises. Signed-off-by: Simon Glass <s...@chromium.org> Acked-by: Joe Hershberger <joe.hershber...@ni.com> Acked-by: Romain Perier <romain.per...@collabora.com> -

[U-Boot] [PATCH v5 9/9] rockchip: Drop Ethernet from the TODO

From: Sjoerd Simons Now that ethernet support works, it can be dropped from the rockchip TODO Signed-off-by: Sjoerd Simons Acked-by: Simon Glass Acked-by: Joe Hershberger Signed-off-by: