Re: [U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

2008-07-09 Thread Luigi 'Comio' Mantellini
On mer, 2008-07-09 at 09:25 -0400, Timur Tabi wrote: > On Jul 7, 2008, at 10:17 AM, Luigi 'Comio' Mantellini wrote: > > > --- > > drivers/i2c/fsl_i2c.c | 68 > > + > > 1 files changed, 68 insertions(+), 0 deletions(-) > > > > diff --git a/drivers

Re: [U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

2008-07-09 Thread Timur Tabi
On Jul 7, 2008, at 10:17 AM, Luigi 'Comio' Mantellini wrote: > --- > drivers/i2c/fsl_i2c.c | 68 > + > 1 files changed, 68 insertions(+), 0 deletions(-) > > diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c > index 0690340..8fd73c0 10064

Re: [U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

2008-07-09 Thread Timur Tabi
On Jul 7, 2008, at 2:02 PM, Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: >> >> I just extended the fsl_i2c.c driver that already uses a precomputed > > Yes, I know. I never understood what such a complicated driver for > sich a simple protocol was good for, especiall

Re: [U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

2008-07-07 Thread Luigi 'Comio' Mantellini
Il giorno lun, 07/07/2008 alle 20.02 +0200, Wolfgang Denk ha scritto: > In message <[EMAIL PROTECTED]> you wrote: > > > > I just extended the fsl_i2c.c driver that already uses a precomputed > > Yes, I know. I never understood what such a complicated driver for > sich a simple protocol was

Re: [U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

2008-07-07 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > I just extended the fsl_i2c.c driver that already uses a precomputed Yes, I know. I never understood what such a complicated driver for sich a simple protocol was good for, especially as we don't do multimegabytepersecond transfers over such

Re: [U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

2008-07-07 Thread Luigi 'Comio' Mantellini
On lun, 2008-07-07 at 16:59 +0200, Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: > > + > > What a nightmare of data and code. So many magic numbers, so much > potential for errors. And for what? Just for I2C support in U-Boot? > >From your PoV you are right. > Are you

Re: [U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

2008-07-07 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > --- > drivers/i2c/fsl_i2c.c | 68 > + > 1 files changed, 68 insertions(+), 0 deletions(-) > > diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c > index 0690340..8fd73c0 100644 > --- a/drivers/i

[U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

2008-07-07 Thread Luigi 'Comio' Mantellini
--- drivers/i2c/fsl_i2c.c | 68 + 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c index 0690340..8fd73c0 100644 --- a/drivers/i2c/fsl_i2c.c +++ b/drivers/i2c/fsl_i2c.c @@ -78,6 +78,73 @@

[U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

2008-07-07 Thread Luigi 'Comio' Mantellini
--- drivers/i2c/fsl_i2c.c | 68 + 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c index 0690340..8fd73c0 100644 --- a/drivers/i2c/fsl_i2c.c +++ b/drivers/i2c/fsl_i2c.c @@ -78,6 +78,73 @@

[U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

2008-07-07 Thread Luigi 'Comio' Mantellini
--- drivers/i2c/fsl_i2c.c | 68 + 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c index 0690340..8fd73c0 100644 --- a/drivers/i2c/fsl_i2c.c +++ b/drivers/i2c/fsl_i2c.c @@ -78,6 +78,73 @@