[Bug 1269058] Re: connect4 always fails to install

2014-01-15 Thread Alejandro J. Cura
I still think that too many apps rely on file extensions, so changing the extension in the downloader sounds evil. Talking on IRC with mandel, I proposed adding the UUID before the first dot, like: mandel-kittens-ABCDEFG.tar.gz He proposed prepending the UUID, which sounds a bit uglier, but I agr

[Bug 1269058] Re: connect4 always fails to install

2014-01-15 Thread Manuel de la Peña
> The UUID is only appended by UDM in two cases: if the app is confined, or if > it's unconfined and the client has sent a > LOCAL_PATH_KEY metadata value. Partially true, the UUID is used to uniquely indentify the download in the download manager. It is appended if the file is present in the fil

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Jamie Strandboge
I mentioned this on IRC-- I've seen this behavior for some time, it was only today that I decided to file the bug (sorry-- not always able to file the moment I see it-- I jotted down that I needed to file it, then tried again last night to see if it was still a problem, it was, so filed). Last cyc

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Mike McCracken
> Even so, I don't know what the story for deleting the packages is, so I'm not actually sure that scenario is possible. I just looked, and UDM does try to delete the downloaded package once the package is successfully post-processed (ie, pkcon returns success) - so a previous successful install s

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Mike McCracken
After some discussion and code spelunking, I wonder if this shouldn't be a unity-scope-click bug. For some background: The UUID is only appended by UDM in two cases: if the app is confined, or if it's unconfined and the client has sent a LOCAL_PATH_KEY metadata value. The scope is running as unc

Re: [Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Colin Watson
I think you're probably right to resist changing UDM. However, I also don't accept the idea that this should be assigned to click, because any package built with click >= 0.3 is already just fine (i.e. I already fixed this bug properly from my point of view, by adjusting the file format so that we

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Manuel de la Peña
** Changed in: ubuntu-download-manager Status: Confirmed => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1269058 Title: connect4 always fails to install To manage notifications abou

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Manuel de la Peña
I do not agree at all to assign this bug to the Ubuntu Download Manager. There are three axioms that I'm not willing to change: 1. UDM is NOT used only for click packages downloads. 2. UDM will NOT remove any file present in the file system. 3 .UMD will NOT stop downloading a file because a file i

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Jamie Strandboge
FYI, the other one I was thinking of was 'Reversi'. It fails in the same manner (./DEBIAN/control:Click-Version: 0.1) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1269058 Title: connect4 always fai

Re: [Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Colin Watson
Right. Anything built with earlier than 0.3 is affected. It might be simplest to scan for this and contact all the affected authors, as 0.3 was before saucy ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.n

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Jamie Strandboge
$ ar tv /tmp/com.ubuntu.developer.geelen-bram.connect4_0.1.3_unknown.click rw-r--r-- 0/0 4 Sep 17 08:53 2013 debian-binary rw-r--r-- 0/0 1105 Sep 17 08:53 2013 control.tar.gz rw-r--r-- 0/0 421853 Sep 17 08:53 2013 data.tar.gz Note that: ./DEBIAN/control:Click-Version: 0.1 This is an old p

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Colin Watson
pkcon only needs the right extension if the package was built with a rather old version of click. Could you run "ar tv" on the package file in question and check for a _click_binary member? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubun

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Alejandro J. Cura
These are the guilty lines: 474// check if the file exists, if it does lets append the uuid to it 475if (QFile::exists(finalPath)) { 476finalPath += downloadId(); 477} -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Alejandro J. Cura
Since this may prevent any package from installing, I'm setting the priority to critical. ** Changed in: ubuntu-download-manager Importance: Medium => Critical -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.

[Bug 1269058] Re: connect4 always fails to install

2014-01-14 Thread Alejandro J. Cura
I think the problem is due to ubuntu-download-manager appending a UUID to the file name: com.ubuntu.developer.geelen-bram.connect4_0.1.3_unknown.click0710607e6a0245a896cc965f613e687f right now pkcon needs the right extension to know how to install the package, so it breaks with the filename abo