[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2021-01-04 Thread Corey Bryant
This bug was fixed in the package ceph - 12.2.13-0ubuntu0.18.04.5~cloud0 --- ceph (12.2.13-0ubuntu0.18.04.5~cloud0) xenial-queens; urgency=medium . * New update for the Ubuntu Cloud Archive. . ceph (12.2.13-0ubuntu0.18.04.5) bionic; urgency=medium . * d/p/rules: Enable RelWi

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-12-04 Thread Ponnuvel Palaniyappan
** Attachment added: "queens_out.after" https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453/+attachment/5440914/+files/queens_out.after ** Tags removed: verification-queens-needed ** Tags added: verification-queens-done -- You received this bug notification because you are a member o

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-12-04 Thread Ponnuvel Palaniyappan
Tested queens-proposed following the same steps noted in #34. Like others results previously, this shows better results as well. Attached the test notes. ** Attachment added: "queens_out.beore" https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453/+attachment/5440913/+files/queens_out.be

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-12-04 Thread Ponnuvel Palaniyappan
Tested queens-proposed following the same steps noted in #34. Like others results previously, this shows better results as well. Attached the test notes. ** Changed in: cloud-archive/queens Assignee: (unassigned) => Ponnuvel Palaniyappan (pponnuvel) ** Changed in: ceph (Ubuntu Bionic) A

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-19 Thread Corey Bryant
This bug was fixed in the package ceph - 13.2.9-0ubuntu0.19.04.1~cloud2 --- ceph (13.2.9-0ubuntu0.19.04.1~cloud2) bionic-stein; urgency=medium . * d/p/rules: Enable RelWithDebInfo (LP: #1894453). ** Changed in: cloud-archive/stein Status: Fix Committed => Fix Released --

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-19 Thread Corey Bryant
This bug was fixed in the package ceph - 14.2.11-0ubuntu0.19.10.1~cloud4 --- ceph (14.2.11-0ubuntu0.19.10.1~cloud4) bionic-train; urgency=medium . * d/p/rules: Enable RelWithDebInfo (LP: #1894453). ** Changed in: cloud-archive/train Status: Fix Committed => Fix Released

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-19 Thread Corey Bryant
This bug was fixed in the package ceph - 15.2.5-0ubuntu0.20.04.1~cloud0 --- ceph (15.2.5-0ubuntu0.20.04.1~cloud0) bionic-ussuri; urgency=medium . * New update for the Ubuntu Cloud Archive. . ceph (15.2.5-0ubuntu0.20.04.1) focal; urgency=medium . [ Corey Bryant ] * d/p/rul

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-19 Thread Launchpad Bug Tracker
This bug was fixed in the package ceph - 12.2.13-0ubuntu0.18.04.5 --- ceph (12.2.13-0ubuntu0.18.04.5) bionic; urgency=medium * d/p/rules: Enable RelWithDebInfo (LP: #1894453). -- Corey Bryant Mon, 26 Oct 2020 09:17:19 -0400 ** Changed in: ceph (Ubuntu Bionic) Status: Fix

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-19 Thread Launchpad Bug Tracker
This bug was fixed in the package ceph - 15.2.5-0ubuntu0.20.04.1 --- ceph (15.2.5-0ubuntu0.20.04.1) focal; urgency=medium [ Corey Bryant ] * d/p/rules: Enable RelWithDebInfo (LP: #1894453). [ James Page ] * New upstream point release (LP: #1898200). - d/p/fix-crash-in-com

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-17 Thread Ponnuvel Palaniyappan
James Page has done focal-proposed verification already (comment #43) - with that, all tests are done and verified. Please let me know if you have any questions. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.ne

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-17 Thread Ponnuvel Palaniyappan
Re-run of the regression tests is OK for 12.2.13-0ubuntu0.18.04.5 [0]. Test results for 12.2.13-0ubuntu0.18.04.5 is good. Attached before & after test results. [0] https://people.canonical.com/~ubuntu-archive/proposed- migration/bionic/update_excuses.html#ceph ** Attachment added: "bionic_verifi

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-17 Thread James Page
I just tested focal-proposed - significant increase in iops and throughput and massive reduction in latency. ** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubu

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-16 Thread Ponnuvel Palaniyappan
Test results for Train. ** Attachment added: "train_verification.txt" https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453/+attachment/5434889/+files/train_verification.txt ** Tags removed: verification-train-needed ** Tags added: verification-train-done -- You received this bug noti

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-16 Thread Ponnuvel Palaniyappan
** Changed in: cloud-archive/train Assignee: (unassigned) => Ponnuvel Palaniyappan (pponnuvel) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894453 Title: Building Ceph packages with RelWithDe

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-16 Thread Ponnuvel Palaniyappan
Performed same as for Ussuri (comment #34) and attached results here. ** Attachment added: "Stein_verification.txt" https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453/+attachment/5434835/+files/Stein_verification.txt -- You received this bug notification because you are a member of

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-16 Thread Ponnuvel Palaniyappan
^^ The above is for Stein verification. ** Tags removed: verification-stein-needed ** Tags added: verification-stein-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894453 Title: Building Ceph

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-16 Thread James Page
verification of this fix on focal is currently blocking 15.2.5 release into focal, and the release of the same update into the bionic/ussuri UCA. @pponnuvel - can you complete the verification work for focal-proposed as well please? -- You received this bug notification because you are a member

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-11 Thread Ponnuvel Palaniyappan
** Changed in: cloud-archive/stein Assignee: (unassigned) => Ponnuvel Palaniyappan (pponnuvel) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894453 Title: Building Ceph packages with RelWithDe

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-10 Thread Ponnuvel Palaniyappan
The smoke-lxc test failure (reported in comment #37) could be due to https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1899180. LP#1899180 suggests this could be treated as flaky. If it's easy, coud try re-running the regression tests for 12.2.13-0ubuntu0.18.04.5 to see if it's indeed a Heise

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-09 Thread Ponnuvel Palaniyappan
** Attachment added: "out__ussuri_after.txt" https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453/+attachment/5432709/+files/out__ussuri_after.txt ** Tags removed: verification-ussuri-needed ** Tags added: verification-ussuri-done -- You received this bug notification because you are

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-09 Thread Ponnuvel Palaniyappan
SRU tests are oood for ussuri (observed perf numbers are better). Did a short rados benchmark and attached the results (before and after upgrade). The steps taken are: - Upgrade the packages on monitor, and OSDs in order. - Restart monitor, manager and OSDs in order. - Repeat the same benchmark te

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-09 Thread Ponnuvel Palaniyappan
** Attachment added: "out__ussuri_before.txt" https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453/+attachment/5432708/+files/out__ussuri_before.txt -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-09 Thread Ponnuvel Palaniyappan
** Changed in: cloud-archive/ussuri Assignee: (unassigned) => Ponnuvel Palaniyappan (pponnuvel) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894453 Title: Building Ceph packages with RelWithD

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-09 Thread Łukasz Zemczak
Hello Ponnuvel, or anyone else affected, Accepted ceph into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ceph/12.2.13-0ubuntu0.18.04.5 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See htt

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-02 Thread Łukasz Zemczak
Hello Ponnuvel, or anyone else affected, Accepted ceph into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ceph/15.2.5-0ubuntu0.20.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-11-02 Thread Corey Bryant
I've uploaded this change to train-staging, stein-staging and the bionic unapproved queue. Note, for these versions there is no change to armhf as enabling RelWithDebInfo for armhf was leading to build timeouts. ** Changed in: ceph (Ubuntu Focal) Status: Incomplete => Triaged -- You recei

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-10-30 Thread Ponnuvel Palaniyappan
** Description changed: [Impact] - This is to consider/discuss the possibility of whether the Ceph packages (UCA) should be built with RelWithDebInfo build option (CMAKE_BUILD_TYPE [0]) which can be supplied to the build script do_cmake.sh [1]. + This is to build the Ceph packages (UCA) with '

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-10-28 Thread Ponnuvel Palaniyappan
Hi Brian, I have updated the description. Does it help? On Tue, Oct 27, 2020 at 10:01 PM Brian Murray <1894...@bugs.launchpad.net> wrote: > >From the bug description its not clear to me why this change should be > SRU'ed to Focal or what the benefit to end users is. Could someone > please elabor

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-10-27 Thread Ponnuvel Palaniyappan
** Description changed: [Impact] This is to consider/discuss the possibility of whether the Ceph packages (UCA) should be built with RelWithDebInfo build option (CMAKE_BUILD_TYPE [0]) which can be supplied to the build script do_cmake.sh [1]. Currently, Upstream as well as UCA builds de

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-10-27 Thread Brian Murray
>From the bug description its not clear to me why this change should be SRU'ed to Focal or what the benefit to end users is. Could someone please elaborate on that? Thanks! ** Changed in: ceph (Ubuntu Focal) Status: Triaged => Incomplete -- You received this bug notification because you a

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-10-26 Thread Corey Bryant
** Also affects: ceph (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: ceph (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: ceph (Ubuntu Bionic) Status: New => Triaged ** Changed in: ceph (Ubuntu Bionic) Importance: Undecided => Med

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-10-21 Thread Corey Bryant
** Description changed: - This is to consider/discuss the possibility of whether the Ceph packages - (UCA) should be built with RelWithDebInfo build option (CMAKE_BUILD_TYPE - [0]) which can be supplied to the build script do_cmake.sh [1]. + [Impact] + This is to consider/discuss the possibility o

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-10-08 Thread Launchpad Bug Tracker
This bug was fixed in the package ceph - 15.2.5-0ubuntu1 --- ceph (15.2.5-0ubuntu1) groovy; urgency=medium [ Corey Bryant ] * d/control: Remove Breaks/Replaces that are older than Focal (LP: #1878419). * d/p/enable-strsignal.patch: Enable HAVE_REENTRANT_STRSIGNAL for groovy

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-10-07 Thread Ponnuvel Palaniyappan
@Corey, Had a discussion with Daniel Hill in SEG, and we think the risk is low. So, yes, we'd like to backport this to all releases. I am happy to do SRU (and/or tests) once this is ready. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubunt

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-29 Thread Corey Bryant
@Ponnuvel, thanks for testing. I've pushed the changes to the ubuntu/groovy package branch and will ask James to +1 before we upload to groovy. If this is low risk we can consider backporting via SRU. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscrib

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-29 Thread Ponnuvel Palaniyappan
@Tyler, Indeed it does. My cluster tests were done in a "cloud-on-cloud" environment, so I didn't want to stress too much on the actual numbers (whereas rocksdb tests were done locally in a tightly controlled environment). As a whole, we can definitely say that RelWithDebInfo is the way to go for r

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-28 Thread Tyler Stachecki
Ponnuvel, don't the fio tests show significantly better write IOPS and latency in the optimized case? == rocksdb%20optimized.txt ... write: IOPS=1269, BW=5076KiB/s (5198kB/s)(2048MiB/413114msec); 0 zone ... | 99.00th=[ 180], 99.50th=[ 384], 99.90th=[ 1003], 99.95th=[ 1636], |

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-28 Thread Ponnuvel Palaniyappan
** Attachment added: "Ceph tests on Octopus - rocksdb optimized.txt" https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453/+attachment/5415022/+files/Ceph%20tests%20on%20Octopus%20-%20rocksdb%20optimized.txt -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-28 Thread Ponnuvel Palaniyappan
** Attachment added: "Ceph tests on Octopus - rocksdb UNoptimized.txt" https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453/+attachment/5415021/+files/Ceph%20tests%20on%20Octopus%20-%20rocksdb%20UNoptimized.txt -- You received this bug notification because you are a member of Ubuntu Bu

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-28 Thread Ponnuvel Palaniyappan
Hi @Corey, (Ignore my comments as I've managed to setup a cluster without needing ceph-deploy). I have installed the packages and setup a cluster. The cluster was functional and found no issues with the Groovy packages in my tests. I have done some of the Ceph's benchmarks [0] using the Ceph clu

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-24 Thread Ponnuvel Palaniyappan
@Corey > The individual building of rocksdb files doesn't give off much information in the package builds to see compiler flags set. VERBOSE flag would show full flags - however, that'd need changing rules & rebuilding again. That we can RelWithDebInfo is sufficient to confirm that it does pass t

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-23 Thread Corey Bryant
@Ponnuvel, I have a package built for groovy with RelWithDebInfo enabled. Can you give it a test? sudo add-apt-repository ppa:corey.bryant/groovy-victoria The individual building of rocksdb files doesn't give off much information in the package builds to see compiler flags set. For example: [

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-21 Thread Ponnuvel Palaniyappan
An update: I have built rocksdb with & without RelWithDebInfo. Some differences are: - the exact set of additional flags used with RelWithDebInfo are: -O2 -NDEBUG -fno-omit-frame-pointer -momit-leaf-frame-pointer. - the size of rocksdb shared library (librocksdb.so): default-build = 156M, with

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-15 Thread Ponnuvel Palaniyappan
@Corey, Yes, I am happy to test this for Groovy. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894453 Title: Building Ceph packages with RelWithDebInfo To manage notifications about this bug go to

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-15 Thread Corey Bryant
@Ponnuvel, if I cherry pick this to the package for groovy can you give it a test? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894453 Title: Building Ceph packages with RelWithDebInfo To manage

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-15 Thread Corey Bryant
@Ponnuvel, Thanks for the details. 4c736f177851cbf9fb7a6790282306ffac5065f8 (the current git submodule hash for octopus) is in origin/ceph-octopus-v5.8-1435. ac304adf46ff073a943d1ab2f6de0623c8ad6d86 (the RelWithDebInfo patch) is in origin/ceph-pacific-v6.8.1-1. So it seems we'll pick this fix up n

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-14 Thread Ponnuvel Palaniyappan
@Tyler, Canonical's Ceph builds don't deal with build options as such (like -DNDEBUG) but uses the upstream provided CMakeLists.txt files. So if we build with RelWithDebInfo, it should automatically use -DNDEBUG, too. The question was whether our build uses RelWithDebInfo -- which turns out to b

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-14 Thread Ponnuvel Palaniyappan
@Corey Bryant, I think Ceph simply specifies rocksdb version to be used in the submodule information. 1. I checked out the tag v15.2.3 (upstream): git checkout tags/v15.2.3 -b 15.2.3 (which src/rocksdb is an empty directory) 2. Initialize submodule indexes: git submodule update --init 3. The c

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-14 Thread Corey Bryant
@Ponnuvel, I'm not fully familiar with how ceph deals with rocksdb code so this is mostly observations from my end. Specifically looking at 15.2.4 for groovy. In https://github.com/ceph/ceph/tree/v15.2.4/src, it appears to pick up rocksdb from a specific commit (rocksdb @ e24b452) that exists in c

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-14 Thread Tyler Stachecki
Good to know it's just rocksdb! Has Canonical also considered compiling the source code with -DNDEBUG to align with what appears to be the upstream default set of RelWithDebInfo flags? The Ceph source code is quasi-judicious about its use of `ceph_assert`, which is effectively compiled out when -

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-14 Thread Ponnuvel Palaniyappan
Looking some of the recent build logs, most of the Ceph packages are in fact compiled with -O2 and -g as Trent alluded to. Only rocksdb is compiled without them as Tyler noted. However, the upstream rocksdbhas been changed to honour CMAKE_BUILD_TYPE recently [2]. So it's only the rocksdb in UCA th

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-10 Thread Tyler Stachecki
Oof - so I hacked up debian/rules a little so that "RelWithDebInfo" is used instead of "None" for CMAKE_BUILD_TYPE. I then ^C'd the dpkg- buildpackage after it started compiling the first few source files and observed that: * When doing make V=1 VERBOSE=1 in obj-x86_64-linux-gnu/src/rocksdb *wi

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-10 Thread Tyler Stachecki
Checked out ceph-15.2.3 source on a up-to-date focal VM. When running dpkg-buildpackage, CMakeCache.txt gets generated as expected. However, the generated CMAKE_BUILD_TYPE is "None". A bit odd, but going a step further, one can grep for CMAKE_C_FLAGS in that same file and see something to the e

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-08 Thread Trent Lloyd
Are we sure it's actually building as Debug? At least 15.2.3 on focal seems to build with RelWithDebugInfo.. I see -O2 .. only do_cmake.sh had logic for this (it would set Debug if a .git directory exists) but the debian rules file doesn't seem to use that script but cmake directly. -- You recei

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-07 Thread Ponnuvel Palaniyappan
Attaching relevant chat transcript with a Ceph dev on RelWithDebInfo. ** Attachment added: "upstream chat(kefu).txt" https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453/+attachment/5408399/+files/upstream%20chat%28kefu%29.txt -- You received this bug notification because you are a me

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-07 Thread James Page
** Changed in: ceph (Ubuntu) Assignee: (unassigned) => James Page (james-page) ** Changed in: ceph (Ubuntu) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894453

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-07 Thread Ponnuvel Palaniyappan
** Tags added: sts -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894453 Title: Building Ceph packages with RelWithDebInfo To manage notifications about this bug go to: https://bugs.launchpad.net/u

[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

2020-09-07 Thread Ponnuvel Palaniyappan
Another thing to note is that the size of binaries will be slightly bigger and also the build/compilation will be longer. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894453 Title: Building Ceph p