** Changed in: gnucash (Debian)
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1923642
Title:
glib can no longer be included in extern "C" blocks
To manage n
> Keeping the patches separate is good practice in that they might not
all be accepted upstream at the same time.
Ah that makes sense!
> The master branch of the gnucash repo seems to only include the
debian/ directory, not the upstream files.
This threw me off and that's why I made a patch that
On 2021-09-08 16:54, Heather Ellsworth wrote:
> @Gunnar, Thanks! I didn't realize that the 4.6 that debian pulled
> fixes the issue. There was nothing in the 4.6 commits that suggested
> this issue had been fixed, so did you just build and test it to see?
> Or how did you know that 4.6 fixes the is
Keeping the patches separate is good practice in that they might not all
be accepted upstream at the same time. Using this strategy its easier to
drop individual patches, when merging with a new upstream version, then
modifying one big patch.
--
You received this bug notification because you are
@Gunnar, Thanks! I didn't realize that the 4.6 that debian pulled fixes
the issue. There was nothing in the 4.6 commits that suggested this
issue had been fixed, so did you just build and test it to see? Or how
did you know that 4.6 fixes the issue?
https://salsa.debian.org/debian/gnucash/-/compar
This bug was fixed in the package gnucash - 1:4.4-1ubuntu1
---
gnucash (1:4.4-1ubuntu1) impish; urgency=medium
* Fix FTBFS due to glib headers in 'extern "C"' blocks (LP: #1923642)
- No longer permitted with glib2.0 2.67.3+
- The fix consists of these upstream commits:
I digged deeper into it. The patch in your PPA actually just creates
another patch, and doesn't change any upstream files. If you had done it
right, you'd have found that it doesn't apply by itself.
I uploaded a fix. Besides the upstream commit which Robie mentioned, I
included six other commits t
@Heather: Debian chose to fix it by updating to a new upstream release
(version 4.6). Syncing into impish would require a FFe approval, I
suppose:
https://github.com/Gnucash/gnucash/releases/tag/4.6
Better do that in next cycle IMO, and use your patch in Ubuntu for now.
However, the PPA build fa
I've just put the patch on top of 4.4 that is in impish and uploaded the
build artifacts to:
https://launchpad.net/~hellsworth/+archive/ubuntu/gnucash
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1923
Thank you for working on getting this pulled into Debian!
What's your plan for Ubuntu? Are you holding on to see if Debian uploads
soon so that Ubuntu can sync it? Or do you want your fix uploaded into
Ubuntu ahead of Debian, pending it being fixed in Debian?
I would normally expect the latter fo
This was just a case of not getting notified of my PR's activity and
forgetting.. sorry bout that.
I've updated the PR to get the fix pulled in debian.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/19
** Changed in: gnucash (Ubuntu)
Assignee: (unassigned) => Heather Ellsworth (hellsworth)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1923642
Title:
glib can no longer be included in extern "C
Looks like upstream has fixed this now with
https://github.com/Gnucash/gnucash/commit/bbb4113a5a996dcd7bb3494e0be900b275b49a4f,
so it would probably be best if we cherry-picked that commit. Could you
prepare an upload with a quilt patch and dep3 headers against that
upstream commit please, and I'll
** Bug watch removed: Red Hat Bugzilla #1926239
https://bugzilla.redhat.com/show_bug.cgi?id=1926239
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1923642
Title:
glib can no longer be included in
** Changed in: gnucash (Debian)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1923642
Title:
glib can no longer be included in extern "C" blocks
To manage notificati
Launchpad has imported 6 comments from the remote bug at
https://bugs.gnucash.org/show_bug.cgi?id=798156.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.la
** Bug watch added: GnuCash Bug Tracker #798156
https://bugs.gnucash.org/show_bug.cgi?id=798156
** Also affects: gnucash via
https://bugs.gnucash.org/show_bug.cgi?id=798156
Importance: Unknown
Status: Unknown
--
You received this bug notification because you are a member of Ubunt
** Changed in: gnucash (Debian)
Status: Unknown => New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1923642
Title:
glib can no longer be included in extern "C" blocks
To manage notification
** Tags added: ftbfs
** Changed in: gnucash (Ubuntu)
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1923642
Title:
glib can no longer be included in extern "C" blo
** Also affects: gnucash (Debian) via
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986969
Importance: Unknown
Status: Unknown
** Project changed: gnucash => ubuntu
** Changed in: ubuntu
Importance: Unknown => Undecided
** Changed in: ubuntu
Remote watch: Debian Bug tracker
** Changed in: gnucash
Status: Unknown => New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1923642
Title:
glib can no longer be included in extern "C" blocks
To manage notifications about t
Actually just submitted the cherry-pick'd Fedora patch to Debian:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986969
https://salsa.debian.org/debian/gnucash/-/merge_requests/1
** Bug watch added: Debian Bug tracker #986969
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986969
** Also
The attachment "fix-build.patch" seems to be a debdiff. The ubuntu-
sponsors team has been subscribed to the bug report so that they can
review and hopefully sponsor the debdiff. If the attachment isn't a
patch, please remove the "patch" flag from the attachment, remove the
"patch" tag, and if yo
Actually there is a better fix in Fedora:
https://src.fedoraproject.org/rpms/gnucash/blob/7287f9ed18964fac061035ba3a86566e1a03c4c5/f
/gnucash-glib.patch
Please cherry-pick it to get past the hirsute build failure:
https://launchpadlibrarian.net/532491875/buildlog_ubuntu-hirsute-
amd64.gnucash_1%3A
24 matches
Mail list logo
