I can't reopen this
Heheh... Oh well, hopefully the patch will make it in soon, and we can
restrain ourselves from raving over this trivial point for the time
being. :) Thanks for the fix!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
This was not actually fixed. As of today, it tells me Checking disks
are for errors
Why is 'are' in there?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/572016
Title:
Disk check message is
Yep, it's messed up all right. My patch said:
+ message = NIH_MUST (nih_strdup (NULL, _(Your disk drives are
being checked for errors. This may take some time)));
The final patch says:
message = NIH_MUST (nih_strdup (NULL, _(Checking disk drives
are for errors.
And it looks like I can't reopen this, but it wouldn't make sense to
start a NEW bug...
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/572016
Title:
Disk check message is grammatically incorrect
To
I've used nstenz's patch with some of Jay's suggestions. I agree with
the comma and semicolon changes. I put periods on the ends of all the
user visible statements; I tend to agree they look like they need them.
I chose to say 'several minutes' instead of 'few minutes' since fsck's
can sometimes
This bug was fixed in the package mountall - 2.26
---
mountall (2.26) oneiric; urgency=low
* Correct grammar on user-visible strings
(LP: #572016)
-- Bryce Harrington br...@ubuntu.com Tue, 07 Jun 2011 12:16:22 -0700
** Changed in: mountall (Ubuntu)
Status: Confirmed
Agree with Thangalin and nstenz; disk drives is redundant, and some
time is meaningless.
nstenz patch only adds a period before the first sentence. I understand
that short messages can sometimes drop their periods, but for
consistency I think they should all have periods.
My proposed verbiage:
Here's a patch with my suggested grammatical fixes (there were a few
other lines with the same sort of issue). Who do I have to beg to get
this merged in?
I didn't end it in a period because none of the other messages are
complete sentences either, but since Plymouth looks so nice and
Also, I agree that disk drives is redundant. It should be one or the
other.
** Changed in: mountall (Ubuntu)
Status: Triaged = Confirmed
--
Disk check message is grammatically incorrect
https://bugs.launchpad.net/bugs/572016
You received this bug notification because you are a member of
Oops- patch was against 2.14. This is against 2.15.
** Patch removed: suggested patch
http://launchpadlibrarian.net/52416379/mountall.c.patch
** Patch added: suggested patch
http://launchpadlibrarian.net/52416977/mountall.c.patch
--
Disk check message is grammatically incorrect
** Tags added: patch
--
Disk check message is grammatically incorrect
https://bugs.launchpad.net/bugs/572016
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
While it's usual for short messages to have no end punctuation, and it's
quite reasonable to say your disk drives since your means possession
(not ownership), the comma splice is annoying. I suggest either the
version suggested by Jonathan or the following (which I prefer due to
its greater
Also, the phrase This may take some time is verbose and meaningless:
everything takes time.
Better to say, Checking disk drives for errors; please wait. (Avoid
using you or your because the drives might not actually belong to
that person.)
Would be great to see a % complete, too, so users know
** Package changed: plymouth (Ubuntu) = mountall (Ubuntu)
** Changed in: mountall (Ubuntu)
Importance: Undecided = Low
** Changed in: mountall (Ubuntu)
Status: New = Triaged
--
Disk check message is grammatically incorrect
https://bugs.launchpad.net/bugs/572016
You received this bug
** Attachment added: BootDmesg.txt
http://launchpadlibrarian.net/46463233/BootDmesg.txt
** Attachment added: CurrentDmesg.txt
http://launchpadlibrarian.net/46463234/CurrentDmesg.txt
** Attachment added: Dependencies.txt
http://launchpadlibrarian.net/46463235/Dependencies.txt
**
15 matches
Mail list logo
