Re: [Merge] ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10

2019-01-11 Thread Tony Espy
Note, I'm not able to successfully build this version using the latest stable version of snapcraft. This may be due to virtualization, as I'm building from Ubuntu running under Parallels w/nested virtualization enabled (to allow multipass to run). Perhaps this is because the Parallels VM instanc

[Merge] ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10

2019-01-11 Thread noreply
The proposal to merge ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10 has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/361245 -- Your te

[Merge] ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10

2019-01-11 Thread Tony Espy
The proposal to merge ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/361245 -- Y

Re: [Merge] ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10

2019-01-11 Thread Tony Espy
Review: Approve LGTM -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/361245 Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10. -- ubun

Re: [Merge] ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10

2019-01-11 Thread Alfonso Sanchez-Beato
@Tony, it is probably that - I have come also into trouble when trying to build in a virtualized environment. Probably we should run the unit tests in CI only and not in snapcraft's build stage. -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/361245