Review: Approve
thank you!
--
https://code.launchpad.net/~binli/ubuntu/+source/gdm3/+git/gdm3/+merge/356297
Your team Ubuntu Desktop is subscribed to branch
~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic.
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
Diff comments:
> diff --git a/debian/patches/data-61-gdm.rules.in.patch
> b/debian/patches/data-61-gdm.rules.in.patch
> new file mode 100644
> index 000..77146bf
> --- /dev/null
> +++ b/debian/patches/data-61-gdm.rules.in.patch
> @@ -0,0 +1,23 @@
> +From: Bin Li
> +Date: Wed, 29 Aug 2018
@Iain,
Done, I thought I forgot commit the DEP-3 changes, and I re-added them, please
help check it again, thanks!
--
https://code.launchpad.net/~binli/ubuntu/+source/gdm3/+git/gdm3/+merge/354933
Your team Ubuntu Desktop is subscribed to branch
Great! Thanks a lot!
--
https://code.launchpad.net/~binli/ubuntu/+source/gdm3/+git/gdm3/+merge/354933
Your team Ubuntu Desktop is subscribed to branch
~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic.
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
ug/1780076
For more details, see:
https://code.launchpad.net/~binli/ubuntu/+source/gdm3/+git/gdm3/+merge/354933
--
Your team Ubuntu Desktop is requested to review the proposed merge of
~binli/ubuntu/+source/gdm3:ubuntu/bionic into
~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic.
diff --git a/debian/c
The proposal to merge ~binli/ubuntu/+source/gdm3:ubuntu/bionic into
~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~binli/ubuntu/+source/gdm3/+git/gdm3/+merge/354933
--
Your team Ubu
Review: Approve
Thanks.
I did a couple of fixes to the branch and I'll push & upload to the queue.
- Add "[ Bin Li ]" to the changelog above your bits
- Noted that you cherry picked the install location fix from cosmic
- Reordered the patches so that the backports are above the distro
> by the way, if you force push this branch when fixing it, there should be no
> need to make a new merge proposal
Got it.:)
--
https://code.launchpad.net/~binli/ubuntu/+source/gdm3/+git/gdm3/+merge/354933
Your team Ubuntu Desktop is subscribed to branch
Review: Needs Fixing
thanks, almost there, just a couple of changes to request please (see the diff
comments)
Diff comments:
> diff --git a/debian/patches/data-61-gdm.rules.in.patch
> b/debian/patches/data-61-gdm.rules.in.patch
> new file mode 100644
> index 000..77146bf
> --- /dev/null
>
by the way, if you force push this branch when fixing it, there should be no
need to make a new merge proposal
Diff comments:
> diff --git a/debian/patches/data-61-gdm.rules.in.patch
> b/debian/patches/data-61-gdm.rules.in.patch
> new file mode 100644
> index 000..77146bf
> --- /dev/null
>
10 matches
Mail list logo
