[Ubuntu-touch-coreapps-reviewers] [Bug 1482666] Re: Hidden files

2015-08-23 Thread Krzysztof TataradziƄski
No, on MX4 there is no place for SD card. I think that option for allowing to see hidden files isn't explained (there aren't any tutorial on screen). For now we must firstly unlock full access (or sth like that, can't check now - my screen is broken). -- You received this bug notification

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-translate-owm into lp:ubuntu-weather-app/reboot

2015-08-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:103 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/223/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/193 SUCCESS:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-invalid-alarm-model into lp:ubuntu-clock-app

2015-08-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:354 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/801/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/146 Click here to trigger a rebuild:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app

2015-08-23 Thread Nekhelesh Ramananthan
Nekhelesh Ramananthan has proposed merging lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app. Commit message: Fixed non-notifyable warning shown when opening the edit alarm page. Requested reviews: Ubuntu Clock Developers (ubuntu-clock-dev) For more details, see:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-lok-zoom into lp:ubuntu-docviewer-app/reboot

2015-08-23 Thread Roman Shchekin
Mutex usage looks strange. It isn't common way to use it - declare local variable. Is it correct? -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-lok-zoom/+merge/267982 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/add-world-city-manual-test into lp:ubuntu-clock-app

2015-08-23 Thread Bartosz Kosiorek
The proposal to merge lp:~nik90/ubuntu-clock-app/add-world-city-manual-test into lp:ubuntu-clock-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/add-world-city-manual-test/+merge/268844 -- Your team Ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/add-world-city-manual-test into lp:ubuntu-clock-app

2015-08-23 Thread Bartosz Kosiorek
Review: Approve Lgtm. Clock Checklist passed -- https://code.launchpad.net/~nik90/ubuntu-clock-app/add-world-city-manual-test/+merge/268844 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot

2015-08-23 Thread Ubuntu Phone Apps Jenkins Bot
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot has been updated. Status: Approved = Needs review For more details, see:

[Ubuntu-touch-coreapps-reviewers] [Bug 1482666] Re: Hidden files

2015-08-23 Thread Carlos Jose Mazieri
Hello, Maybe you are talking about SD card only. Can you confirm that it is not a file manager bug? -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot

2015-08-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-autolanding/1/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3175/console FAILURE:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-deb-build-dependency into lp:ubuntu-docviewer-app/reboot

2015-08-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:170 http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/5/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3176/console FAILURE:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-invalid-alarm-model into lp:ubuntu-clock-app

2015-08-23 Thread Bartosz Kosiorek
Review: Approve It is working for me correctly. Unfortunately time needed to run is very high. You did everything what was needed according to checklist. -- https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-invalid-alarm-model/+merge/268838 Your team Ubuntu Clock Developers is subscribed

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-deb-build-dependency into lp:ubuntu-docviewer-app/reboot

2015-08-23 Thread Stefano Verzegnassi
Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-deb-build-dependency into lp:ubuntu-docviewer-app/reboot. Commit message: Added missing build dependency (libreofficekit-dev) Requested reviews: Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot

2015-08-23 Thread Roman Shchekin
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot has been updated. Status: Needs review = Approved For more details, see:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot

2015-08-23 Thread Roman Shchekin
Review: Approve That's ok! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181/+merge/266904 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app/reboot. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app

2015-08-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:352 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/803/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/148/console Click here to trigger a rebuild:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app

2015-08-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app

2015-08-23 Thread noreply
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846 -- Your team Ubuntu Clock

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app

2015-08-23 Thread Bartosz Kosiorek
Review: Approve Looks ok to me. I think we could do not update changelog with such small issue. -- https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app

2015-08-23 Thread Bartosz Kosiorek
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846 -- Your team Ubuntu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/add-world-city-manual-test into lp:ubuntu-clock-app

2015-08-23 Thread noreply
The proposal to merge lp:~nik90/ubuntu-clock-app/add-world-city-manual-test into lp:ubuntu-clock-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/add-world-city-manual-test/+merge/268844 -- Your team Ubuntu Clock

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-writeback-issue into lp:reminders-app

2015-08-23 Thread Michael Zanetti
Diff comments: === modified file 'CMakeLists.txt' --- CMakeLists.txt2015-06-14 23:34:29 + +++ CMakeLists.txt2015-07-05 19:26:31 + @@ -20,7 +20,7 @@ set(AUTOPILOT_DIR reminders) set(APP_HARDCODE reminders) set(MAIN_QML ${APP_HARDCODE}.qml) -set(EXEC reminders %u)

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation into lp:ubuntu-calendar-app

2015-08-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:711 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1229/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/226 Click here to trigger a rebuild:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app

2015-08-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:708 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1228/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/225 Click here to trigger a rebuild:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation into lp:ubuntu-calendar-app

2015-08-23 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation into lp:ubuntu-calendar-app. Commit message: Performance tunning for page transition. Page Transition between different views will cause dynamic creation(Qt.ResolvedUrl) for qml object back and forth.Using

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app

2015-08-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:710 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1230/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/227 Click here to trigger a rebuild:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app

2015-08-23 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app. Commit message: Tab change will cause dynamic creation(Qt.ResolvedUrl) for qml object back and forth.Using Qt.CreateComponent for dynamic creation for the first time and