Chris Zankel wrote:
Hi Carmelo,
Sorry, I also forgot to add the 'signed-off' line. Looking at the log
file, however, it seems that less than 5% of the commits are
'signed-off'. What's the policy?
I'm used to sign-off my work being this a common/required policy on
kernel side. I think
Carmelo AMOROSO wrote:
Hi Bob,
I don't see any problems in committing this on behalf
of you, but proper signed-off-by should be added
to these set of patches, as a general rule of thumbs.
Possibly Acked-by Xtensa Maintainer (Chris Zankel)
It looks like Chris already committed them, but
Bob Wilson wrote:
Carmelo AMOROSO wrote:
Hi Bob,
I don't see any problems in committing this on behalf
of you, but proper signed-off-by should be added
to these set of patches, as a general rule of thumbs.
Possibly Acked-by Xtensa Maintainer (Chris Zankel)
It looks like Chris already
The Xtensa-specific strcmp.S file is testing the __UCLIBC_HAS_LOCALE__ macro but
it does not include features.h, so that macro is never defined. This causes
problems with strcoll when locale support is enabled.
Index: libc/string/xtensa/strcmp.S
