Re: [PATCH 1/3] libc_elf: improve auxiliary vector handling

2011-05-03 Thread Carmelo AMOROSO
On 5/3/2011 1:39 AM, Kevin Cernekee wrote: [SNIP] - /* Get the number of program headers from the aux vect */ - _dl_phnum = (size_t) av[AT_PHNUM].a_un.a_val; +for (; av-a_type AT_NUM; ++av) { +switch (av-a_type) { FWIW, that does result in mixed indentation styles in

Re: [PATCH 1/3] libc_elf: improve auxiliary vector handling

2011-05-03 Thread Bernhard Reutner-Fischer
On Tue, May 03, 2011 at 12:21:52PM +0200, Carmelo AMOROSO wrote: On 5/3/2011 1:39 AM, Kevin Cernekee wrote: [SNIP] - /* Get the number of program headers from the aux vect */ - _dl_phnum = (size_t) av[AT_PHNUM].a_un.a_val; + for (; av-a_type AT_NUM; ++av) { + switch

Re: [PATCH 1/3] libc_elf: improve auxiliary vector handling

2011-05-03 Thread Peter Mazinger
Hi I also recognized that usually we should not force change in coding style on old code, so I'm available for both option. the indentation with 2 spaces is from code copied from glibc, some old uclibc files have a vi directive for 1tab = 4 spaces I personally use a tab (per default 8 spaces),

[PATCH 1/3] libc_elf: improve auxiliary vector handling

2011-05-02 Thread Carmelo AMOROSO
This patch is aimed to improve the aux vect handling to gather some useful information from the system through the aux vect. It is achieved by: - retrieving aux vect inforamtion into _dl_aux_init only - allowing to call _dl_aux_init in both shared and static case - enabling arch specific aux vect

Re: [PATCH 1/3] libc_elf: improve auxiliary vector handling

2011-05-02 Thread Bernhard Reutner-Fischer
On 2 May 2011 18:44, Carmelo AMOROSO carmelo.amor...@st.com wrote: This patch is aimed to improve the aux vect handling to gather some useful information from the system through the aux vect. It is achieved by: - retrieving aux vect inforamtion into _dl_aux_init only

Re: [PATCH 1/3] libc_elf: improve auxiliary vector handling

2011-05-02 Thread Kevin Cernekee
On Mon, May 2, 2011 at 9:44 AM, Carmelo AMOROSO carmelo.amor...@st.com wrote: This patch is aimed to improve the aux vect handling to gather some useful information from the system through the aux vect. It is achieved by: Thanks for working on this - it looks like we're on the right track. A

Re: [PATCH 1/3] libc_elf: improve auxiliary vector handling

2011-05-02 Thread Carmelo AMOROSO
On 5/3/2011 1:39 AM, Kevin Cernekee wrote: On Mon, May 2, 2011 at 9:44 AM, Carmelo AMOROSO carmelo.amor...@st.com wrote: This patch is aimed to improve the aux vect handling to gather some useful information from the system through the aux vect. It is achieved by: Thanks for working on

Re: [PATCH 1/3] libc_elf: improve auxiliary vector handling

2011-05-02 Thread Carmelo AMOROSO
On 5/2/2011 7:59 PM, Bernhard Reutner-Fischer wrote: On 2 May 2011 18:44, Carmelo AMOROSO carmelo.amor...@st.com wrote: This patch is aimed to improve the aux vect handling to gather some useful information from the system through the aux vect. It is achieved by: - retrieving aux vect