hashcode handling

2014-07-25 Thread czankel
Hi, The following patches are still outstanding since Nov '13. It would be great if someone could approve them or give feedback. These generic changes are required to add NPTL support for Xtensa. http://patchwork.ozlabs.org/patch/288804/ http://patchwork.ozlabs.org/patch/288805/ Thanks, -Chr

Re: hashcode handling

2014-07-25 Thread Khem Raj
On Fri, Jul 25, 2014 at 9:10 AM, czankel wrote: > Hi, > > The following patches are still outstanding since Nov '13. It would be great > if someone could approve them or give feedback. These generic changes are > required to add NPTL support for Xtensa. > > http://patchwork.ozlabs.org/patch/288804

[PATCH 2/2] ldso: make hashcode handling more generic

2013-11-06 Thread Baruch Siach
The hashcode handling code never accesses the underlying structure 'struct funcdesc_value', but only operates on pointer to pointers, so we can use void** instead. Also, pass in the functions to generate and compare a hash entry. This is a minor functional change to inject functio

Re: [PATCH 2/2] ldso: make hashcode handling more generic

2013-11-06 Thread Rich Felker
On Wed, Nov 06, 2013 at 11:23:06AM +0200, Baruch Siach wrote: > The hashcode handling code never accesses the underlying structure > 'struct funcdesc_value', but only operates on pointer to pointers, > so we can use void** instead. No you can't. This is an aliasing v

Re: [PATCH 2/2] ldso: make hashcode handling more generic

2013-11-07 Thread Chris Zankel
Hi Rich, Thanks for your feedback. On 11/6/13, 9:27 PM, Rich Felker wrote: On Wed, Nov 06, 2013 at 11:23:06AM +0200, Baruch Siach wrote: The hashcode handling code never accesses the underlying structure 'struct funcdesc_value', but only operates on pointer to pointers, so we ca

Re: [PATCH 2/2] ldso: make hashcode handling more generic

2014-01-13 Thread Chris Zankel
Zankel wrote: Hi Rich, Thanks for your feedback. On 11/6/13, 9:27 PM, Rich Felker wrote: On Wed, Nov 06, 2013 at 11:23:06AM +0200, Baruch Siach wrote: The hashcode handling code never accesses the underlying structure 'struct funcdesc_value', but only operates on pointer to pointers,

Re: [PATCH 2/2] ldso: make hashcode handling more generic

2014-01-22 Thread Bernhard Reutner-Fischer
On 13 January 2014 17:18, Chris Zankel wrote: > Hi, > > I was wondering if anyone had a chance to look at these changes again? I > have attached the two patches we propose so we can add support for TLS > descriptors. > > It would be great to get an ACK for it (or NACK with maybe some other > sugge

Re: [PATCH 2/2] ldso: make hashcode handling more generic

2014-01-22 Thread Chris Zankel
Hi Bernhard, On 1/22/14, 2:15 PM, Bernhard Reutner-Fischer wrote: On 13 January 2014 17:18, Chris Zankel wrote: Hi, I was wondering if anyone had a chance to look at these changes again? I have attached the two patches we propose so we can add support for TLS descriptors. It would be great t

Re: [PATCH 2/2] ldso: make hashcode handling more generic

2014-01-23 Thread Baruch Siach
Hi Chris, On Wed, Jan 22, 2014 at 05:11:26PM -0800, Chris Zankel wrote: > On 1/22/14, 2:15 PM, Bernhard Reutner-Fischer wrote: > >On 13 January 2014 17:18, Chris Zankel wrote: > >>I was wondering if anyone had a chance to look at these changes again? I > >>have attached the two patches we propose

[PATCH 1/2] ldso: move hashcode handling code to a separate header file

2013-11-06 Thread Baruch Siach
Move the hashcode handling code inside the ldso/fdpic/dl-inlines.h to a header file (include/inline-hashtab.h), without any functional changes. This is in preparation for supporting TLS descriptors, which also uses that code. Signed-off-by: Chris Zankel Signed-off-by: Baruch Siach --- ldso