[jira] Work started: (UIMA-45) Review and clean up unit tests

2007-01-12 Thread Adam Lally (JIRA)
[ https://issues.apache.org/jira/browse/UIMA-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on UIMA-45 started by Adam Lally. > Review and clean up unit tests > -- > > Key: UIMA-45 > URL: https://issu

Proposal for eliminating static methods on JCasImpl, called from JCas cover classes

2007-01-12 Thread Adam Lally
Currently there are three static methods on JCasImpl that are called from JCasGen-erated cover classes. I'd like to do something about this because it means we haven't fully separated the JCas interface and implementation. For example I could (theoretically, someday) call new MyJCasType(jcas) wh

Re: Proposal for eliminating static methods on JCasImpl, called from JCas cover classes

2007-01-12 Thread Adam Lally
Pushed send a little too quick... I also had another point to make. Currently getNextIndex() does something strange - it queries the current Java stack trace to figure out which cover class called it, so that it knows which index is assigned to which class. This was added after-the-fact so as to

[jira] Closed: (UIMA-183) (CAS/JCAS).getAnnotationIndex should declare return type AnnotationIndex

2007-01-12 Thread Thilo Goetz (JIRA)
[ https://issues.apache.org/jira/browse/UIMA-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thilo Goetz closed UIMA-183. Resolution: Fixed Done. I noticed that in the JCas, getAnnotationIndex() is on the the index repository, no

Re: [jira] Work started: (UIMA-115) The TCAS class should be dropped

2007-01-12 Thread Eddie Epstein
This work could be complete. mvn install completes, CVD and Document Analyzer run ok. Many files were touched in many places. Eddie

Re: [jira] Closed: (UIMA-183) (CAS/JCAS).getAnnotationIndex should declare return type AnnotationIndex

2007-01-12 Thread Marshall Schor
Thilo Goetz (JIRA) wrote: I noticed that in the JCas, getAnnotationIndex() is on the the index repository, not on the JCas. That seems reasonable, but is inconsistent with the poCAS. I think it should also be on the JCas, forwarding to the CAS. Any objection to my adding it? -Marshal

Re: [jira] Closed: (UIMA-183) (CAS/JCAS).getAnnotationIndex should declare return type AnnotationIndex

2007-01-12 Thread Thilo Goetz
I think it would be good to have those APIs on the JCas, for consistency with the CAS. Marshall Schor wrote: Thilo Goetz (JIRA) wrote: I noticed that in the JCas, getAnnotationIndex() is on the the index repository, not on the JCas. That seems reasonable, but is inconsistent with the poCAS.

Re: Proposal for eliminating static methods on JCasImpl, called from JCas cover classes

2007-01-12 Thread Marshall Schor
Adam Lally wrote: Pushed send a little too quick... I also had another point to make. Currently getNextIndex() does something strange - it queries the current Java stack trace to figure out which cover class called it, so that it knows which index is assigned to which class. This was added afte

[jira] Created: (UIMA-184) Add getAnnotationIndex() to JCas API, impl via forwarding to CAS

2007-01-12 Thread Marshall Schor (JIRA)
Add getAnnotationIndex() to JCas API, impl via forwarding to CAS Key: UIMA-184 URL: https://issues.apache.org/jira/browse/UIMA-184 Project: UIMA Issue Type: Improvement

[jira] Assigned: (UIMA-184) Add getAnnotationIndex() to JCas API, impl via forwarding to CAS

2007-01-12 Thread Marshall Schor (JIRA)
[ https://issues.apache.org/jira/browse/UIMA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marshall Schor reassigned UIMA-184: --- Assignee: Marshall Schor > Add getAnnotationIndex() to JCas API, impl via forwarding to CAS > -

Build scripts

2007-01-12 Thread Thilo Goetz
I added a small script that I use for testing the distribution: uimaj-distr/src/main/build/extractAndBuild.bat/.sh. If you feel this is not a good place to have them, feel free to move them around. I didn't add them to the scripts directory as we probably don't want to distribute them, and th

Should we take this opportunity to clean up unneeded Throws declarations in our APIs?

2007-01-12 Thread Marshall Schor
Running Findbugs, etc., will report on throws / catches that are never used because the code in the try doesn't throw what is being caught or propagated up. It might be good to clean these up. Typically, they are not changed, because that kind of a change in an API breaks user code. I'm wond

Re: Should we take this opportunity to clean up unneeded Throws declarations in our APIs?

2007-01-12 Thread Thilo Goetz
Marshall Schor wrote: Running Findbugs, etc., will report on throws / catches that are never used because the code in the try doesn't throw what is being caught or propagated up. It might be good to clean these up. Typically, they are not changed, because that kind of a change in an API brea

Re: Should we take this opportunity to clean up unneeded Throws declarations in our APIs?

2007-01-12 Thread Adam Lally
On 1/12/07, Marshall Schor <[EMAIL PROTECTED]> wrote: Running Findbugs, etc., will report on throws / catches that are never used because the code in the try doesn't throw what is being caught or propagated up. I'm not sure what you mean exactly - did you mean "because the code in the _method_

[jira] Closed: (UIMA-184) Add getAnnotationIndex() to JCas API, impl via forwarding to CAS

2007-01-12 Thread Marshall Schor (JIRA)
[ https://issues.apache.org/jira/browse/UIMA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marshall Schor closed UIMA-184. --- Resolution: Fixed Fix Version/s: 2.1 > Add getAnnotationIndex() to JCas API, impl via forwarding

Do we need a new doc (could be a chapter): Migration Guide?

2007-01-12 Thread Marshall Schor
We're changing a reasonable amount of stuff for 2.1. I think we might need a migration guide. This could be both a chapter in the docbooks and also a page on our website. Opinions? Contributions? Also, as changes are made to the code, please also update the relevant docbook sources to ref

Re: Do we need a new doc (could be a chapter): Migration Guide?

2007-01-12 Thread Adam Lally
On 1/12/07, Marshall Schor <[EMAIL PROTECTED]> wrote: We're changing a reasonable amount of stuff for 2.1. I think we might need a migration guide. This could be both a chapter in the docbooks and also a page on our website. Yes, definitely. I will work on this as part of http://issues.apa

Re: Build scripts

2007-01-12 Thread Adam Lally
On 1/12/07, Thilo Goetz <[EMAIL PROTECTED]> wrote: I added a small script that I use for testing the distribution: uimaj-distr/src/main/build/extractAndBuild.bat/.sh. If you feel this is not a good place to have them, feel free to move them around. I didn't add them to the scripts directory as

[jira] Reopened: (UIMA-182) Extend CasCreationUtils methods for type system merging to return list of types where feature-merge was required

2007-01-12 Thread Adam Lally (JIRA)
[ https://issues.apache.org/jira/browse/UIMA-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Lally reopened UIMA-182: - This should be enhanced so that the framework reports which descriptor files contain the type definitions that

Re: Build scripts

2007-01-12 Thread Thilo Goetz
Adam Lally wrote: On 1/12/07, Thilo Goetz <[EMAIL PROTECTED]> wrote: I added a small script that I use for testing the distribution: uimaj-distr/src/main/build/extractAndBuild.bat/.sh. If you feel this is not a good place to have them, feel free to move them around. I didn't add them to the sc

[jira] Resolved: (UIMA-182) Extend CasCreationUtils methods for type system merging to return list of types where feature-merge was required

2007-01-12 Thread Adam Lally (JIRA)
[ https://issues.apache.org/jira/browse/UIMA-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Lally resolved UIMA-182. - Resolution: Fixed Assignee: Marshall Schor (was: Adam Lally) > Extend CasCreationUtils methods for t

TCASException and TCASRuntimeException

2007-01-12 Thread Adam Lally
Eddie, you removed the classes TCASException and TCASRuntimeException but I see that the message digests tcas_errors.proprties and tcas_runtime_exc.properties are still there. Do these need to be merged with the CASException and CASRuntimeException? -Adam

Re: Build scripts

2007-01-12 Thread Adam Lally
On 1/12/07, Thilo Goetz <[EMAIL PROTECTED]> wrote: When I wrote that script, some tests wouldn't pass and the build stopped. Since I was interested in building the distribution, I removed the tests. If our tests are at a stage now where they normally pass, let's just remove the switch. The t

Re: Build scripts

2007-01-12 Thread Thilo Goetz
Adam Lally wrote: On 1/12/07, Thilo Goetz <[EMAIL PROTECTED]> wrote: When I wrote that script, some tests wouldn't pass and the build stopped. Since I was interested in building the distribution, I removed the tests. If our tests are at a stage now where they normally pass, let's just remove t

[jira] Created: (UIMA-185) Make CAS use same Exception concept as the rest of UIMA

2007-01-12 Thread Thilo Goetz (JIRA)
Make CAS use same Exception concept as the rest of UIMA --- Key: UIMA-185 URL: https://issues.apache.org/jira/browse/UIMA-185 Project: UIMA Issue Type: Improvement Components: Cor

[jira] Created: (UIMA-186) AnalysisEngine.setResultSpecification doesn't clear out previously cached result specification information

2007-01-12 Thread Adam Lally (JIRA)
AnalysisEngine.setResultSpecification doesn't clear out previously cached result specification information -- Key: UIMA-186 URL: https://issues.apache.org/jira

[jira] Closed: (UIMA-186) AnalysisEngine.setResultSpecification doesn't clear out previously cached result specification information

2007-01-12 Thread Adam Lally (JIRA)
[ https://issues.apache.org/jira/browse/UIMA-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Lally closed UIMA-186. --- Resolution: Fixed > AnalysisEngine.setResultSpecification doesn't clear out previously cached > result specifi

[jira] Created: (UIMA-187) getSofaDataString() is documented in the manul but does not exist in the code

2007-01-12 Thread Adam Lally (JIRA)
getSofaDataString() is documented in the manul but does not exist in the code - Key: UIMA-187 URL: https://issues.apache.org/jira/browse/UIMA-187 Project: UIMA Issue

[jira] Updated: (UIMA-187) getSofaDataString() is documented in the manual but does not exist in the code

2007-01-12 Thread Adam Lally (JIRA)
[ https://issues.apache.org/jira/browse/UIMA-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Lally updated UIMA-187: Summary: getSofaDataString() is documented in the manual but does not exist in the code (was: getSofaDataStr

Re: Build scripts

2007-01-12 Thread Marshall Schor
Thilo Goetz wrote: Err, IBM Java 5, now you mention it, I'm not sure I ever fixed that. Let me check... It's still broken - issue is some test depends on ordering of items gotten from a hashmap. It's broken when running with IBM Java 5.0. Works with Sun 5.0 according to Adam -Marshall

build pblms on Macs

2007-01-12 Thread Marshall Schor
I borrowed a Mac to do some testing. Setup Eclipse 3.2.1, with EMF and Subclipse SVN client. Checked out the code, installed maven 2 Did the maven setup for eclipse, etc. The build almost worked, but got one test failure. Building with the tests bypassed completed with no apparent error. H