Re: Unit Test Failures on Java 5

2006-11-07 Thread Adam Lally
We have to get patches working in any case. Do attachments work? That was the first thing I tried, but attachments don't seem to be allowed on the list. Next I tried just pasting the patchfile contents into an email, but Thilo reported getting errors when trying to apply the patch. (When I th

Re: Unit Test Failures on Java 5

2006-11-07 Thread Marshall Schor
We have to get patches working in any case. Do attachments work? -Marshall Thilo Goetz wrote: Let's wait another day for your SVN accounts. uuencode really takes me way back to the early 90s. I had no idea it still existed ;-) If for some reason your SVN accounts fail to be set up tomorro

Re: Unit Test Failures on Java 5

2006-11-07 Thread Thilo Goetz
Adam Lally wrote: One failure is a test that uses xi:include, which doesn't work in Java 1.5. I removed most of those from our tests but a couple are left. Is it time to just remove this feature entirely? In addition to not working in Java 1.5 (unless you separately install xalan.jar), it's als

Re: Unit Test Failures on Java 5

2006-11-07 Thread Adam Lally
On 11/7/06, Michael Baessler <[EMAIL PROTECTED]> wrote: +1 from my side, I also think that we can drop xi:include. - Michael I should probably clarify that my patch doesn't remove xi:include support for UIMA; it only modifies the testcase to use import instead. The actual removal can be done l

Re: Unit Test Failures on Java 5

2006-11-07 Thread Michael Baessler
+1 from my side, I also think that we can drop xi:include. - Michael Thilo Goetz wrote: +1 We have had for a long time now as our standard include mechanism, let's just drop xi:include. We also have one more test case failing with the IBM JDK 1.5 that I'm working on, somehow other stuff k

Re: Unit Test Failures on Java 5

2006-11-07 Thread Adam Lally
One failure is a test that uses xi:include, which doesn't work in Java 1.5. I removed most of those from our tests but a couple are left. Is it time to just remove this feature entirely? In addition to not working in Java 1.5 (unless you separately install xalan.jar), it's also not supported in

Re: Unit Test Failures on Java 5

2006-11-06 Thread Thilo Goetz
+1 We have had for a long time now as our standard include mechanism, let's just drop xi:include. We also have one more test case failing with the IBM JDK 1.5 that I'm working on, somehow other stuff keeps intervening. (It's one of the IteratorTest test cases). --Thilo Marshall Schor wr

Re: Unit Test Failures on Java 5

2006-11-06 Thread Marshall Schor
Re removing xi:include - +1 from me. Adam Lally wrote:

Unit Test Failures on Java 5

2006-11-06 Thread Adam Lally
Since there's no JIRA yet issues get logged to the dev list. :) I'm getting two failures running the tests under Sun Java 1.5. One failure is a test that uses xi:include, which doesn't work in Java 1.5. I removed most of those from our tests but a couple are left. Is it time to just remove this