Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-11-20 Thread Kostas Kloudas
Hi Hector, The main reasons for deprecating the readFileStream() was that: 1) it was only capable of parsing Strings and in a rather limited way as one could not even specify the encoding 2) it was not fault-tolerant, so your concerns about exactly-once were not covered One concern that I can fin

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-11-16 Thread Hector He
May I have a ask about deprecating readFileStream(...), is there a alternative to this method? Source code lead me to use readFile instead, but it does not perform as readFileStream, readFileStream can reads file content incrementally, but readFile with FileProcessingMode.PROCESS_CONTINUOUSLY argum

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-25 Thread Konstantin Knauf
vailable in ProcessFunctions, but not available to other >>> commonly used UDF like Source or AsyncFunction[1]. >>> >>> One temporary solution occurs to me is to add a ProcessFunction after >>> the operators want to use side-output. But I think the solution i

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-20 Thread Stephan Ewen
ct to come up with and if it really works we might add it to the >> document of side-output. >> >> [1] https://issues.apache.org/jira/browse/FLINK-7954 >> >> Best, >> Yun >> >> --Original Mail -- >&

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-19 Thread Dawid Wysakowicz
ache.org>> > *CC:*dev mailto:d...@flink.apache.org>>, > user mailto:user@flink.apache.org>> > *Subject:*Re: [DISCUSS] Removing deprecated methods from > DataStream API > > +1 for removing them. > > > >

Re: Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-18 Thread Till Rohrmann
.apache.org/jira/browse/FLINK-7954 > > Best, > Yun > > --Original Mail -- > *Sender:*Kostas Kloudas > *Send Date:*Tue Aug 18 03:52:44 2020 > *Recipients:*Dawid Wysakowicz > *CC:*dev , user > *Subject:*Re: [DISCUSS] Removing deprecated methods from Data

Re: Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread Yun Gao
side-output. [1] https://issues.apache.org/jira/browse/FLINK-7954 Best, Yun --Original Mail -- Sender:Kostas Kloudas Send Date:Tue Aug 18 03:52:44 2020 Recipients:Dawid Wysakowicz CC:dev , user Subject:Re: [DISCUSS] Removing deprecated methods from DataStream

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread Kostas Kloudas
+1 for removing them. >From a quick look, most of them (not all) have been deprecated a long time ago. Cheers, Kostas On Mon, Aug 17, 2020 at 9:37 PM Dawid Wysakowicz wrote: > > @David Yes, my idea was to remove any use of fold method and all related > classes including WindowedStream#fold > >

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread Dawid Wysakowicz
@David Yes, my idea was to remove any use of fold method and all related classes including WindowedStream#fold @Klou Good idea to also remove the deprecated enableCheckpointing() & StreamExecutionEnvironment#readFile and alike. I did another pass over some of the classes and thought we could also

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread David Anderson
I assume that along with DataStream#fold you would also remove WindowedStream#fold. I'm in favor of going ahead with all of these. David On Mon, Aug 17, 2020 at 10:53 AM Dawid Wysakowicz wrote: > Hi devs and users, > > I wanted to ask you what do you think about removing some of the > deprecat

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread Kostas Kloudas
Thanks a lot for starting this Dawid, Big +1 for the proposed clean-up, and I would also add the deprecated methods of the StreamExecutionEnvironment like: enableCheckpointing(long interval, CheckpointingMode mode, boolean force) enableCheckpointing() isForceCheckpointing() readFile(FileInputFor

[DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread Dawid Wysakowicz
Hi devs and users, I wanted to ask you what do you think about removing some of the deprecated APIs around the DataStream API. The APIs I have in mind are: * RuntimeContext#getAllAccumulators (deprecated in 0.10) * DataStream#fold and all related classes and methods such as FoldFunction,