Re: Custom Prometheus metrics disappeared in 1.16.2 => 1.17.1 upgrade

2023-12-04 Thread Javier Vegas
Reason is simple, I migrated to Flink a project that already had Prometheus metrics integrated. Thanks, Javier El mar, 3 oct 2023 a las 15:51, Mason Chen () escribió: > > Hi Javier, > > Is there a particular reason why you aren't leveraging Flink metric API? It > seems that functionality was

Re: Custom Prometheus metrics disappeared in 1.16.2 => 1.17.1 upgrade

2023-10-03 Thread Mason Chen
Hi Javier, Is there a particular reason why you aren't leveraging Flink metric API? It seems that functionality was internal to the PrometheusReporter implementation and your usecase should've continued working if it had depended on Flink's metric API. Best, Mason On Thu, Sep 28, 2023 at 2:51 

Re: Custom Prometheus metrics disappeared in 1.16.2 => 1.17.1 upgrade

2023-09-28 Thread Javier Vegas
Thanks! I saw the first change but missed the third one, that is the most that most probably explains my problem, most probably the metrics I was sending with the twitter/finagle statsReceiver ended up in the singleton default registry and were exposed by Flink with all the other Flink metrics,

Re: Custom Prometheus metrics disappeared in 1.16.2 => 1.17.1 upgrade

2023-09-27 Thread Kenan Kılıçtepe
Have you checked the metric changes in 1.17. >From release notes 1.17: https://nightlies.apache.org/flink/flink-docs-master/release-notes/flink-1.17/ Metric Reporters # Only support reporter factories for instantiation # FLINK-24235 # Configuring reporters by their class is no longer supported.

Re: Custom Prometheus metrics disappeared in 1.16.2 => 1.17.1 upgrade

2023-09-27 Thread Javier Vegas
Some more details on my problem: 1. The "Multiple implementations" problem was because I had the metrics-prometheus jar both in the plugins and lib directories. I tried putting it in only one, and in both cases (plugins or lib), the result was the same, I got only Flink metrics on my prom port.

Custom Prometheus metrics disappeared in 1.16.2 => 1.17.1 upgrade

2023-09-26 Thread Javier Vegas
I implemented some custom Prometheus metrics that were working on 1.16.2, with my configuration metrics.reporter.prom.factory.class: org.apache.flink.metrics.prometheus.PrometheusReporterFactory metrics.reporter.prom.port: I could see both Flink metrics and my custom metrics on port of