On 25 September 2012 22:42, Paolo Castagna wrote:
> I am still trying to find out what could have possibly gone wrong...
Ok, I found it, but I do not understand.
Here is what happened...
public class PageRankVertex extends EdgeListVertex {
[...]
@Override
publi
Hi Jaeho,
ok, I guess it makes sense. Better to do these changes sooner than later.
Thanks,
Paolo
On 25 September 2012 22:02, Jaeho Shin wrote:
> Avery is correct.
>
> The user class extending them should be an innerclass of the enclosing
> TextVertexInputFormat anyway, so marking them protecte
Hi Avery,
I had a few *Vertex{Reader|Writer} which were not inner classes.
Users might need to go through a few changes to upgrade to current
Giraph, for example:
https://github.com/castagna/jena-grande/commit/e8decab8f93ec50db6dc9de9cca026c03c74887f
They are trivial changes, however... something
Avery is correct.
The user class extending them should be an innerclass of the enclosing
TextVertexInputFormat anyway, so marking them protected makes sense.
Regarding the reason for switching to an innerclass, there was virtually no
reuse of the TextVertexReader class by a different TextVertex
Hi Paolo,
The idea is to allow them to be used by subclassing only (I think).
Jaeho did this work. Any reason you don't want it protected?
On 9/25/12 12:51 PM, Paolo Castagna wrote:
Hi,
why TextVertexReaderFromEachLine and TextVertexReader are protected?
The Javadoc comments seem to assume
Hi,
why TextVertexReaderFromEachLine and TextVertexReader are protected?
The Javadoc comments seem to assume users should be allowed to extend those.
Paolo
Thanks for the reply, Sebastian.
The problem I'm working on is a routing algorithm for a country wide
railway network. I was thinking about two ways to approach it.
1. Pre calculate the routes. I understand that this is quadratic, but I was
thinking of using some optimizations to limit the calcul
