guacamole broken on Safari

Hi there! Current stable version (1.3.0) lacks the support of oidc logout event, so I’ve used the latest version from master branch. Suddenly got black screen from Safari, when connecting via VNC, and broken Ctrl+Alt+Shift menu. Is it by design or really broken? Cheers, Leo --

Re: guacamole broken on Safari

On Mon, Jul 26, 2021 at 1:09 PM Leo Nikolaev wrote: > Hi there! > > Current stable version (1.3.0) lacks the support of oidc logout event, so > I’ve used the latest version from master branch. > > Suddenly got black screen from Safari, when connecting via VNC, and broken > Ctrl+Alt+Shift menu. >

Re: guacamole broken on Safari

So, here is the setup: - macOS 11.2.3 - Safari 14.0.3 Broken is like this - empty black screen https://pasteboard.co/Kd0Fh0l.png When I press Ctrl+Alt+Shift I see menu not fully opened https://pasteboard.co/Kd0Fybr.png If I press ESC, it opens completely. Percentage at the bottom of the menu i

Re: guacamole broken on Safari

Mike, any update on this? Maybe create JIRA ticket? Cheers, Leo > On 26 Jul 2021, at 23:49, Mike Jumper wrote: > > On Mon, Jul 26, 2021 at 1:09 PM Leo Nikolaev wrote: > Hi there! > > Current stable version (1.3.0) lacks the support of oidc logout event, so > I’ve used the latest version from

Re: guacamole broken on Safari

No, testing this myself, I'm not able to reproduce the behavior. Things work absolutely perfectly for me on Safari on Mac OS with a build from current git. Are there any other details you can provide that might be unique? Are you sure you are building the latest? - Mike On Wed, Jul 28, 2021, 03

Re: guacamole broken on Safari

If comfortable, I can record a screencast or do a Zoom demo of what am I doing. I’m absolutely sure about latest master - I mount it inside Docker-container, and when I remove -v parameter it all works perfectly on 1.3.0. docker run --name guacamole \ --link guacd \ --link mysql \ -v $(pwd

Re: guacamole broken on Safari

On Wed, Jul 28, 2021 at 3:36 AM Leo Nikolaev wrote: > If comfortable, I can record a screencast or do a Zoom demo of what am I > doing. > > I’m absolutely sure about latest master - I mount it inside > Docker-container, and when I remove -v parameter it all works perfectly on > 1.3.0. > > docker

Re: guacamole broken on Safari

No luck, the behaviour is absolutely the same. Any ideas? Chrome is working like a charm :( Cheers, Leo > On 30 Jul 2021, at 04:00, Mike Jumper wrote: > > On Wed, Jul 28, 2021 at 3:36 AM Leo Nikolaev wrote: > If comfortable, I can record a screencast or do a Zoom demo of what am I > doing. >

Re: guacamole broken on Safari

Okay, I’ve done some triaging by building and checking manually some commits. Commit 037ed21 is definetely okay, and it even has the logout support, so fits perfectly. There is a bunch of commits at 8th of July then, and the last of them, dd86130 is completely broken. Commit cc239b6e has the b

Re: guacamole broken on Safari

Is this from a git bisect? - Mike On Mon, Aug 2, 2021, 13:59 Leo Nikolaev wrote: > Okay, I’ve done some triaging by building and checking manually some > commits. > > Commit 037ed21 is definetely okay, and it even has the logout support, so > fits perfectly. > > There is a bunch of commits at 8

Re: guacamole broken on Safari

Erm, I can’t do bisect, I just build it and check manually :) Btw, I am using OIDC auth via Keycloak, but I’m sure it's not the reason. > On 3 Aug 2021, at 00:04, Mike Jumper wrote: > > Is this from a git bisect? > > - Mike > > On Mon, Aug 2, 2021, 13:59 Leo Nikolaev wrote: > Okay, I’ve done

Re: guacamole broken on Safari

On Mon, Aug 2, 2021, 14:07 Leo Nikolaev wrote: > Erm, I can’t do bisect, I just build it and check manually :) > Bisect will save you a *ton* of time while reducing the number of checks. You'll be able to cover the full relevant span of commits in O(log n). Btw, I am using OIDC auth via Keycloa

Re: guacamole broken on Safari

So, now I have a very nasty bug: some commits do fail to even show the login page of Guacamole with some weird MySQL error: ### The error may exist in org/apache/guacamole/auth/jdbc/user/UserMapper.xml ### The error may involve defaultParameterMap ### The error occurred while setting parameters #

Re: guacamole broken on Safari

Yes, it was a regression introduced during development of GUACAMOLE-641 and was subsequently fixed. If you run into an issue that prevents testing entirely (can't build, can't login, etc.), the best way to move beyond that would be to skip that commit with "git bisect skip" so that git knows that

Re: guacamole broken on Safari

Ha, I found an interesting issue about the bug. If you run a working guacamole, it puts something in your Safari’s browser cache to keep it working, even if future builds have a bug. Cleaning up the cache fires up a bug. I’m still bisecting it, but I’m close. Cheers, Leo > On 3 Aug 2021, at 23

Re: guacamole broken on Safari

On Wed, Aug 4, 2021 at 1:36 AM Leo Nikolaev wrote: > Ha, I found an interesting issue about the bug. > > If you run a working guacamole, it puts something in your Safari’s browser > cache to keep it working, even if future builds have a bug. Cleaning up the > cache fires up a bug. I’m still bisec

Re: guacamole broken on Safari

Okay, I found it. Safari bug is in the GUACAMOLE-724 series of commits. Broken commit: c2b2522 - GUACAMOLE-724: Correct rendering of tiled clients on IE10+ by migrating to grid layout. Last working commit: 09288b7 Steps to reproduce: 1. Checkout commit: git checkout c2b2522 2. Cherry-pick fi

Re: guacamole broken on Safari

On Wed, Aug 4, 2021, 13:33 Leo Nikolaev wrote: > Okay, I found it. > > Safari bug is in the GUACAMOLE-724 series of commits. > Broken commit: c2b2522 - GUACAMOLE-724: Correct rendering of tiled clients > on IE10+ by migrating to grid layout. > Unfortunately, I believe the code from that commit h

Re: guacamole broken on Safari

I do need cherry-pick to fix regression from 641, you’ve told me that; I’ve found it fixed on 037ed212 and put it on. Without it Guacamole fails to even show me a login form, complaining about MySQL syntax errors. Cheers, Leo > On 4 Aug 2021, at 23:45, Mike Jumper wrote: > > On Wed, Aug 4, 20

Re: guacamole broken on Safari

Ah, OK. On Wed, Aug 4, 2021, 13:48 Leo Nikolaev wrote: > I do need cherry-pick to fix regression from 641, you’ve told me that; > I’ve found it fixed on 037ed212 and put it on. Without it Guacamole fails > to even show me a login form, complaining about MySQL syntax errors. > > Cheers, > Leo > >

Re: guacamole broken on Safari

Well, so far no luck reproducing what you're seeing, but perhaps my test setup is too up-to-date: macOS 11.5 Safari 14.1.2 I'll try again and, failing that, see if there's some way to duplicate your exact setup down to the version. Michael Jumper CEO, Lead Developer Glyptodon Inc

Re: guacamole broken on Safari

Okay, I’ve done some investigations :) First of all, as soon as we see cache-dependency, the problem should not be with .js-code, it’s recompiled, but as far as I can see Angular uses caching. The problem looks like a result of a change in file guacTiledClients.html. There was a line: ng-style=

Re: guacamole broken on Safari

Mike, any update on this? Looks like a CSS bug in tile grid :) Cheers, Leo > On 6 Aug 2021, at 10:42, Leo Nikolaev wrote: > > Okay, I’ve done some investigations :) > > First of all, as soon as we see cache-dependency, the problem should not be > with .js-code, it’s recompiled, but as far as

Re: guacamole broken on Safari

Nope, not as of yet. Based on what you're seeing, it sounds like a CSS issue, yes, but not an issue with grid layout. The code that you're running across as the cause was only an intermediate attempt during development and actually isn't present any longer. The layout was migrated to flexbox prior

Re: guacamole broken on Safari

You mean I should not see this issue on latest master? Is there a different code there? Cheers, Leo > On 12 Aug 2021, at 00:46, Mike Jumper wrote: > > Nope, not as of yet. Based on what you're seeing, it sounds like a CSS issue, > yes, but not an issue with grid layout. The code that you're r

Re: guacamole broken on Safari

On Wed, Aug 11, 2021 at 2:52 PM Leo Nikolaev wrote: > You mean I should not see this issue on latest master? Is there a > different code there? > The code on master should be the same code that you bisected - it just happens that code from the specific commit that you found through the bisect wa

Re: guacamole broken on Safari

Okay, I think this could be closed. I’ve done the tests, only the old versions of Safari are affected: 14.0 and below. As long as we have a relatively small share of old Safafi browsers. Btw, I’ve tracked down the bug in current master, it all comes to wrong heigth, which is not firing from som

Re: guacamole broken on Safari

OK - after installing a copy of OS X "Catalina" within VirtualBox, I'm now able to reproduce this on the included older version of Safari. I'll start digging into what CSS changes are needed to un-break older Safaris. Michael Jumper CEO, Lead Developer Glyptodon Inc . On Fri, A

Re: guacamole broken on Safari

This should now be fixed via https://github.com/apache/guacamole-client/pull/639. The issue was that an old CSS class, "tiled-client-list", was replaced with a corresponding directive, "guac-tiled-clients" via commit c990043, but the style rule that referenced "tiled-client-list" was not updated ac