Re: [Neo] NeoServiceLifecycle in OSGi

2009-08-26 Thread Mattias Persson
2009/8/26 Andreas Kollegger : > Hi Mattias, > > Thanks for the class. I had started to code up a similar approach when > it occurred to me > that I should first look whether an implementation existed. > > I also would prefer renaming the current implementation to > NeoServiceLifecycleImpl and > add

Re: [Neo] NeoServiceLifecycle in OSGi

2009-08-26 Thread Andreas Kollegger
Hi Mattias, Thanks for the class. I had started to code up a similar approach when it occurred to me that I should first look whether an implementation existed. I also would prefer renaming the current implementation to NeoServiceLifecycleImpl and adding the interface, but am reluctant to cha

Re: [Neo] NeoServiceLifecycle in OSGi

2009-08-26 Thread Mattias Persson
Hi Andreas, sorry for my non-OSGi skills (the author of this class). I'd vote for something else, rather than INeoServiceLifecycle since, as you pointed out, it'd go against the neo4j conventions. Maybe have the interface named NeoServiceLifecycle and the implementation be named NeoServiceLifecyc

[Neo] NeoServiceLifecycle in OSGi

2009-08-25 Thread Andreas Kollegger
Hi all, To make NeoServiceLifecycle a bit more digestible in OSGi environments, I'd like to refactor the class into an interface/ implementation pair. To avoid breaking current use of the class, I propose to add an interface above NeoServiceLifecycle which matches the public methods and the