Re: No service to get party postal address

Thanks Abdullah, Your patch is in trunk at r816944. Jacques From: "Abdullah Shaikh" yes :) The only thing I started this conversation was because there were services to get party telephone & email, but no service to get the party's postaladdress. And I submitted the patch for the getPartyPos

Re: No service to get party postal address

yes :) The only thing I started this conversation was because there were services to get party telephone & email, but no service to get the party's postaladdress. And I submitted the patch for the getPartyPostalAddress service. When there was a mention of ContactMechWorker methods (getPartyPosta

Re: No service to get party postal address

OK, back to beginning :o) Jacques From: "Scott Gray" Hmm those methods do look a little bit out of the ordinary, perhaps it might be better to just implement the service from scratch. Just be sure to follow the same patterns as used by the other ContactMech services. Regards Scott On

Re: No service to get party postal address

Hi Scott, Abdullah, Sorry I was busy ans did not read well Abdullah's message. Why would we neet to change worker methods (there are 2 related methods there) ? In my mind we would simply call the simple method (as a service) from worker methods. Replacing/modifying the Java code by a sync ser

Re: No service to get party postal address

Hmm those methods do look a little bit out of the ordinary, perhaps it might be better to just implement the service from scratch. Just be sure to follow the same patterns as used by the other ContactMech services. Regards Scott On 19/09/2009, at 12:57 AM, Abdullah Shaikh wrote: Yes, ini

Re: No service to get party postal address

Yes, initially I thought of that, i.e. to wrap the worker method by service, but both the methods expects ServletRequest object as the parameter. Regarding moving the code to the service, there is another issue, the getPartyPostalAddresses returns contactMech, partyContactMech & partyContactMechPu

Re: No service to get party postal address

Yes, initially I thought of that, i.e. to wrap the worker method by service, but both the methods expects ServletRequest object as the parameter. Regarding moving the code to the service, there is another issue, the getPartyPostalAddresses returns contactMech, partyContactMech & partyContactMechPu

Re: No service to get party postal address

+1 for using service to wrap the worker method. -- Thanks & Regards Mridul Pathak Hotwax Media http://www.hotwaxmedia.com mridul.pat...@hotwaxmedia.com - direct: +91 - 942.592.6892 On Fri, Sep 18, 2009 at 6:00 PM, Scott Gray wrote: > I wouldn't att

Re: No service to get party postal address

I wouldn't attempt to call the service from the worker method, doing so would require that the be signature changed which means you have to deprecate the existing method and create a new one (which is a bit pointless because callers might as well call the service themselves). I would eithe

Re: No service to get party postal address

cool I will do that it's more clear now On Fri, Sep 18, 2009 at 2:41 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > From: "Abdullah Shaikh" > >> I got confused. You meant that you will commit the already provided patch >> ?. >> > > It was really a cursory review and I must I d

Re: No service to get party postal address

From: "Abdullah Shaikh" I got confused. You meant that you will commit the already provided patch ?. It was really a cursory review and I must I did not thought about generalising. I was having ContactMechWorker.getCurrentPostalAddress & ContactMechWorker.getPartyPostalAddresses, in my mind,

Re: No service to get party postal address

I got confused. You meant that you will commit the already provided patch ?. I was having ContactMechWorker.getCurrentPostalAddress & ContactMechWorker.getPartyPostalAddresses, in my mind, what I was thinking was that to make the getPartyPostalAddress service in java by taking the code out of the

Re: No service to get party postal address

Hi Jacques, I will provide the patch as discussed. Just to be sure, what I need to do is : 1) Create a service to get party postaladdress (getPartyPostalAddress) 2) Call this service from the ContactMechWorker.getCurrentPostalAddress & ContactMechWorker.getPartyPostalAddresses The patch that I

Re: No service to get party postal address

Hi Abdullah, I had a quick look and it seems good. I will commit I guess. Thanks (and thank you to Sumit for the link and 1st review) Jacques From: "Abdullah Shaikh" I feel that we should have this service, 1) To get party's data, either we should have all the code in a class or all should

Re: No service to get party postal address

I do not see any harm in adding a service if this is ultimately used and I see a scope of usage in various scripts written for profile and other pages. Vikas On Sep 18, 2009, at 2:54 AM, Jacques Le Roux wrote: There are ContactMechWorker.getCurrentPostalAddress ContactMechWorker.getPartyPo

Re: No service to get party postal address

I feel that we should have this service, 1) To get party's data, either we should have all the code in a class or all should be exposed as a service, to avoid confusion. Right now, it's partially from the service (i.e. email & telephone) and partially from the ContactMechWorker class. All should b

Re: No service to get party postal address

Hi Jacques, Abdullah has created a jira issue for that - https://issues.apache.org/jira/browse/OFBIZ-2954 Please close if it is not needed. -- Thanks and Regards Sumit Pandit On 18-Sep-09, at 2:54 AM, Jacques Le Roux wrote: There are ContactMechWorker.getCurrentPostalAddress ContactMechWorke

Re: No service to get party postal address

There are ContactMechWorker.getCurrentPostalAddress ContactMechWorker.getPartyPostalAddresses But yes no services, maybe because it's not needed ? Jacques From: "Abdullah Shaikh" There are services to get the party telephone & email, getPartyTelephone & getPartyEmail respectively, but no ser

No service to get party postal address

There are services to get the party telephone & email, getPartyTelephone & getPartyEmail respectively, but no service to get the party postal address. I can submit a patch for getPartyPostalAddress service, to get the party's postal address. What do you think ?