Am 04.06.2012 23:17, schrieb Alan Cox:
>> On all other ttys login works but bash dies because of of -EIO.
>> After vhangup() the tty returns -EIO upon read()/write().
>
> You can't re-open the tty because a process is holding on to it, not
> closing it and not killable. Fedora shouldn't
> On all other ttys login works but bash dies because of of -EIO.
> After vhangup() the tty returns -EIO upon read()/write().
You can't re-open the tty because a process is holding on to it, not
closing it and not killable. Fedora shouldn't be holding these devices
open this way. The b
On 06/04/2012 10:27 PM, Richard Weinberger wrote:
> +void line_cleanup(struct tty_struct *tty)
> +{
> + struct line *line = tty->driver_data;
>
> if (line->sigio) {
> unregister_winch(tty);
> line->sigio = 0;
r u sure you want to to do this asynchronously? T
From: Jiri Slaby
This means switching to the tty refcounted model so that we will not
race with interrupts.
Signed-off-by: Jiri Slaby
Cc: Jeff Dike
Cc: Richard Weinberger
Cc: user-mode-linux-devel@lists.sourceforge.net
Signed-off-by: Richard Weinberger
---
arch/um/drivers/chan_kern.c |4
this lock is no longer needed.
Signed-off-by: Richard Weinberger
---
arch/um/drivers/line.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
index 95d5e78..555ccfc 100644
--- a/arch/um/drivers/line.c
+++ b/arch/um/drive
From: Jiri Slaby
And use count from there.
Signed-off-by: Jiri Slaby
Cc: Jeff Dike
Cc: Richard Weinberger
Cc: user-mode-linux-devel@lists.sourceforge.net
Signed-off-by: Richard Weinberger
---
arch/um/drivers/line.c |7 ---
arch/um/drivers/line.h |2 +-
2 files changed, 5 inserti
Signed-off-by: Richard Weinberger
---
arch/um/drivers/ssl.c | 26 --
1 files changed, 0 insertions(+), 26 deletions(-)
diff --git a/arch/um/drivers/ssl.c b/arch/um/drivers/ssl.c
index a39d53e..cba95d9 100644
--- a/arch/um/drivers/ssl.c
+++ b/arch/um/drivers/ssl.c
@@ -98
This patch set moves the UML console driver to the new TTY port interface.
It does ref counting and uses the tty_port_*-helpers.
Please note, it's not yet UML mconsole safe!
Anyway, I see some really strange things and I'm not sure whether my patch
is sane or not...
If I implement tty_operations-
line_ioctl() has no real function.
Signed-off-by: Richard Weinberger
---
arch/um/drivers/line.c | 86 ---
arch/um/drivers/line.h |2 -
arch/um/drivers/ssl.c |1 -
arch/um/drivers/stdio_console.c |1 -
4 files changed,
... use all tty_port helpers
Signed-off-by: Richard Weinberger
---
arch/um/drivers/line.c | 102 +--
arch/um/drivers/line.h |6 ++-
arch/um/drivers/ssl.c | 15 ++
arch/um/drivers/stdio_console.c | 20
4 files c
On 06/04/2012 08:05 PM, Richard Weinberger wrote:
> Am 04.06.2012 18:55, schrieb Boaz Harrosh:
>> No still crashing the same, way. BTW I do not have a systemd Distro. It's
>> plain old FC12. Though in the lab I have the same crash with FC15.
>>
>> The crash is immediately after I login at the init
Am 04.06.2012 18:55, schrieb Boaz Harrosh:
> No still crashing the same, way. BTW I do not have a systemd Distro. It's
> plain old FC12. Though in the lab I have the same crash with FC15.
>
> The crash is immediately after I login at the initial prompt. (every time)
Okay, I'll test my patches wit
On 06/04/2012 07:29 PM, Richard Weinberger wrote:
> Am 04.06.2012 18:27, schrieb Boaz Harrosh:
>> On 06/04/2012 06:42 PM, Richard Weinberger wrote:
>>
>>> Am 04.06.2012 17:41, schrieb Jiri Slaby:
Hmm, I remember. I suggest you to split the patch into several pieces.
For example moving th
On 06/04/2012 07:29 PM, Richard Weinberger wrote:
> Am 04.06.2012 18:27, schrieb Boaz Harrosh:
>> On 06/04/2012 06:42 PM, Richard Weinberger wrote:
>>
>>> Am 04.06.2012 17:41, schrieb Jiri Slaby:
Hmm, I remember. I suggest you to split the patch into several pieces.
For example moving th
Am 04.06.2012 18:27, schrieb Boaz Harrosh:
> On 06/04/2012 06:42 PM, Richard Weinberger wrote:
>
>> Am 04.06.2012 17:41, schrieb Jiri Slaby:
>>> Hmm, I remember. I suggest you to split the patch into several pieces.
>>> For example moving the code from ->open into ->install can be done
>>> separat
On 06/04/2012 06:42 PM, Richard Weinberger wrote:
> Am 04.06.2012 17:41, schrieb Jiri Slaby:
>> Hmm, I remember. I suggest you to split the patch into several pieces.
>> For example moving the code from ->open into ->install can be done
>> separately. Otherwise it's hard to tell what's wrong with
> Two days ago I did so but still faced the problems described here:
> https://lkml.org/lkml/2012/3/10/163
If you are running a Fedora like distro it's because the user space is
broken. At some point we are going to have to make them fix the userspace
not to sit with ttys held open.
Alan
--
Am 04.06.2012 17:41, schrieb Jiri Slaby:
> Hmm, I remember. I suggest you to split the patch into several pieces.
> For example moving the code from ->open into ->install can be done
> separately. Otherwise it's hard to tell what's wrong with the patch as
> a whole.
>
> Also, it would be good to s
On 06/04/2012 05:29 PM, Richard Weinberger wrote:
> It looks like that it solves UML's TTY issues with systemd distros.
> :-)
Good.
>> So the switch of the driver to the new tty port API, as suggested
>> by Alan, is still needed. I might do that later if I learn how to
>> make UML work. (The conv
Hi!
Am 04.06.2012 17:20, schrieb Jiri Slaby:
> On 06/04/2012 02:01 PM, Richard Weinberger wrote:
>> I have two questions: 1. Are these patches also usable on 3.4 and
>> 3.3 or do they depend on 3.5's TTY changes?
>
> Hi, I don't think they depend on any changes.
Nice.
>> 2. Why didn't you use t
On 06/04/2012 02:01 PM, Richard Weinberger wrote:
> I have two questions: 1. Are these patches also usable on 3.4 and
> 3.3 or do they depend on 3.5's TTY changes?
Hi, I don't think they depend on any changes.
> 2. Why didn't you use tty_port_open()/close()/etc. as Alan
> suggested my in [1]?
Th
Jiri,
Thanks a lot for fixing this!
I have two questions:
1. Are these patches also usable on 3.4 and 3.3 or do they depend on 3.5's TTY
changes?
2. Why didn't you use tty_port_open()/close()/etc. as Alan suggested my in [1]?
Thanks,
//richard
[1] http://lkml.indiana.edu/hypermail/linux/kernel
This means switching to the tty refcounted model so that we will not
race with interrupts.
Signed-off-by: Jiri Slaby
Cc: Jeff Dike
Cc: Richard Weinberger
Cc: user-mode-linux-devel@lists.sourceforge.net
---
arch/um/drivers/chan_kern.c |4 +++-
arch/um/drivers/line.c | 25
And use count from there.
Signed-off-by: Jiri Slaby
Cc: Jeff Dike
Cc: Richard Weinberger
Cc: user-mode-linux-devel@lists.sourceforge.net
---
arch/um/drivers/line.c |7 ---
arch/um/drivers/line.h |2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/um/drivers/l
24 matches
Mail list logo
