Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-09 Thread Sangchoei, Yuttana
Hi All, I'm upgrading Camel from 3.16 to 3.17 and found a problem that OffsetRepository didn't get update after manual commit. It is a Spring boot project and MemoryStateRepository as follows. @Bean public MemoryStateRepository offsetRepo() { MemoryStateRepository

Re: Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-09 Thread Claus Ibsen
Hi I am not sure, there are some improvements and refactorings going on in camel-kafka and offset management. I think Otavio would be better to help look into this. On Wed, Nov 9, 2022 at 11:36 AM Sangchoei, Yuttana wrote: > Hi All, > > I'm upgrading Camel from 3.16 to 3.17 and found a problem

Re: Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-09 Thread Otavio Rodolfo Piske
Hi, before I go ahead and investigate this further ... Could you possibly try with Camel 3.18.3? We have made a bunch of fixes for Kafka in 3.18.3. Kind regards On Wed, Nov 9, 2022 at 3:56 PM Claus Ibsen wrote: > Hi > > I am not sure, there are some improvements and refactorings going on in > c

RE: Re: Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-11 Thread Sangchoei, Yuttana
Hi Otavio, Claus, Thank you very much for your hands. I tried upgrading to 3.18.3. I didn't increase the offset. Best regards, Yuttana On 2022/11/10 06:36:08 Otavio Rodolfo Piske wrote: > Hi, before I go ahead and investigate this further ... Could you > possibly try with Camel 3.18.3? We have

RE: Re: Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-11 Thread Yuttana Sangchoei
Hi Otavio, Claus, Thank you very much for your hands. I tried 3.18.3. It didn’t increase the offset. Best regards, Yuttana On 2022/11/10 06:36:08 Otavio Rodolfo Piske wrote: > Hi, before I go ahead and investigate this further ... Could you possibly > try with Camel 3.18.3? We have made a bunc

RE: Re: Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-11 Thread Sangchoei, Yuttana
Hi Otavio, Clays, Thank you very much for your hands. I tried 3.18.3. It didn't increase the offset. Best regards, Yuttana On 2022/11/10 06:36:08 Otavio Rodolfo Piske wrote: > Hi, before I go ahead and investigate this further ... Could you possibly > try with Camel 3.18.3? We have made a bun

Re: Re: Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-12 Thread Otavio Rodolfo Piske
Thanks. I can't confirm whether it's an user error, bug or anything else, but I created a ticket so I can investigate this: https://issues.apache.org/jira/browse/CAMEL-18717 I also can't provide an ETA yet, as I have a busy week ahead, but I'll keep it on my radar. In the meantime, please do feel

RE: Re: Re: Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-16 Thread Yuttana Sangchoei
Hi Otavio, Thank you for creating the ticket. I found where the problem might be in 3.18.3. At CommitManager in createCommitManager static method, there are some check starting by checking if isAllowManualCommit, if so it continues checking the type of manualCommitFactory. However, if not, it c

Re: Re: Re: Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-19 Thread Otavio Rodolfo Piske
Hi, I am glad that you managed to adjust it to work the way you need. "In my opinion, the offset repository should be used in case we define it in the Kafka endpoint no matter if it is AsyncCommitManager, SyncCommitManager or NoopCommitManager. I’m not so sure if my thought is correct. Could you

Re: Re: Re: Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-21 Thread Otavio Rodolfo Piske
Hi, After reviewing the code, I think that it is, indeed, a bug. As such, I created a PR which should solve the problem: https://github.com/apache/camel/pull/8746. This is a patch for the upcoming 3.20.0. I would kindly appreciate it if you could give a try with this version of Camel, so I can s

RE: Re: Re: Offset in OffsetRepositoy doesn't get increase after manual commit

2022-11-22 Thread Sangchoei, Yuttana
) Zhang ( Ray ) Subject: Re: Re: Re: Offset in OffsetRepositoy doesn't get increase after manual commit Hi, After reviewing the code, I think that it is, indeed, a bug. As such, I created a PR which should solve the problem: https://github.com/apache/camel/pull/8746. This is a patch fo