Re: Riding on org.apache.camel.language.TokenPairPredicateTest

2011-12-07 Thread Claus Ibsen
On Wed, Dec 7, 2011 at 9:41 AM, bvahdat wrote: > Good morning Claus, > > If you would go through all of my posts in this thread and read them > carefully you will realize that my concern was *not* the failed unit test at > all but the *behaviour* of the file consumer. Nevertheless if you still wan

Re: Riding on org.apache.camel.language.TokenPairPredicateTest

2011-12-07 Thread bvahdat
Good morning Claus, If you would go through all of my posts in this thread and read them carefully you will realize that my concern was *not* the failed unit test at all but the *behaviour* of the file consumer. Nevertheless if you still want it to be in that way I would be more than happy to do t

Re: Riding on org.apache.camel.language.TokenPairPredicateTest

2011-12-06 Thread Claus Ibsen
Start a new thread if you start a new discussion. This thread was about a failed unit test from camel-core on Windows. On Mon, Dec 5, 2011 at 3:44 PM, bvahdat wrote: > Hi > > The fix you provided indeed did mitigated the issue I had on Windows > (TokenPairPredicateTest now passes as well), howev

Re: Riding on org.apache.camel.language.TokenPairPredicateTest

2011-12-06 Thread bvahdat
@Claus Would appreciate any update on the exception swallowing behaviour I mentioned in [1] if you could spare time for it. BTW that would be great if you could review the provided patch by [2], which also contains the fix I mentioned in [3]. [1] http://camel.465427.n5.nabble.com/Riding-on-org-a

Re: Riding on org.apache.camel.language.TokenPairPredicateTest

2011-12-05 Thread bvahdat
Hi The fix you provided indeed did mitigated the issue I had on Windows (TokenPairPredicateTest now passes as well), however my viewpoint as I shared in [1] is still pending. Effectively what I would expect to have in LoggingExceptionHandler is the code below, which *per default* rethrows the exce

Re: Riding on org.apache.camel.language.TokenPairPredicateTest

2011-12-05 Thread Claus Ibsen
I created a ticket https://issues.apache.org/jira/browse/CAMEL-4742 And have a fix for this in testing. On Mon, Dec 5, 2011 at 10:01 AM, bvahdat wrote: >> Yeah could be OS specific. Do you use Windows? > > the issue is indeed OS specific which is Windows, just saw the retries logic > in org.ap

Re: Riding on org.apache.camel.language.TokenPairPredicateTest

2011-12-05 Thread bvahdat
> Yeah could be OS specific. Do you use Windows? the issue is indeed OS specific which is Windows, just saw the retries logic in org.apache.camel.util.FileUtil.renameFile() as well as a lot of hits on Google... But as I've already mentioned in this thread that's not my concern at all but the way

Re: Riding on org.apache.camel.language.TokenPairPredicateTest

2011-12-05 Thread Claus Ibsen
Yeah could be OS specific. Do you use Windows? On Fri, Dec 2, 2011 at 3:52 PM, bvahdat wrote: > BTW, on the CI-Servers the test passed by the last build [1], so that maybe > it could be an OS issue as well. > > [1] > https://builds.apache.org/job/Camel.trunk.fulltest/org.apache.camel$camel-core/

Re: Riding on org.apache.camel.language.TokenPairPredicateTest

2011-12-02 Thread bvahdat
BTW, on the CI-Servers the test passed by the last build [1], so that maybe it could be an OS issue as well. [1] https://builds.apache.org/job/Camel.trunk.fulltest/org.apache.camel$camel-core/576/testReport/org.apache.camel.language/TokenPairPredicateTest/ Babak -- View this message in context: