Re: Feedback sought

2023-10-15 Thread Daniel Widdis
Spotless is another great option. spotless/plugin-maven/README.md at main · diffplug/spotlessgithub.comSent from my iPhoneOn Oct 15, 2023, at 7:16 AM, Joseph Kesselman wrote:Hm. Doesn't handle language-semantic formatting (yet?), which in my experience is often a bigger deal than spaces vs tabs.

Re: [m-javadoc-plugin] how to exclude transitive dependency

2023-03-26 Thread Daniel Widdis
hanks a lot for the answer! I'll try to contact authors of problematic library. It is weirs this library causing the issue, since it's classes are not being used directly (it it is transitive dependency) Compilation is successful and only Javadoc is failing ... On Mon, 27 Mar 202

Re: [m-javadoc-plugin] how to exclude transitive dependency

2023-03-26 Thread Daniel Widdis
The root of the problem is the automatic module name generation of the jool-java-8 jar file. By default it becomes jool.java.8 and a number by itself is an illegal portion of a module name. Without using "Automatic-Module-Name" your project builds on the classpath as always. When including th

Re: m-javadoc-plugin with JPMS

2022-10-17 Thread Daniel Widdis
I have filed issue https://issues.apache.org/jira/projects/MJAVADOC/issues/MJAVADOC-736 Simple reproducer project here (mvn javadoc:jar or mvn javadoc:javadoc fail): https://github.com/dbwiddis/foo From: Daniel Widdis Date: Sunday, October 16, 2022 at 10:47 PM To: Maven Users List

Re: m-javadoc-plugin with JPMS

2022-10-16 Thread Daniel Widdis
ule > > both has `module-info.java` > > > > let me add `module-info.java` to all modules (not sure why) so we can > > ensure this is not a problem :) > > > > On Wed, 20 Jul 2022 at 21:51, Daniel Widdis wrote: > > > > > > Some modules have module

Re: m-javadoc-plugin with JPMS

2022-07-20 Thread Daniel Widdis
>> >>> On Tue, 19 Jul 2022 at 13:16, Daniel Widdis wrote: >>>> >>>>> The only problem of having both is redundancy :) >>>> >>>> Technically speaking, you always have an automatic module name even if >>> you don't exp

Re: m-javadoc-plugin with JPMS

2022-07-18 Thread Daniel Widdis
2, 11:07 PM, "Maxim Solodovnik" wrote: Thanks for the answer Daniel :) On Tue, 19 Jul 2022 at 13:03, Daniel Widdis wrote: > > I think you're asking on the right list. And it's not a "basic" question but it isn't an obvious answer either.

Re: m-javadoc-plugin with JPMS

2022-07-18 Thread Daniel Widdis
I think you're asking on the right list. And it's not a "basic" question but it isn't an obvious answer either. I'm not sure your question has enough detail for anyone to deduce the answer. Linking to your project may help you get more attention on it. FWIW, I have both an automatic module na

Re: JPMS – Test sources extra Java SE module dependencies

2022-07-02 Thread Daniel Widdis
You are traveling a well-known path to many of us. I highly recommend taking a look at junit-platform-maven-plugin: https://github.com/sormuras/junit-platform-maven-plugin Blog post outlining how to do what you'e doing is here: https://sormuras.github.io/blog/2018-09-11-testing-in-the-modular-wo