Re: [T5.2.6] AfterRender phase method not called on Mixin when attached to Loop component

2011-11-03 Thread Steve Eynon
Here's the Jira to commit against: https://issues.apache.org/jira/browse/TAP5-1742 I understand why returning false (and effectively cancelling the render phase, e.g. setupRender) can be advantageous, but I can't think of a use case where returning true "and" cancelling / short circuiting the ren

Re: [T5.2.6] AfterRender phase method not called on Mixin when attached to Loop component

2011-11-02 Thread Taha Hafeez Siddiqi
Sounds good. I will try to do it today regards Taha On Nov 2, 2011, at 11:13 PM, Steve Eynon wrote: > Awesome, found it: > > http://tapestry.apache.org/component-rendering.html#ComponentRendering-ShortCircuiting > > I was thinking along these lines but wasn't sure what the exact > semantics

Re: [T5.2.6] AfterRender phase method not called on Mixin when attached to Loop component

2011-11-02 Thread Steve Eynon
Awesome, found it: http://tapestry.apache.org/component-rendering.html#ComponentRendering-ShortCircuiting I was thinking along these lines but wasn't sure what the exact semantics of returning true / false was. Am I right in thinking the Jira would be: AfterRender() in Loop component should not

Re: [T5.2.6] AfterRender phase method not called on Mixin when attached to Loop component

2011-11-02 Thread Taha Hafeez Siddiqi
Hi Steve Short Circuiting If a method returns a true or false value, this will short circuit processing. Other methods within the phase that would ordinarily be invoked will not be invoked. Most render phase methods should return void, to avoid unintentionally short circuiting other methods fo

Re: [T5.2.6] AfterRender phase method not called on Mixin when attached to Loop component

2011-11-02 Thread Steve Eynon
Cheers Taha, > in the later phases (AfterRender, CleanupRender) the order of executing is > reversed. Ah, okay (thanks). So the Mixin should be called when Loop afterRender method finally returns true ... but I'm not seeing it called at all, not even once!? P.S. Does this then mean that when u

Re: [T5.2.6] AfterRender phase method not called on Mixin when attached to Loop component

2011-11-02 Thread Taha Hafeez Siddiqi
Render Phase Ordering All mixins for a component execute their render phase methods before the component's render phase methods for most phases. However, in the later phases (AfterRender, CleanupRender) the order of executing is reversed. So if afterRender() of loop skips it, it never reaches th

Re: [T5.2.6] AfterRender phase method not called on Mixin when attached to Loop component

2011-11-02 Thread Steve Eynon
T5.3-rc-2 has the same behaviour. Can someone tell me I'm not crazy and that I *should* see the afterRender event firing? Or am I just missing something fundamental? I know the Loop component uses afterRender to return true / false to perform the loop, but I would still expect the Mixin render ph

[T5.2.6] AfterRender phase method not called on Mixin when attached to Loop component

2011-11-02 Thread Steve Eynon
Hiya, I have this snippet of tml: ${var:i} and this Mixin: public class LoopMixin { void beginRender() { System.err.println("LoopMixin: @beginRender"); } void afterRender() { System.err.println("LoopMixin: @afterRender");