Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Thiago H de Paula Figueiredo
On Fri, 24 Oct 2014 15:02:11 -0200, Charlouze wrote: I attached it but the issue is still closed... maybe you can reopen it. Thank you very much! I'll reopen it. -- Thiago H. de Paula Figueiredo Tapestry, Java and Hibernate consultant and developer http://machina.com.br

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Charlouze
I attached it but the issue is still closed... maybe you can reopen it. 2014-10-24 18:39 GMT+02:00 Thiago H de Paula Figueiredo : > On Fri, 24 Oct 2014 14:16:01 -0200, Charlouze wrote: > > Attached is a patch that add my issue to the test case commited in january > for TAP5-2029 by Thiago. It

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Thiago H de Paula Figueiredo
On Fri, 24 Oct 2014 14:16:01 -0200, Charlouze wrote: Attached is a patch that add my issue to the test case commited in january for TAP5-2029 by Thiago. It fails as expected :D Could you please post it in JIRA, in TAP5-2029 if possible or a new ticket otherwise? -- Thiago H. de Paula Fig

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Charlouze
Attached is a patch that add my issue to the test case commited in january for TAP5-2029 by Thiago. It fails as expected :D 2014-10-24 17:39 GMT+02:00 Lance Java : > If I was to take an educated guess, I'd guess that the solution will > involve checking java.lang.reflect.Method.isBridge() similar

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Lance Java
If I was to take an educated guess, I'd guess that the solution will involve checking java.lang.reflect.Method.isBridge() similar to TAP5-1493.

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Thiago H de Paula Figueiredo
On Fri, 24 Oct 2014 12:58:54 -0200, Charlouze wrote: Hey Thiago, Hi! I followed your conversation about copying annotation. I think that's great but it seems there are still some issues. I looked at your commits on that subject and it seems really tricky :D It surely is. Until Tapestry

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Charlouze
Hey Thiago, I'm using tapestry 5.4-beta-22. I followed your conversation about copying annotation. I think that's great but it seems there are still some issues. I looked at your commits on that subject and it seems really tricky :D I will try to write a test for you. 2014-10-24 16:48 GMT+02:00

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Thiago H de Paula Figueiredo
On Fri, 24 Oct 2014 12:30:32 -0200, Charlouze wrote: My question is related to TAP-2029 I think. Hello, Charlouze! Yep, that's directly related to TAP5-2029. I suppose you're already using one of the latest T5.4 betas, right? Before 5.4, th

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Charlouze
My question is related to TAP-2029 I think. 2014-10-24 16:17 GMT+02:00 George Christman : > nvm, I think I misunderstood your question. > > On Fri, Oct 24, 2014 at 10:12 AM, Charlouze wrote: > > > I just tried to remove the generic parameter from

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread George Christman
nvm, I think I misunderstood your question. On Fri, Oct 24, 2014 at 10:12 AM, Charlouze wrote: > I just tried to remove the generic parameter from interface A and it works > so it actually a generic parameter problem. > > It's a shame as my code seems less clean without it. > > Cheers, > Charles

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Charlouze
That part is OK... @CommitAfter works for other methods. 2014-10-24 16:16 GMT+02:00 George Christman : > If I'm not mistaking you need to advice tapestry of it and the annotation > will need to reside in your interface. I'm not sure if that changed in 5.4. > I added the following code to my app m

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread George Christman
If I'm not mistaking you need to advice tapestry of it and the annotation will need to reside in your interface. I'm not sure if that changed in 5.4. I added the following code to my app module to get it to work with my DAO's. @Match("*DAO") public static void adviseTransactions(HibernateTrans

Re: Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Charlouze
I just tried to remove the generic parameter from interface A and it works so it actually a generic parameter problem. It's a shame as my code seems less clean without it. Cheers, Charles. 2014-10-24 16:10 GMT+02:00 Charlouze : > Hey everyone, > > I'm facing an issue with @CommitAfter annotatio

Copied annotation from implementation to interface not working properly.

2014-10-24 Thread Charlouze
Hey everyone, I'm facing an issue with @CommitAfter annotation being placed on implementation. I have 2 interfaces A and B : public interface A { void methodA(T t); } public interface B extends A { void methodB(); } and one implementation BImpl : public class Bimpl implements B { @Annot