Re: Enhancement: New option 'persistAuthentication' for session manager

2020-02-17 Thread Carsten Klein
Jonathan, I'm not quite sure whether it's not too early for a PR... :-) I was waiting for some remarks on my code, prior to officially release a PR. Can't you just do a Compare on GitHub? Carsten Can you open a PR so we can diff your changes? Very excited to see this! We used a workaround

Expect: 100-continue with filters vs valves

2020-02-17 Thread Michael Osipov
I have continued some tests on 8.5.51 with PUT requests and Expect: 100 continue header from HttpClient 5.0. I have noticed that the very same code code fragment kicks in in the expect header evaluation when run as valve, but completely ignored when run in a filter. Tomcat will simply signal t

Re: Enhancement: New option 'persistAuthentication' for session manager

2020-02-17 Thread Rémy Maucherat
On Mon, Feb 17, 2020 at 6:31 PM Carsten Klein wrote: > Hi there, > > finally, I got my first Tomcat enhancement ready. You can view its code > at my Tomcat fork on GitHub: > > > https://github.com/cklein05/tomcat/tree/session-manager-persist-authentication > > Before I'm opening an enhancement in

Re: Tomcat responding 500 instead of 408

2020-02-17 Thread Michael Osipov
Am 2020-02-17 um 16:47 schrieb Mark Thomas: On 17/02/2020 15:07, Michael Osipov wrote: Folks, I am recently working an issue with Maven Wagon and HttpClient and noticed that Tomcat responds with 500 while I would expect 408 in this case. Tried very simple code on Tomcat 8.5.51: @Override

Re: Enhancement: New option 'persistAuthentication' for session manager

2020-02-17 Thread Jonathan S. Fisher
Can you open a PR so we can diff your changes? Very excited to see this! We used a workaround in a Valve to add the authentication information into the session. On Mon, Feb 17, 2020 at 11:31 AM Carsten Klein wrote: > Hi there, > > finally, I got my first Tomcat enhancement ready. You can view it

Enhancement: New option 'persistAuthentication' for session manager

2020-02-17 Thread Carsten Klein
Hi there, finally, I got my first Tomcat enhancement ready. You can view its code at my Tomcat fork on GitHub: https://github.com/cklein05/tomcat/tree/session-manager-persist-authentication Before I'm opening an enhancement in Tomcat's Bugzilla, maybe, Mark and Christopher (or whoever else i

Re: Tomcat responding 500 instead of 408

2020-02-17 Thread Mark Thomas
On 17/02/2020 15:07, Michael Osipov wrote: > Folks, > > I am recently working an issue with Maven Wagon and HttpClient and > noticed that Tomcat responds with 500 while I would expect 408 in this > case. > > Tried very simple code on Tomcat 8.5.51: >> @Override >> protected void doPut(Htt

Tomcat responding 500 instead of 408

2020-02-17 Thread Michael Osipov
Folks, I am recently working an issue with Maven Wagon and HttpClient and noticed that Tomcat responds with 500 while I would expect 408 in this case. Tried very simple code on Tomcat 8.5.51: @Override protected void doPut(HttpServletRequest request, HttpServletResponse respo