回覆: Persist function in host manager working in 9.0.60 but not 10.1.x

2023-07-26 Thread Fong Mason
Hi Chris, 寄件者: Christopher Schultz 寄件日期: 2023年7月27日 0:35 收件者: users@tomcat.apache.org 主旨: Re: Persist function in host manager working in 9.0.60 but not 10.1.x Mason, On 7/24/23 20:39, Fong Mason wrote: > Last month I setup a new Tomcat instance (10.1.9) since

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Christopher Schultz
Mark, On 7/26/23 13:58, Mark Thomas wrote: I'm not a huge fan of this feature in general. I prefer supporting features backed by specifications rather than vendor specific hacks. I think the PROXY protocol is fairly standard, even if it's not backed by an RFC. It's published by haproxy, but

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Jonathan S. Fisher
Mark, thankyou for your feedback. I hope to settle some worry here: > I prefer supporting features backed by specifications rather than vendor specific hacks. I totally understand and agree. This is a standardized specification with a control document. Spec:

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Mark Thomas
I'm not a huge fan of this feature in general. I prefer supporting features backed by specifications rather than vendor specific hacks. My support for any patch is going to depend on the specifics of the patch. In addition to the comments in the BZ - exposing the data as a request attribute is

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Amit Pande
Missed to ask this: Looking the patch, it involves modifying Tomcat code. Was wondering if it would be possible to refactor this patch and/or allow Tomcat core code to extend and plug-in the proxy protocol support? Thanks, Amit -Original Message- From: Amit Pande Sent: Wednesday, July

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Amit Pande
Chris, Mark, Any thoughts on this? Mark, if we clean up the patch and re-submit, do you will have any concerns (specially security wise)? Thanks, Amit -Original Message- From: Jonathan S. Fisher Sent: Monday, July 24, 2023 12:41 PM To: Tomcat Users List Subject: Re: [External] Re:

Re: Persist function in host manager working in 9.0.60 but not 10.1.x

2023-07-26 Thread Christopher Schultz
Mason, On 7/24/23 20:39, Fong Mason wrote: Last month I setup a new Tomcat instance (10.1.9) since I want to have a try of Spring 6.x. Everything was working fine until I need to add a new virtual host. I had followed the instructions in