Re: Support with error in launcher.log

2020-03-30 Thread Svetlin Zarev
Hi, We've had this error and it turned out to be due to the cookie processor. According to RFC6265, the domain attribute of the cookie must not start with a dot, so the new cookie processor rejects those cookies. Either remove the starting dot from the domain attribute or use the legacy cookie pro

How to get the number of "keep-alive" connections ?

2018-04-30 Thread Svetlin Zarev
Hi, The MBean "Catalina:type=ThreadPool,name="http-nio-8080"" has an attribute called "keepAliveCount" but instead of the keep-alive connections it returns the sum of the number of the pollers' selection keys (as a result it usually reports a low number in the range 0-4 in my test setup). The clos

Web sockets - issue with proxy handling

2017-01-13 Thread Svetlin Zarev
Hi all! Recently I stumbled in a possible bug in WsWebSocketContainer. When connecting to server, if the authority in the URI does not contain the remote port, the proxy rejects the connection. In WsWebSocketContainer the port is determined based on WS/WSS when constructing the InetSocketAddress f

Re: remove me from tomcat user list

2016-08-31 Thread Svetlin Zarev
Just send a blank mail to users-unsubscr...@tomcat.apache.org in order to unsubscribe Svetlin 2016-08-31 10:01 GMT+03:00 罗茂林 : > could someone remove me from the tomcat user list?

Re: Increased memory consumption due to url encoding

2016-08-30 Thread Svetlin Zarev
; -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Svetlin, > > On 8/28/16 12:57 PM, Svetlin Zarev wrote: > > Hi, > > > > Today I had some free time, so I implemented a more (memory and > > performance wise) efficient URLEncoder [1] and I'd like to &g

Re: Increased memory consumption due to url encoding

2016-08-28 Thread Svetlin Zarev
Hi, Today I had some free time, so I implemented a more (memory and performance wise) efficient URLEncoder [1] and I'd like to contribute it if there is interest for improvement in that area. My encoder has close to zero allocation rate (unless there is very high concurrency for the encode() oper

Re: Rfc6265CookieProcessor domain validation errors

2016-08-25 Thread Svetlin Zarev
Thanks Mark, this makes sense. Best regards, Svetlin This isn't a bug. You are misunderstanding the RFC. > > Domain attributes are only sent from servers to user agents. > > The general rule to keep in mind is: > "Be lenient in what you accept. Be strict in what you send." > > Section 5.2.3 appl

Re: Rfc6265CookieProcessor domain validation errors

2016-08-25 Thread Svetlin Zarev
Proposed fix: https://github.com/apache/tomcat85/pull/2 2016-08-25 10:28 GMT+03:00 Svetlin Zarev : > Hello! > > > > The new Rfc6265CookieProcessor fails to validate domains that start with a > dot. According to rfc6265#5.2.3 [1]: > > > > If the first character of

Rfc6265CookieProcessor minor improvement

2016-08-25 Thread Svetlin Zarev
Hello, I'd like to propose the following minor improvement to the cookie processor: https://github.com/apache/tomcat85/pull/1 Best regards, Svetlin

Rfc6265CookieProcessor domain validation errors

2016-08-25 Thread Svetlin Zarev
Hello! The new Rfc6265CookieProcessor fails to validate domains that start with a dot. According to rfc6265#5.2.3 [1]: If the first character of the attribute-value string is %x2E ("."): Let cookie-domain be the attribute-value without the leading %x2E (".") character. Otherwis

Tomcat backwards incompatible change

2016-08-03 Thread Svetlin Zarev
Hello! With [1] and [2] an incompatible change has been introduced to all current versions of Tomcat. The issue is that when calling requestDispatcher.forward(), the target servlet receives the encoded URL instead of the one used to obtain the dispatcher. This breaks all applications depending on

Tomcat does not log exceptions thrown by the valve chain

2016-04-01 Thread Svetlin Zarev
Hello, I have a custom authenticator valve which failed with an exception that never got logged by tomcat. After a little bit of digging in tomcat’s source it turned out that there is no valve responsible for logging exceptions thrown by valves later in the chain. The closest error handling m